Fix 'Check scoped proxy target for isDefaultCandidate'

philwebb · philwebb · commit 682ad665f51e · 2025-10-14T14:18:38.000-07:00
Fix accidental logic issue introduced in commit c14b57a. See gh-47633
diff --git a/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/OnBeanCondition.java b/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/OnBeanCondition.java
@@ -270,10 +270,10 @@ private Set<String> matchedNamesFrom(Map<String, BeanDefinition> namedDefinition
 
 	private boolean isCandidate(ConfigurableListableBeanFactory beanFactory, String name, BeanDefinition definition,
 			Set<String> ignoredBeans) {
-		if (ignoredBeans.contains(name) || definition == null) {
+		if (ignoredBeans.contains(name)) {
 			return false;
 		}
-		if (definition.isAutowireCandidate() && isDefaultCandidate(definition)) {
+		if (definition == null || (definition.isAutowireCandidate() && isDefaultCandidate(definition))) {
 			return true;
 		}
 		if (ScopedProxyUtils.isScopedTarget(name)) {

Original file line number	Diff line number	Diff line change
`@@ -270,10 +270,10 @@ private Set<String> matchedNamesFrom(Map<String, BeanDefinition> namedDefinition`
`270`	`270`
`271`	`271`	`private boolean isCandidate(ConfigurableListableBeanFactory beanFactory, String name, BeanDefinition definition,`
`272`	`272`	`Set<String> ignoredBeans) {`
`273`		`- if (ignoredBeans.contains(name) \|\| definition == null) {`
	`273`	`+ if (ignoredBeans.contains(name)) {`
`274`	`274`	`return false;`
`275`	`275`	`}`
`276`		`- if (definition.isAutowireCandidate() && isDefaultCandidate(definition)) {`
	`276`	`+ if (definition == null \|\| (definition.isAutowireCandidate() && isDefaultCandidate(definition))) {`
`277`	`277`	`return true;`
`278`	`278`	`}`
`279`	`279`	`if (ScopedProxyUtils.isScopedTarget(name)) {`