Add since attribute to uses of DeprecatedConfigurationProperty

Add an architecture rule to ensure that all usages of
`@DeprecatedConfigurationProperty` in the Spring Boot codebase include
the `since` attribute.

Add the `since` attribute to the few places where it was not already
included.

Author: scottfrederick

buildSrc/src/main/java/org/springframework/boot/build/architecture/ArchitectureRules.java

@@ -98,6 +98,7 @@ static List<ArchRule> standard() {
 		rules.add(methodLevelConfigurationPropertiesShouldNotSpecifyOnlyPrefixAttribute());
 		rules.add(conditionsShouldNotBePublic());
 		rules.add(allConfigurationPropertiesBindingBeanMethodsShouldBeStatic());
+		rules.add(allDeprecatedConfigurationPropertiesShouldIncludeSince());
 		return List.copyOf(rules);
 	}
 
@@ -348,6 +349,22 @@ private static ArchRule allConfigurationPropertiesBindingBeanMethodsShouldBeStat
 			.allowEmptyShould(true);
 	}
 
+	private static ArchRule allDeprecatedConfigurationPropertiesShouldIncludeSince() {
+		return methodsThatAreAnnotatedWith(
+				"org.springframework.boot.context.properties.DeprecatedConfigurationProperty")
+			.should(check("include a non-empty 'since' attribute", (method, events) -> {
+				JavaAnnotation<JavaMethod> annotation = method
+					.getAnnotationOfType("org.springframework.boot.context.properties.DeprecatedConfigurationProperty");
+				Map<String, Object> properties = annotation.getProperties();
+				Object since = properties.get("since");
+				if (!(since instanceof String) || ((String) since).isEmpty()) {
+					addViolation(events, method, annotation.getDescription()
+							+ " should include a non-empty 'since' attribute of @DeprecatedConfigurationProperty");
+				}
+			}))
+			.allowEmptyShould(true);
+	}
+
 	private static boolean containsOnlySingleType(JavaType[] types, JavaType type) {
 		return types.length == 1 && type.equals(types[0]);
 	}

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/flyway/FlywayProperties.java

@@ -794,7 +794,7 @@ public void setOutputQueryResults(Boolean outputQueryResults) {
 		this.outputQueryResults = outputQueryResults;
 	}
 
-	@DeprecatedConfigurationProperty(replacement = "spring.flyway.sqlserver.kerberos-login-file")
+	@DeprecatedConfigurationProperty(replacement = "spring.flyway.sqlserver.kerberos-login-file", since = "3.2.0")
 	@Deprecated(since = "3.2.0", forRemoval = true)
 	public String getSqlServerKerberosLoginFile() {
 		return getSqlserver().getKerberosLoginFile();

spring-boot-project/spring-boot-docs/src/main/java/org/springframework/boot/docs/appendix/configurationmetadata/format/property/MyProperties.java

@@ -33,7 +33,7 @@ public void setName(String name) {
 	}
 
 	@Deprecated
-	@DeprecatedConfigurationProperty(replacement = "my.app.name")
+	@DeprecatedConfigurationProperty(replacement = "my.app.name", since = "1.2.0")
 	public String getTarget() {
 		return this.name;
 	}

spring-boot-project/spring-boot-docs/src/main/kotlin/org/springframework/boot/docs/appendix/configurationmetadata/format/property/MyProperties.kt

@@ -23,7 +23,7 @@ import org.springframework.boot.context.properties.DeprecatedConfigurationProper
 class MyProperties(val name: String?) {
 
 	var target: String? = null
-		@Deprecated("") @DeprecatedConfigurationProperty(replacement = "my.app.name") get
+		@Deprecated("") @DeprecatedConfigurationProperty(replacement = "my.app.name", since = "1.2.0") get
 		@Deprecated("") set
 
 }