Polish code to use method references when possible

philwebb · philwebb · commit 350d27fe50d7 · 2022-05-17T21:16:42.000-07:00
diff --git a/buildSrc/src/main/java/org/springframework/boot/build/AsciidoctorConventions.java b/buildSrc/src/main/java/org/springframework/boot/build/AsciidoctorConventions.java
@@ -106,7 +106,7 @@ private void upgradeAsciidoctorJVersion(Project project) {
 	private void createAsciidoctorExtensionsConfiguration(Project project) {
 		project.getConfigurations().create(EXTENSIONS_CONFIGURATION_NAME, (configuration) -> {
 			project.getConfigurations().matching((candidate) -> "dependencyManagement".equals(candidate.getName()))
-					.all((dependencyManagement) -> configuration.extendsFrom(dependencyManagement));
+					.all(configuration::extendsFrom);
 			configuration.getDependencies().add(project.getDependencies()
 					.create("io.spring.asciidoctor.backends:spring-asciidoctor-backends:0.0.3"));
 			configuration.getDependencies()
diff --git a/buildSrc/src/main/java/org/springframework/boot/build/DeployedPlugin.java b/buildSrc/src/main/java/org/springframework/boot/build/DeployedPlugin.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2021 the original author or authors.
+ * Copyright 2012-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -43,18 +43,14 @@ public void apply(Project project) {
 		project.getPlugins().apply(MavenRepositoryPlugin.class);
 		PublishingExtension publishing = project.getExtensions().getByType(PublishingExtension.class);
 		MavenPublication mavenPublication = publishing.getPublications().create("maven", MavenPublication.class);
-		project.afterEvaluate((evaluated) -> {
-			project.getPlugins().withType(JavaPlugin.class).all((javaPlugin) -> {
-				if (((Jar) project.getTasks().getByName(JavaPlugin.JAR_TASK_NAME)).isEnabled()) {
-					project.getComponents().matching((component) -> component.getName().equals("java"))
-							.all((javaComponent) -> mavenPublication.from(javaComponent));
-				}
-			});
-		});
-		project.getPlugins().withType(JavaPlatformPlugin.class)
-				.all((javaPlugin) -> project.getComponents()
-						.matching((component) -> component.getName().equals("javaPlatform"))
-						.all((javaComponent) -> mavenPublication.from(javaComponent)));
+		project.afterEvaluate((evaluated) -> project.getPlugins().withType(JavaPlugin.class).all((javaPlugin) -> {
+			if (((Jar) project.getTasks().getByName(JavaPlugin.JAR_TASK_NAME)).isEnabled()) {
+				project.getComponents().matching((component) -> component.getName().equals("java"))
+						.all(mavenPublication::from);
+			}
+		}));
+		project.getPlugins().withType(JavaPlatformPlugin.class).all((javaPlugin) -> project.getComponents()
+				.matching((component) -> component.getName().equals("javaPlatform")).all(mavenPublication::from));
 	}
 
 }
diff --git a/buildSrc/src/main/java/org/springframework/boot/build/ExtractResources.java b/buildSrc/src/main/java/org/springframework/boot/build/ExtractResources.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2020 the original author or authors.
+ * Copyright 2012-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -28,7 +28,6 @@
 
 import org.gradle.api.DefaultTask;
 import org.gradle.api.GradleException;
-import org.gradle.api.Task;
 import org.gradle.api.file.DirectoryProperty;
 import org.gradle.api.tasks.Input;
 import org.gradle.api.tasks.OutputDirectory;
@@ -87,8 +86,7 @@ void extractResources() throws IOException {
 				throw new GradleException("Resource '" + resourceName + "' does not exist");
 			}
 			String resource = FileCopyUtils.copyToString(new InputStreamReader(resourceStream, StandardCharsets.UTF_8));
-			resource = this.propertyPlaceholderHelper.replacePlaceholders(resource,
-					(placeholder) -> this.properties.get(placeholder));
+			resource = this.propertyPlaceholderHelper.replacePlaceholders(resource, this.properties::get);
 			FileCopyUtils.copy(resource,
 					new FileWriter(this.destinationDirectory.file(resourceName).get().getAsFile()));
 		}
diff --git a/buildSrc/src/main/java/org/springframework/boot/build/JavaConventions.java b/buildSrc/src/main/java/org/springframework/boot/build/JavaConventions.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2021 the original author or authors.
+ * Copyright 2012-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -159,8 +159,8 @@ private void configureTestConventions(Project project) {
 		project.getTasks().withType(Test.class, (test) -> {
 			test.useJUnitPlatform();
 			test.setMaxHeapSize("1024M");
-			project.getTasks().withType(Checkstyle.class, (checkstyle) -> test.mustRunAfter(checkstyle));
-			project.getTasks().withType(CheckFormat.class, (checkFormat) -> test.mustRunAfter(checkFormat));
+			project.getTasks().withType(Checkstyle.class, test::mustRunAfter);
+			project.getTasks().withType(CheckFormat.class, test::mustRunAfter);
 		});
 		project.getPlugins().withType(JavaPlugin.class, (javaPlugin) -> project.getDependencies()
 				.add(JavaPlugin.TEST_RUNTIME_ONLY_CONFIGURATION_NAME, "org.junit.platform:junit-platform-launcher"));
diff --git a/buildSrc/src/main/java/org/springframework/boot/build/bom/bomr/InteractiveUpgradeResolver.java b/buildSrc/src/main/java/org/springframework/boot/build/bom/bomr/InteractiveUpgradeResolver.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2021 the original author or authors.
+ * Copyright 2012-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -24,6 +24,7 @@
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Set;
 import java.util.SortedSet;
 import java.util.stream.Collectors;
@@ -70,7 +71,7 @@ public List<Upgrade> resolveUpgrades(Collection<Library> libraries) {
 			librariesByName.put(library.getName(), library);
 		}
 		return libraries.stream().filter((library) -> !library.getName().equals("Spring Boot"))
-				.map((library) -> resolveUpgrade(library, librariesByName)).filter((upgrade) -> upgrade != null)
+				.map((library) -> resolveUpgrade(library, librariesByName)).filter(Objects::nonNull)
 				.collect(Collectors.toList());
 	}
 
diff --git a/buildSrc/src/main/java/org/springframework/boot/build/classpath/CheckClasspathForConflicts.java b/buildSrc/src/main/java/org/springframework/boot/build/classpath/CheckClasspathForConflicts.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2020 the original author or authors.
+ * Copyright 2012-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -68,7 +68,7 @@ public void checkForConflicts() throws IOException {
 		for (File file : this.classpath) {
 			if (file.isDirectory()) {
 				Path root = file.toPath();
-				Files.walk(root).filter((path) -> Files.isRegularFile(path))
+				Files.walk(root).filter(Files::isRegularFile)
 						.forEach((entry) -> classpathContents.add(root.relativize(entry).toString(), root.toString()));
 			}
 			else {
diff --git a/spring-boot-project/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/autoconfigure/DevToolsR2dbcAutoConfigurationTests.java b/spring-boot-project/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/autoconfigure/DevToolsR2dbcAutoConfigurationTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2021 the original author or authors.
+ * Copyright 2012-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -63,7 +63,7 @@ void reset() {
 
 		@Test
 		void autoConfiguredInMemoryConnectionFactoryIsShutdown() throws Exception {
-			ConfigurableApplicationContext context = getContext(() -> createContext());
+			ConfigurableApplicationContext context = getContext(this::createContext);
 			ConnectionFactory connectionFactory = context.getBean(ConnectionFactory.class);
 			context.close();
 			assertThat(shutdowns).contains(connectionFactory);
diff --git a/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/main/java/org/springframework/boot/gradle/plugin/WarPluginAction.java b/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/main/java/org/springframework/boot/gradle/plugin/WarPluginAction.java
@@ -91,7 +91,7 @@ private TaskProvider<BootWar> configureBootWarTask(Project project) {
 							.convention(resolveMainClassName.flatMap((resolver) -> manifestStartClass.isPresent()
 									? manifestStartClass : resolveMainClassName.get().readMainClassName()));
 				});
-		bootWarProvider.map((bootWar) -> bootWar.getClasspath());
+		bootWarProvider.map(War::getClasspath);
 		return bootWarProvider;
 	}
 
diff --git a/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/env/EnvironmentPostProcessorApplicationListener.java b/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/env/EnvironmentPostProcessorApplicationListener.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2021 the original author or authors.
+ * Copyright 2012-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -56,7 +56,7 @@ public class EnvironmentPostProcessorApplicationListener implements SmartApplica
 	 * {@link EnvironmentPostProcessor} classes loaded via {@code spring.factories}.
 	 */
 	public EnvironmentPostProcessorApplicationListener() {
-		this((classLoader) -> EnvironmentPostProcessorsFactory.fromSpringFactories(classLoader), new DeferredLogs());
+		this(EnvironmentPostProcessorsFactory::fromSpringFactories, new DeferredLogs());
 	}
 
 	/**
diff --git a/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/jdbc/DataSourceBuilder.java b/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/jdbc/DataSourceBuilder.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2021 the original author or authors.
+ * Copyright 2012-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -398,8 +398,7 @@ private static <T extends DataSource> MappedDataSourceProperties<T> lookupBasic(
 				Class<T> dataSourceType) {
 			MappedDataSourceProperties<T> result = null;
 			result = lookup(classLoader, dataSourceType, result,
-					"org.springframework.jdbc.datasource.SimpleDriverDataSource",
-					() -> new SimpleDataSourceProperties());
+					"org.springframework.jdbc.datasource.SimpleDriverDataSource", SimpleDataSourceProperties::new);
 			result = lookup(classLoader, dataSourceType, result, "oracle.jdbc.datasource.OracleDataSource",
 					OracleDataSourceProperties::new);
 			result = lookup(classLoader, dataSourceType, result, "org.h2.jdbcx.JdbcDataSource",
@@ -660,7 +659,7 @@ private static class SimpleDataSourceProperties extends MappedDataSourceProperti
 		SimpleDataSourceProperties() {
 			add(DataSourceProperty.URL, SimpleDriverDataSource::getUrl, SimpleDriverDataSource::setUrl);
 			add(DataSourceProperty.DRIVER_CLASS_NAME, Class.class, (dataSource) -> dataSource.getDriver().getClass(),
-					(dataSource, driverClass) -> dataSource.setDriverClass(driverClass));
+					SimpleDriverDataSource::setDriverClass);
 			add(DataSourceProperty.USERNAME, SimpleDriverDataSource::getUsername, SimpleDriverDataSource::setUsername);
 			add(DataSourceProperty.PASSWORD, SimpleDriverDataSource::getPassword, SimpleDriverDataSource::setPassword);
 		}
diff --git a/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/logging/log4j2/SpringBootPropertySource.java b/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/logging/log4j2/SpringBootPropertySource.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2021 the original author or authors.
+ * Copyright 2012-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -38,7 +38,7 @@ public class SpringBootPropertySource implements PropertySource {
 
 	@Override
 	public void forEach(BiConsumer<String, String> action) {
-		this.properties.forEach((key, value) -> action.accept(key, value));
+		this.properties.forEach(action::accept);
 	}
 
 	@Override
diff --git a/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/util/Instantiator.java b/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/util/Instantiator.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2021 the original author or authors.
+ * Copyright 2012-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -111,7 +111,7 @@ public List<T> instantiate(ClassLoader classLoader, Collection<String> names) {
 	 */
 	public List<T> instantiateTypes(Collection<Class<?>> types) {
 		Assert.notNull(types, "Types must not be null");
-		return instantiate(types.stream().map((type) -> TypeSupplier.forType(type)));
+		return instantiate(types.stream().map(TypeSupplier::forType));
 	}
 
 	private List<T> instantiate(Stream<TypeSupplier> typeSuppliers) {
diff --git a/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/netty/NettyWebServer.java b/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/netty/NettyWebServer.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2021 the original author or authors.
+ * Copyright 2012-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -116,8 +116,8 @@ public void start() throws WebServerException {
 
 	private String getStartedOnMessage(DisposableServer server) {
 		StringBuilder message = new StringBuilder();
-		tryAppend(message, "port %s", () -> server.port());
-		tryAppend(message, "path %s", () -> server.path());
+		tryAppend(message, "port %s", server::port);
+		tryAppend(message, "path %s", server::path);
 		return (message.length() > 0) ? " on " + message : "";
 	}
 
diff --git a/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/undertow/UndertowWebServer.java b/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/undertow/UndertowWebServer.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2021 the original author or authors.
+ * Copyright 2012-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -295,7 +295,7 @@ public void shutDownGracefully(GracefulShutdownCallback callback) {
 		logger.info("Commencing graceful shutdown. Waiting for active requests to complete");
 		this.gracefulShutdownCallback.set(callback);
 		this.gracefulShutdown.shutdown();
-		this.gracefulShutdown.addShutdownListener((success) -> notifyGracefulCallback(success));
+		this.gracefulShutdown.addShutdownListener(this::notifyGracefulCallback);
 	}
 
 	private void notifyGracefulCallback(boolean success) {
diff --git a/spring-boot-project/spring-boot/src/test/java/org/springframework/boot/context/properties/source/AliasedConfigurationPropertySourceTests.java b/spring-boot-project/spring-boot/src/test/java/org/springframework/boot/context/properties/source/AliasedConfigurationPropertySourceTests.java
@@ -20,6 +20,7 @@
 
 import org.junit.jupiter.api.Test;
 import org.mockito.Answers;
+import org.mockito.invocation.InvocationOnMock;
 
 import org.springframework.boot.testsupport.classpath.ClassPathOverrides;
 
@@ -119,7 +120,7 @@ private Object getValue(ConfigurationPropertySource source, String name) {
 
 	private ConfigurationPropertySource mockConfigurationPropertySource() {
 		ConfigurationPropertySource mock = mock(ConfigurationPropertySource.class);
-		given(mock.withAliases(any())).willAnswer((invocation) -> invocation.callRealMethod());
+		given(mock.withAliases(any())).willAnswer(InvocationOnMock::callRealMethod);
 		return mock;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ private TaskProvider<BootWar> configureBootWarTask(Project project) {`
`91`	`91`	`.convention(resolveMainClassName.flatMap((resolver) -> manifestStartClass.isPresent()`
`92`	`92`	`? manifestStartClass : resolveMainClassName.get().readMainClassName()));`
`93`	`93`	`});`
`94`		`- bootWarProvider.map((bootWar) -> bootWar.getClasspath());`
	`94`	`+ bootWarProvider.map(War::getClasspath);`
`95`	`95`	`return bootWarProvider;`
`96`	`96`	`}`
`97`	`97`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*`
`2`		`- * Copyright 2012-2021 the original author or authors.`
	`2`	`+ * Copyright 2012-2022 the original author or authors.`
`3`	`3`	`*`
`4`	`4`	`* Licensed under the Apache License, Version 2.0 (the "License");`
`5`	`5`	`* you may not use this file except in compliance with the License.`
`@@ -56,7 +56,7 @@ public class EnvironmentPostProcessorApplicationListener implements SmartApplica`
`56`	`56`	`* {@link EnvironmentPostProcessor} classes loaded via {@code spring.factories}.`
`57`	`57`	`*/`
`58`	`58`	`public EnvironmentPostProcessorApplicationListener() {`
`59`		`- this((classLoader) -> EnvironmentPostProcessorsFactory.fromSpringFactories(classLoader), new DeferredLogs());`
	`59`	`+ this(EnvironmentPostProcessorsFactory::fromSpringFactories, new DeferredLogs());`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`/**`