Do not wrap CF JSON Keys containing special characters

This reverts commit 6828a15.
The commit has been reverted as it breaks backwards compatiblity.

Fixes gh-20343

Author: mbhave

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/cloud/CloudFoundryVcapEnvironmentPostProcessor.java

@@ -87,7 +87,6 @@
  *
  * @author Dave Syer
  * @author Andy Wilkinson
- * @author Madhura Bhave
  * @since 1.3.0
  */
 public class CloudFoundryVcapEnvironmentPostProcessor
@@ -231,19 +230,7 @@ private String getPropertyName(String path, String key) {
 		if (key.startsWith("[")) {
 			return path + key;
 		}
-		if (shouldWrap(key)) {
-			return path + "[" + key + "]";
-		}
 		return path + "." + key;
 	}
 
-	private boolean shouldWrap(String key) {
-		for (char ch : key.toCharArray()) {
-			if (!Character.isLowerCase(ch) && !Character.isDigit(ch) && ch != '-') {
-				return true;
-			}
-		}
-		return false;
-	}
-
 }

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/cloud/cloudfoundry/CloudFoundryVcapEnvironmentPostProcessorTests.java

@@ -30,8 +30,6 @@
  *
  * @author Dave Syer
  * @author Andy Wilkinson
- * @author Hans Schulz
- * @author Madhura Bhave
  */
 public class CloudFoundryVcapEnvironmentPostProcessorTests {
 
@@ -119,26 +117,6 @@ public void testServicePropertiesWithoutNA() {
 		assertThat(getProperty("vcap.services.mysql.credentials.port")).isEqualTo("3306");
 	}
 
-	@Test
-	public void testServicePropertiesContainingKeysWithDot() {
-		TestPropertySourceUtils.addInlinedPropertiesToEnvironment(this.context,
-				"VCAP_SERVICES={\"user-provided\":[{\"name\":\"test\",\"label\":\"test-label\","
-						+ "\"credentials\":{\"key.with.dots\":\"some-value\"}}]}");
-		this.initializer.postProcessEnvironment(this.context.getEnvironment(), null);
-		assertThat(getProperty("vcap.services.test.name")).isEqualTo("test");
-		assertThat(getProperty("vcap.services.test.credentials[key.with.dots]")).isEqualTo("some-value");
-	}
-
-	@Test
-	public void testServicePropertiesContainingKeysWithUpperCaseAndNonAlphaNumericCharacters() {
-		TestPropertySourceUtils.addInlinedPropertiesToEnvironment(this.context,
-				"VCAP_SERVICES={\"user-provided\":[{\"name\":\"test\",\"label\":\"test-label\","
-						+ "\"credentials\":{\"My-Key\":\"some-value\", \"foo@\":\"bar\"}}]}");
-		this.initializer.postProcessEnvironment(this.context.getEnvironment(), null);
-		assertThat(getProperty("vcap.services.test.credentials[My-Key]")).isEqualTo("some-value");
-		assertThat(getProperty("vcap.services.test.credentials[foo@]")).isEqualTo("bar");
-	}
-
 	private String getProperty(String key) {
 		return this.context.getEnvironment().getProperty(key);
 	}