Skip to content

Commit fa2c1ae

Browse files
committed
Re-enable RabbitMultiBinderObservationTests
Spring Boot now has a dedicated `spring-boot-micrometer-tracing-brave` module to auto-configure Brave tracing * Remove redundant now `micrometer-tracing-bridge-brave` dependency * Remove comment for the `@AutoConfigureMetric` from the `RabbitMultiBinderObservationTests` since test logic does nothing with metrics * Fix comment for spans in the trace: now Spring Integration handlers are also report their observation even in binder context
1 parent a5d6e3b commit fa2c1ae

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

binders/rabbit-binder/spring-cloud-stream-binder-rabbit/pom.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,11 @@
5252
<artifactId>spring-boot-autoconfigure</artifactId>
5353
<optional>true</optional>
5454
</dependency>
55+
<dependency>
56+
<groupId>org.springframework.boot</groupId>
57+
<artifactId>spring-boot-micrometer-tracing-brave</artifactId>
58+
<scope>test</scope>
59+
</dependency>
5560
<dependency>
5661
<groupId>org.springframework.boot</groupId>
5762
<artifactId>spring-boot-micrometer-tracing-test</artifactId>
@@ -115,11 +120,6 @@
115120
<version>1.17.1</version>
116121
<scope>test</scope>
117122
</dependency>
118-
<dependency>
119-
<groupId>io.micrometer</groupId>
120-
<artifactId>micrometer-tracing-bridge-brave</artifactId>
121-
<scope>test</scope>
122-
</dependency>
123123
<dependency>
124124
<groupId>io.micrometer</groupId>
125125
<artifactId>micrometer-tracing-integration-test</artifactId>

binders/rabbit-binder/spring-cloud-stream-binder-rabbit/src/test/java/org/springframework/cloud/stream/binder/rabbit/integration/RabbitMultiBinderObservationTests.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,13 @@
1919
import java.util.concurrent.CountDownLatch;
2020
import java.util.concurrent.TimeUnit;
2121
import java.util.function.Consumer;
22-
import java.util.stream.Collectors;
2322

2423
import brave.handler.SpanHandler;
2524
import brave.test.TestSpanHandler;
2625
import io.micrometer.observation.Observation;
2726
import io.micrometer.observation.ObservationRegistry;
2827
import io.micrometer.tracing.brave.bridge.BraveFinishedSpan;
2928
import io.micrometer.tracing.test.simple.SpansAssert;
30-
import org.junit.jupiter.api.Disabled;
3129
import org.junit.jupiter.api.Test;
3230
import org.springframework.boot.micrometer.tracing.test.autoconfigure.AutoConfigureTracing;
3331
import org.testcontainers.containers.RabbitMQContainer;
@@ -54,9 +52,7 @@
5452
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE,
5553
args = "--spring.config.location=classpath:/rabbit-multi-binder-observation.yml")
5654
@DirtiesContext
57-
//@AutoConfigureMetric
5855
@AutoConfigureTracing
59-
@Disabled
6056
public class RabbitMultiBinderObservationTests {
6157

6258
private static final TestSpanHandler SPANS = new TestSpanHandler();
@@ -86,9 +82,9 @@ void observationIsPropagatedInMultiBinderConfiguration() throws InterruptedExcep
8682

8783
// There is a race condition when we already have a reply, but the span in the
8884
// Rabbit listener is not closed yet.
89-
// parent -> StreamBridge -> RabbitTemplate -> Rabbit Listener -> Consumer
85+
// parent -> StreamBridge -> AmqpOutboundEndpoint -> RabbitTemplate -> Rabbit Listener -> Consumer
9086
await().untilAsserted(() -> assertThat(SPANS.spans()).hasSize(6));
91-
SpansAssert.assertThat(SPANS.spans().stream().map(BraveFinishedSpan::fromBrave).collect(Collectors.toList()))
87+
SpansAssert.assertThat(SPANS.spans().stream().map(BraveFinishedSpan::fromBrave).toList())
9288
.haveSameTraceId();
9389
}
9490

0 commit comments

Comments
 (0)