Skip to content

Commit b2aaf9f

Browse files
committed
Revise usage of @EnableConfigurationProperties
1. use `@EnableConfigurationProperties` to register configuration properties beans if the bean name is not relevant. 2. remove `@EnableConfigurationProperties` without specified value if the `@Configuration` class doesn't contain any `@ConfigurationProperties` bean. Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
1 parent a3ef42f commit b2aaf9f

File tree

5 files changed

+1
-14
lines changed

5 files changed

+1
-14
lines changed

spring-cloud-commons/src/main/java/org/springframework/cloud/commons/util/UtilAutoConfiguration.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,9 @@
2929
@Configuration(proxyBeanMethods = false)
3030
@ConditionalOnProperty(value = "spring.cloud.util.enabled", matchIfMissing = true)
3131
@AutoConfigureOrder(0)
32-
@EnableConfigurationProperties
32+
@EnableConfigurationProperties(InetUtilsProperties.class)
3333
public class UtilAutoConfiguration {
3434

35-
@Bean
36-
public InetUtilsProperties inetUtilsProperties() {
37-
return new InetUtilsProperties();
38-
}
39-
4035
@Bean
4136
@ConditionalOnMissingBean
4237
public InetUtils inetUtils(InetUtilsProperties properties) {

spring-cloud-commons/src/test/java/org/springframework/cloud/client/actuator/FeaturesEndpointTests.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import org.junit.jupiter.api.Test;
2525

2626
import org.springframework.beans.factory.annotation.Autowired;
27-
import org.springframework.boot.context.properties.EnableConfigurationProperties;
2827
import org.springframework.boot.jackson.autoconfigure.JacksonAutoConfiguration;
2928
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
3029
import org.springframework.context.annotation.Bean;
@@ -85,7 +84,6 @@ HasFeatures localFeatures() {
8584
}
8685

8786
@Configuration(proxyBeanMethods = false)
88-
@EnableConfigurationProperties
8987
public static class Config {
9088

9189
@Autowired(required = false)

spring-cloud-commons/src/test/java/org/springframework/cloud/client/discovery/health/DiscoveryClientHealthIndicatorTests.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import org.junit.jupiter.api.Test;
2222

2323
import org.springframework.beans.factory.annotation.Autowired;
24-
import org.springframework.boot.context.properties.EnableConfigurationProperties;
2524
import org.springframework.boot.health.contributor.CompositeHealthContributor;
2625
import org.springframework.boot.health.contributor.Health;
2726
import org.springframework.boot.health.contributor.HealthContributor;
@@ -80,7 +79,6 @@ private Status assertHealth(Health health, Status expected) {
8079
}
8180

8281
@Configuration(proxyBeanMethods = false)
83-
@EnableConfigurationProperties
8482
public static class Config {
8583

8684
@Bean

spring-cloud-context/src/test/java/org/springframework/cloud/bootstrap/TestBootstrapConfiguration.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import java.util.List;
2121

2222
import org.springframework.beans.factory.annotation.Qualifier;
23-
import org.springframework.boot.context.properties.EnableConfigurationProperties;
2423
import org.springframework.context.ApplicationContextInitializer;
2524
import org.springframework.context.ApplicationEventPublisher;
2625
import org.springframework.context.ConfigurableApplicationContext;
@@ -37,7 +36,6 @@
3736
*/
3837
@Order(0)
3938
@Configuration(proxyBeanMethods = false)
40-
@EnableConfigurationProperties
4139
public class TestBootstrapConfiguration {
4240

4341
public static List<String> fooSightings = null;

spring-cloud-context/src/test/java/org/springframework/cloud/bootstrap/config/BootstrapConfigurationTests.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import org.springframework.boot.WebApplicationType;
2929
import org.springframework.boot.builder.SpringApplicationBuilder;
3030
import org.springframework.boot.context.properties.ConfigurationProperties;
31-
import org.springframework.boot.context.properties.EnableConfigurationProperties;
3231
import org.springframework.boot.context.properties.bind.Bindable;
3332
import org.springframework.boot.context.properties.bind.Binder;
3433
import org.springframework.cloud.bootstrap.BootstrapApplicationListener;
@@ -758,7 +757,6 @@ public void bootstrapPropertiesWithActivateOnProfile() {
758757
}
759758

760759
@Configuration(proxyBeanMethods = false)
761-
@EnableConfigurationProperties
762760
protected static class BareConfiguration {
763761

764762
}

0 commit comments

Comments
 (0)