Skip to content

Commit d6fc1a3

Browse files
committed
adding kvstore_owner as new property
commenting the need to set kvstore owner to default value of "nobody" as new property is created for the kvstore owner with default to "nobody"
1 parent 8dea5eb commit d6fc1a3

File tree

4 files changed

+12
-9
lines changed

4 files changed

+12
-9
lines changed

splunklib/client.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -678,25 +678,28 @@ def splunk_version(self):
678678

679679
@property
680680
def kvstore_owner(self):
681+
"""Returns the KVStore owner for this instance of Splunk.
682+
683+
By default is the kvstore owner is not set, it will return "nobody"
684+
:return: A string with the KVStore owner.
685+
"""
681686
if self._kvstore_owner is None:
682687
self._kvstore_owner = "nobody"
683-
#self.namespace['owner'] = "nobody"
684688
return self._kvstore_owner
685689

686690
@kvstore_owner.setter
687691
def kvstore_owner(self, value):
688692
self._kvstore_owner = value
689-
#self.namespace['owner'] = value
690693

691694
@property
692695
def kvstore(self):
693696
"""Returns the collection of KV Store collections.
694697
698+
sets the owner for the namespace, before retrieving the KVStore Collection
699+
695700
:return: A :class:`KVStoreCollections` collection of :class:`KVStoreCollection` entities.
696701
"""
697702
self.namespace['owner'] = self.kvstore_owner
698-
# if self.namespace['owner'] is None:
699-
# self.namespace['owner'] = "nobody"
700703
return KVStoreCollections(self)
701704

702705
@property

tests/test_kvstore_batch.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
class KVStoreBatchTestCase(testlib.SDKTestCase):
2727
def setUp(self):
2828
super(KVStoreBatchTestCase, self).setUp()
29-
self.service.namespace['owner'] = 'nobody'
29+
#self.service.namespace['owner'] = 'nobody'
3030
self.service.namespace['app'] = 'search'
3131
confs = self.service.kvstore
3232
if ('test' in confs):

tests/test_kvstore_conf.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,16 @@
2525
class KVStoreConfTestCase(testlib.SDKTestCase):
2626
def setUp(self):
2727
super(KVStoreConfTestCase, self).setUp()
28-
self.service.namespace['owner'] = 'nobody'
28+
#self.service.namespace['owner'] = 'nobody'
2929
self.service.namespace['app'] = 'search'
3030
self.confs = self.service.kvstore
3131
if ('test' in self.confs):
3232
self.confs['test'].delete()
3333

3434
def test_owner_restriction(self):
35-
self.service.namespace['owner'] = 'admin'
35+
self.service.kvstore_owner = 'admin'
3636
self.assertRaises(client.HTTPError, lambda: self.confs.list())
37-
self.service.namespace['owner'] = 'nobody'
37+
self.service.kvstore_owner = 'nobody'
3838

3939
def test_create_delete_collection(self):
4040
self.confs.create('test')

tests/test_kvstore_data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
class KVStoreDataTestCase(testlib.SDKTestCase):
2828
def setUp(self):
2929
super(KVStoreDataTestCase, self).setUp()
30-
self.service.namespace['owner'] = 'nobody'
30+
#self.service.namespace['owner'] = 'nobody'
3131
self.service.namespace['app'] = 'search'
3232
self.confs = self.service.kvstore
3333
if ('test' in self.confs):

0 commit comments

Comments
 (0)