From 211c0f2ede3d089c65e1598adca75cea0b5b55d1 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 01:03:21 -0400 Subject: [PATCH 01/33] Use diamond operator --- .../logging/HttpEventCollectorSender.java | 2 +- .../com/splunk/logging/SplunkCimLogEvent.java | 2 +- .../java/com/splunk/logging/TcpAppender.java | 2 +- src/test/java/HttpEventCollectorUnitTest.java | 4 +-- .../HttpEventCollector_JavaLoggingTest.java | 36 +++++++++---------- .../java/HttpEventCollector_Log4j2Test.java | 30 ++++++++-------- .../java/HttpEventCollector_LogbackTest.java | 28 +++++++-------- src/test/java/HttpEventCollector_Test.java | 4 +-- src/test/java/HttpLoggerStressTest.java | 2 +- src/test/java/TestUtil.java | 4 +-- 10 files changed, 57 insertions(+), 57 deletions(-) diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorSender.java b/src/main/java/com/splunk/logging/HttpEventCollectorSender.java index c5ddfda8..3b4c7527 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorSender.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorSender.java @@ -79,7 +79,7 @@ public enum SendMode private long maxEventsBatchCount; private long maxEventsBatchSize; private Timer timer; - private List eventsBatch = new LinkedList(); + private List eventsBatch = new LinkedList<>(); private long eventsBatchSize = 0; // estimated total size of events batch private static final OkHttpClient httpSharedClient = new OkHttpClient(); // shared instance with the default settings private OkHttpClient httpClient = null; // shares the same connection pool and thread pools with the shared instance diff --git a/src/main/java/com/splunk/logging/SplunkCimLogEvent.java b/src/main/java/com/splunk/logging/SplunkCimLogEvent.java index 861c374b..cf7ea0ae 100644 --- a/src/main/java/com/splunk/logging/SplunkCimLogEvent.java +++ b/src/main/java/com/splunk/logging/SplunkCimLogEvent.java @@ -61,7 +61,7 @@ public class SplunkCimLogEvent { * @param eventID event ID */ public SplunkCimLogEvent(String eventName, String eventID) { - entries = new LinkedHashMap(); + entries = new LinkedHashMap<>(); addField(PREFIX_NAME, eventName); addField(PREFIX_EVENT_ID, eventID); diff --git a/src/main/java/com/splunk/logging/TcpAppender.java b/src/main/java/com/splunk/logging/TcpAppender.java index eeb00511..7421d8f6 100644 --- a/src/main/java/com/splunk/logging/TcpAppender.java +++ b/src/main/java/com/splunk/logging/TcpAppender.java @@ -243,7 +243,7 @@ public void start() { // Dispatch this instance of the appender. if (!errorPresent) { - queue = queueSize <= 0 ? new SynchronousQueue() : new ArrayBlockingQueue(queueSize); + queue = queueSize <= 0 ? new SynchronousQueue<>() : new ArrayBlockingQueue<>(queueSize); ThreadFactory factory = new ThreadFactory() { @Override public Thread newThread(Runnable r) { diff --git a/src/test/java/HttpEventCollectorUnitTest.java b/src/test/java/HttpEventCollectorUnitTest.java index 2961934b..b7f4fca6 100644 --- a/src/test/java/HttpEventCollectorUnitTest.java +++ b/src/test/java/HttpEventCollectorUnitTest.java @@ -36,7 +36,7 @@ public class HttpEventCollectorUnitTest { @Test public void log4j_simple() throws Exception { - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); String loggerName = "splunk.log4jSimple"; userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", "11111111-2222-3333-4444-555555555555"); @@ -68,7 +68,7 @@ public void input(List events) { @Test public void logback_simple() throws Exception { - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); final String loggerName = "splunk.logback"; userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", "11111111-2222-3333-4444-555555555555"); diff --git a/src/test/java/HttpEventCollector_JavaLoggingTest.java b/src/test/java/HttpEventCollector_JavaLoggingTest.java index 32127d78..9a03befc 100644 --- a/src/test/java/HttpEventCollector_JavaLoggingTest.java +++ b/src/test/java/HttpEventCollector_JavaLoggingTest.java @@ -30,8 +30,8 @@ public final class HttpEventCollector_JavaLoggingTest { private String httpEventCollectorName = "JavaLoggingTest"; - List> errors = new ArrayList>(); - List logEx = new ArrayList(); + List> errors = new ArrayList<>(); + List logEx = new ArrayList<>(); /** * sending a message via httplogging using java.logging to splunk @@ -43,7 +43,7 @@ public void canSendEventUsingJavaLogging() throws Exception { String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "splunkLoggerNoOptions"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_logger_name", loggerName); TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); @@ -67,7 +67,7 @@ public void canSendEventUsingJavaLoggingWithOptions() throws Exception { String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "splunkLoggerWithOptions"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_logger_name", loggerName); userInputs.put("user_host", "host.example.com"); @@ -95,7 +95,7 @@ public void sendBatchedEventsUsingJavaLogging() throws Exception { String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "splunkBatchLogger"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_batch_interval", "0"); userInputs.put("user_batch_size_bytes", "0"); @@ -123,7 +123,7 @@ public void sendBatchedEventsByCount() throws Exception { //clean out the events cache by setting send events immediately String loggerName = "splunkLoggerCountCleanCache"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_logger_name", loggerName); TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); @@ -144,7 +144,7 @@ public void sendBatchedEventsByCount() throws Exception { TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); logger = Logger.getLogger(loggerName); - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging1}", new Date().toString()); logger.info(jsonMsg); @@ -188,7 +188,7 @@ public void sendBatchedEventsByBatchsize() throws Exception { String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "splunkBatchLoggerSize"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_batch_interval", "0"); userInputs.put("user_batch_size_bytes", "500"); @@ -200,7 +200,7 @@ public void sendBatchedEventsByBatchsize() throws Exception { TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); Logger logger = Logger.getLogger(loggerName); - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); int size = 0; String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for java logging size 1}", new Date().toString()); @@ -248,7 +248,7 @@ public void error(final List data, final Exception //create a token used for httpEventCollector logging, then make it becomes invalid String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "errorHandlingInvalidToken"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); @@ -316,7 +316,7 @@ public void error(final List data, final Exception //create a token used for httpEventCollector logging, then make it becomes invalid String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "disabledendpoint"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); @@ -364,7 +364,7 @@ private String queueEvents() throws Exception { //clean out the events cache by setting send events immediately String loggerName = "splunkLoggerqueueEventsCleanCache"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_logger_name", loggerName); TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); @@ -385,7 +385,7 @@ private String queueEvents() throws Exception { TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); logger = Logger.getLogger(loggerName); - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging1}", new Date().toString()); logger.info(jsonMsg); @@ -407,7 +407,7 @@ public void eventsIsIndexedInOrderOfSent() throws Exception { String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "splunkLoggerMultipleEvents"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_logger_name", loggerName); userInputs.put("user_index", indexName); @@ -417,7 +417,7 @@ public void eventsIsIndexedInOrderOfSent() throws Exception { Logger logger = Logger.getLogger(loggerName); //send multiple events and verify they are indexed in the order of sending - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); Date date = new Date(); int totalEventsCount = 1000; String prefix = "javalogging multiple events"; @@ -459,7 +459,7 @@ public void canSendEventUsingJavaLoggingWithUserEventBodySerializer() throws Exc String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "splunkLoggerBodySerializer"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_logger_name", loggerName); userInputs.put("user_eventBodySerializer", "TestEventBodySerializer"); @@ -487,7 +487,7 @@ public void canSendEventUsingJavaLoggingWithUserEventHeaderSerializer() throws E String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "splunkLoggerHeaderSerializer"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_logger_name", loggerName); userInputs.put("user_eventHeaderSerializer", "TestEventHeaderSerializer"); @@ -515,7 +515,7 @@ private void canSendJsonEventUsingUtilLoggerWithSourceType(final String sourceTy TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); - final List msgs = new ArrayList(); + final List msgs = new ArrayList<>(); final long timeMillsec = new Date().getTime(); diff --git a/src/test/java/HttpEventCollector_Log4j2Test.java b/src/test/java/HttpEventCollector_Log4j2Test.java index b049f812..8a356c9f 100644 --- a/src/test/java/HttpEventCollector_Log4j2Test.java +++ b/src/test/java/HttpEventCollector_Log4j2Test.java @@ -30,7 +30,7 @@ public final class HttpEventCollector_Log4j2Test { private String httpEventCollectorName = "Log4j2Test"; - List> errors = new ArrayList>(); + List> errors = new ArrayList<>(); List logEx = new ArrayList<>(); /** @@ -41,12 +41,12 @@ public void canSendEventUsingLog4j2() throws Exception, IOException, Interrupted TestUtil.enableHttpEventCollector(); String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "splunkLogger4j2"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); org.apache.logging.log4j.core.LoggerContext context = TestUtil.resetLog4j2Configuration("log4j2_template.xml", "log4j2.xml", userInputs); //use httplogger - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); Date date = new Date(); String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for log4j2}", date.toString()); @@ -74,7 +74,7 @@ public void canSendEventUsingLog4j2WithOptions() throws Exception, IOException, String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "splunkLogger4j2WithOptions"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_index", "main"); @@ -84,7 +84,7 @@ public void canSendEventUsingLog4j2WithOptions() throws Exception, IOException, org.apache.logging.log4j.core.LoggerContext context = TestUtil.resetLog4j2Configuration("log4j2_template.xml", "log4j2.xml", userInputs); //use httplogger - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); Date date = new Date(); String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for log4j2}", date.toString()); @@ -112,7 +112,7 @@ public void sendBatchedEventsByCount() throws Exception { //clean out the events cache by setting send events immediately String loggerName = "splunkLoggerCountCleanCache"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); LoggerContext context = TestUtil.resetLog4j2Configuration("log4j2_template.xml", "log4j2.xml", userInputs); @@ -121,7 +121,7 @@ public void sendBatchedEventsByCount() throws Exception { logger.info(jsonMsg); loggerName = "splunkBatchLoggerCount"; - userInputs = new HashMap(); + userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_batch_interval","0"); @@ -134,7 +134,7 @@ public void sendBatchedEventsByCount() throws Exception { context = TestUtil.resetLog4j2Configuration("log4j2_template.xml", "log4j2.xml", userInputs); logger = context.getLogger(loggerName); - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging1}", new Date().toString()); logger.info(jsonMsg); @@ -176,7 +176,7 @@ public void sendBatchedEventsByCount() throws Exception { public void sendBatchedEventsByBatchsize() throws Exception { String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "splunkLoggerBatchSize"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_batch_size_bytes", "500"); @@ -188,7 +188,7 @@ public void sendBatchedEventsByBatchsize() throws Exception { LoggerContext context = TestUtil.resetLog4j2Configuration("log4j2_template.xml", "log4j2.xml", userInputs); Logger logger = context.getLogger(loggerName); - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); int size = 0; String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for log4j size 1}", new Date().toString()); logger.info(jsonMsg); @@ -235,7 +235,7 @@ public void error(final List data, final Exception httpEventCollectorName = "wrongtoken"; String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "errorHandlingInvalidTokenLog4j"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); LoggerContext context = TestUtil.resetLog4j2Configuration("log4j2_template.xml", "log4j2.xml", userInputs); @@ -304,7 +304,7 @@ public void error(final List data, final Exception httpEventCollectorName = "wrongtoken"; String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "errorHandlingDisabledHttpEventCollectorEndpoint"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); LoggerContext context = TestUtil.resetLog4j2Configuration("log4j2_template.xml", "log4j2.xml", userInputs); @@ -345,7 +345,7 @@ public void eventsIsIndexedInOrderOfSent() throws Exception { TestUtil.createIndex(indexName); String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "splunkLogger4j2OrderOfSent"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_index", indexName); @@ -354,7 +354,7 @@ public void eventsIsIndexedInOrderOfSent() throws Exception { org.apache.logging.log4j.core.LoggerContext context = TestUtil.resetLog4j2Configuration("log4j2_template.xml", "log4j2.xml", userInputs); //send multiple events and verify they are indexed in the order of sending - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); Date date = new Date(); int totalEventsCount = 1000; Logger logger = context.getLogger(loggerName); @@ -400,7 +400,7 @@ private void canSendJsonEventUsingUtilLoggerWithSourceType(final String sourceTy final Logger logger = context.getLogger(loggerName); - final List msgs = new ArrayList(); + final List msgs = new ArrayList<>(); final long timeMillsec = new Date().getTime(); diff --git a/src/test/java/HttpEventCollector_LogbackTest.java b/src/test/java/HttpEventCollector_LogbackTest.java index 3fa2c20e..80107f91 100644 --- a/src/test/java/HttpEventCollector_LogbackTest.java +++ b/src/test/java/HttpEventCollector_LogbackTest.java @@ -30,8 +30,8 @@ public final class HttpEventCollector_LogbackTest { private String httpEventCollectorName = "LogbackTest"; - List> errors = new ArrayList>(); - List logEx = new ArrayList(); + List> errors = new ArrayList<>(); + List logEx = new ArrayList<>(); /** * sending a message via httplogging using logback to splunk @@ -42,13 +42,13 @@ public void canSendEventUsingLogback() throws Exception { String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "logBackLogger"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_defined_httpEventCollector_token", token); TestUtil.resetLogbackConfiguration("logback_template.xml", "logback.xml", userInputs); - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); Date date = new Date(); String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for Logback Test}", date.toString()); @@ -76,7 +76,7 @@ public void canSendEventUsingLogbackWithOptions() throws Exception { String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "logBackLogger"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_host", "host.example.com"); @@ -84,7 +84,7 @@ public void canSendEventUsingLogbackWithOptions() throws Exception { userInputs.put("user_sourcetype", "battlecat"); TestUtil.resetLogbackConfiguration("logback_template.xml", "logback.xml", userInputs); - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); Date date = new Date(); String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for Logback Test}", date.toString()); @@ -112,7 +112,7 @@ public void canSendBatchEventByCount() throws Exception { String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "logBackBatchLoggerCount"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_httpEventCollector_token", token); //userInputs.put("user_batch_interval","0"); userInputs.put("user_batch_size_count", "5"); @@ -125,7 +125,7 @@ public void canSendBatchEventByCount() throws Exception { TestUtil.resetLogbackConfiguration("logback_template.xml", "logback.xml", userInputs); Logger logger = LoggerFactory.getLogger(loggerName); - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for logback 1}", new Date().toString()); logger.info(jsonMsg); msgs.add(jsonMsg); @@ -168,7 +168,7 @@ public void canSendBatchEventBySize() throws Exception { String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "logBackBatchLoggerSize"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_batch_size_bytes", "500"); userInputs.put("user_logger_name", loggerName); @@ -179,7 +179,7 @@ public void canSendBatchEventBySize() throws Exception { TestUtil.resetLogbackConfiguration("logback_template.xml", "logback.xml", userInputs); Logger logger = LoggerFactory.getLogger(loggerName); - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); int size = 0; String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for java logging size 1}", new Date().toString()); @@ -229,7 +229,7 @@ public void error(final List data, final Exception httpEventCollectorName = "wrongtoken"; String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "wrongToken"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); TestUtil.resetLogbackConfiguration("logback_template.xml", "logback.xml", userInputs); @@ -295,7 +295,7 @@ public void error(final List data, final Exception httpEventCollectorName = "wrongtoken"; String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "wrongToken"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); TestUtil.resetLogbackConfiguration("logback_template.xml", "logback.xml", userInputs); @@ -337,7 +337,7 @@ public void eventsIsIndexedInOrderOfSent() throws Exception { TestUtil.createIndex(indexName); String loggerName = "logBackLogger"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_defined_httpinput_token", token); @@ -346,7 +346,7 @@ public void eventsIsIndexedInOrderOfSent() throws Exception { TestUtil.resetLogbackConfiguration("logback_template.xml", "logback.xml", userInputs); Date date = new Date(); - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); Logger logger = LoggerFactory.getLogger(loggerName); //send multiple events and verify they are indexed in the order of sending diff --git a/src/test/java/HttpEventCollector_Test.java b/src/test/java/HttpEventCollector_Test.java index 35a32920..fa8e4c39 100644 --- a/src/test/java/HttpEventCollector_Test.java +++ b/src/test/java/HttpEventCollector_Test.java @@ -121,7 +121,7 @@ public void TryToLogToSplunkWithDisabledHttpEventCollector() throws Exception { //modify the config file with the generated token String loggerName = "splunkLogger_disabled"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_httpEventCollector_token", token); if (batching) { userInputs.put("user_batch_interval", "200"); @@ -278,7 +278,7 @@ public void error(final List data, final Exception String token = setupHttpEventCollector(batching); System.out.printf("HTTP event collector fully set\n"); Service service = TestUtil.connectToSplunk(); - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_retries_on_error", "1000"); diff --git a/src/test/java/HttpLoggerStressTest.java b/src/test/java/HttpLoggerStressTest.java index 3f21ea03..d089ab10 100644 --- a/src/test/java/HttpLoggerStressTest.java +++ b/src/test/java/HttpLoggerStressTest.java @@ -98,7 +98,7 @@ private static int getEventsCount(String searchQuery) throws IOException, Interr private static void setupHttpEventCollector() throws Exception { String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "splunkStressHttpLogger"; - HashMap userInputs = new HashMap(); + HashMap userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_batch_size_count", "1"); diff --git a/src/test/java/TestUtil.java b/src/test/java/TestUtil.java index d6c291a1..b88d6e1d 100644 --- a/src/test/java/TestUtil.java +++ b/src/test/java/TestUtil.java @@ -481,7 +481,7 @@ public static void verifyEventsSentInOrder(String prefix, int totalEventsCount, long startTime = System.currentTimeMillis(); InputStream resultsStream = null; ResultsReaderXml resultsReader = null; - List results = new ArrayList(); + List results = new ArrayList<>(); while (System.currentTimeMillis() - startTime < 100 * 1000)/*wait for up to 30s*/ { results.clear(); String searchstr = "search index=" + index; @@ -519,7 +519,7 @@ public static void verifyEventsSentInOrder(String prefix, int totalEventsCount, * @return the hash map */ public static HashMap buildUserInputMap(final String loggerName, final String token, final String sourceType, final String messageFormat) { - final HashMap userInputs = new HashMap(); + final HashMap userInputs = new HashMap<>(); userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_host", "host.example.com"); From 88fcda050e72ddd645ae62c42deca25404642138 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 01:21:24 -0400 Subject: [PATCH 02/33] Replace anonymous types with lambdas --- .../logging/HttpEventCollectorSender.java | 7 +-- .../java/com/splunk/logging/TcpAppender.java | 11 ++--- src/test/java/HttpEventCollectorUnitTest.java | 18 +++---- .../HttpEventCollector_JavaLoggingTest.java | 20 ++++---- .../java/HttpEventCollector_Log4j2Test.java | 20 ++++---- .../java/HttpEventCollector_LogbackTest.java | 20 ++++---- src/test/java/HttpEventCollector_Test.java | 24 ++++------ src/test/java/Util.java | 47 +++++++++---------- 8 files changed, 68 insertions(+), 99 deletions(-) diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorSender.java b/src/main/java/com/splunk/logging/HttpEventCollectorSender.java index 3b4c7527..032f681b 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorSender.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorSender.java @@ -339,12 +339,7 @@ public java.security.cert.X509Certificate[] getAcceptedIssuers() { builder.sslSocketFactory(sslSocketFactory, (X509TrustManager) trustAllCerts[0]); } catch (Exception ignored) { /* nop */ } - builder.hostnameVerifier(new HostnameVerifier() { - @Override - public boolean verify(String hostname, SSLSession session) { - return true; - } - }); + builder.hostnameVerifier((hostname, session) -> true); } httpClient = builder.build(); diff --git a/src/main/java/com/splunk/logging/TcpAppender.java b/src/main/java/com/splunk/logging/TcpAppender.java index 7421d8f6..f0fc704c 100644 --- a/src/main/java/com/splunk/logging/TcpAppender.java +++ b/src/main/java/com/splunk/logging/TcpAppender.java @@ -244,13 +244,10 @@ public void start() { // Dispatch this instance of the appender. if (!errorPresent) { queue = queueSize <= 0 ? new SynchronousQueue<>() : new ArrayBlockingQueue<>(queueSize); - ThreadFactory factory = new ThreadFactory() { - @Override - public Thread newThread(Runnable r) { - Thread t = new Thread(r, "splunk-tcp-appender"); - t.setDaemon(true); - return t; - } + ThreadFactory factory = r -> { + Thread t = new Thread(r, "splunk-tcp-appender"); + t.setDaemon(true); + return t; }; executor = Executors.newSingleThreadExecutor(factory); executor.execute(this); diff --git a/src/test/java/HttpEventCollectorUnitTest.java b/src/test/java/HttpEventCollectorUnitTest.java index b7f4fca6..c1ccfbe8 100644 --- a/src/test/java/HttpEventCollectorUnitTest.java +++ b/src/test/java/HttpEventCollectorUnitTest.java @@ -149,13 +149,11 @@ public HttpEventCollectorUnitTestMiddleware.HttpResponse output() { ); } }; - HttpEventCollectorErrorHandler.onError(new HttpEventCollectorErrorHandler.ErrorCallback() { - public void error(final List data, final Exception ex) { - HttpEventCollectorErrorHandler.ServerErrorException serverErrorException = - (HttpEventCollectorErrorHandler.ServerErrorException) ex; - Assert.assertTrue(serverErrorException.getReply().compareTo("{\"text\":\"error\",\"code\":4}") == 0); - Assert.assertTrue(serverErrorException.getErrorCode() == 4); - } + HttpEventCollectorErrorHandler.onError((data, ex) -> { + HttpEventCollectorErrorHandler.ServerErrorException serverErrorException = + (HttpEventCollectorErrorHandler.ServerErrorException) ex; + Assert.assertTrue(serverErrorException.getReply().compareTo("{\"text\":\"error\",\"code\":4}") == 0); + Assert.assertTrue(serverErrorException.getErrorCode() == 4); }); LOGGER.info("hello"); Assert.assertTrue(HttpEventCollectorUnitTestMiddleware.eventsReceived == 1); @@ -229,10 +227,8 @@ public HttpEventCollectorUnitTestMiddleware.HttpResponse output() { 0, "{\"text\":\"error\",\"code\":4}"); } }; - HttpEventCollectorErrorHandler.onError(new HttpEventCollectorErrorHandler.ErrorCallback() { - public void error(final List data, final Exception ex) { - // ignore errors - } + HttpEventCollectorErrorHandler.onError((data, ex) -> { + // ignore errors }); LOGGER.info("hello"); // the system should make only 2 retries and stop after that diff --git a/src/test/java/HttpEventCollector_JavaLoggingTest.java b/src/test/java/HttpEventCollector_JavaLoggingTest.java index 9a03befc..79762002 100644 --- a/src/test/java/HttpEventCollector_JavaLoggingTest.java +++ b/src/test/java/HttpEventCollector_JavaLoggingTest.java @@ -236,12 +236,10 @@ public void errorHandlingInvalidToken() throws Exception { errors.clear(); logEx.clear(); //define error callback - HttpEventCollectorErrorHandler.onError(new HttpEventCollectorErrorHandler.ErrorCallback() { - public void error(final List data, final Exception ex) { - synchronized (errors) { - errors.add(data); - logEx.add((HttpEventCollectorErrorHandler.ServerErrorException) ex); - } + HttpEventCollectorErrorHandler.onError((data, ex) -> { + synchronized (errors) { + errors.add(data); + logEx.add((HttpEventCollectorErrorHandler.ServerErrorException) ex); } }); @@ -304,12 +302,10 @@ public void errorHandlingDisabledHttpEventCollectorEndpoint() throws Exception { logEx.clear(); //define error callback - HttpEventCollectorErrorHandler.onError(new HttpEventCollectorErrorHandler.ErrorCallback() { - public void error(final List data, final Exception ex) { - synchronized (errors) { - errors.add(data); - logEx.add((HttpEventCollectorErrorHandler.ServerErrorException) ex); - } + HttpEventCollectorErrorHandler.onError((data, ex) -> { + synchronized (errors) { + errors.add(data); + logEx.add((HttpEventCollectorErrorHandler.ServerErrorException) ex); } }); diff --git a/src/test/java/HttpEventCollector_Log4j2Test.java b/src/test/java/HttpEventCollector_Log4j2Test.java index 8a356c9f..8bd34ddd 100644 --- a/src/test/java/HttpEventCollector_Log4j2Test.java +++ b/src/test/java/HttpEventCollector_Log4j2Test.java @@ -222,12 +222,10 @@ public void errorHandlingInvalidToken() throws Exception { errors.clear(); logEx.clear(); //define error callback - HttpEventCollectorErrorHandler.onError(new HttpEventCollectorErrorHandler.ErrorCallback() { - public void error(final List data, final Exception ex) { - synchronized (errors) { - errors.add(data); - logEx.add((HttpEventCollectorErrorHandler.ServerErrorException) ex); - } + HttpEventCollectorErrorHandler.onError((data, ex) -> { + synchronized (errors) { + errors.add(data); + logEx.add((HttpEventCollectorErrorHandler.ServerErrorException) ex); } }); @@ -291,12 +289,10 @@ public void errorHandlingDisabledHttpEventCollectorEndpoint() throws Exception { logEx.clear(); //define error callback - HttpEventCollectorErrorHandler.onError(new HttpEventCollectorErrorHandler.ErrorCallback() { - public void error(final List data, final Exception ex) { - synchronized (errors) { - errors.add(data); - logEx.add((HttpEventCollectorErrorHandler.ServerErrorException) ex); - } + HttpEventCollectorErrorHandler.onError((data, ex) -> { + synchronized (errors) { + errors.add(data); + logEx.add((HttpEventCollectorErrorHandler.ServerErrorException) ex); } }); diff --git a/src/test/java/HttpEventCollector_LogbackTest.java b/src/test/java/HttpEventCollector_LogbackTest.java index 80107f91..6d87f10d 100644 --- a/src/test/java/HttpEventCollector_LogbackTest.java +++ b/src/test/java/HttpEventCollector_LogbackTest.java @@ -216,12 +216,10 @@ public void errorHandlingInvalidToken() throws Exception { errors.clear(); logEx.clear(); //define error callback - HttpEventCollectorErrorHandler.onError(new HttpEventCollectorErrorHandler.ErrorCallback() { - public void error(final List data, final Exception ex) { - synchronized (errors) { - errors.add(data); - logEx.add((HttpEventCollectorErrorHandler.ServerErrorException) ex); - } + HttpEventCollectorErrorHandler.onError((data, ex) -> { + synchronized (errors) { + errors.add(data); + logEx.add((HttpEventCollectorErrorHandler.ServerErrorException) ex); } }); @@ -282,12 +280,10 @@ public void errorHandlingDisabledHttpEventCollectorEndpoint() throws Exception { logEx.clear(); //define error callback - HttpEventCollectorErrorHandler.onError(new HttpEventCollectorErrorHandler.ErrorCallback() { - public void error(final List data, final Exception ex) { - synchronized (errors) { - errors.add(data); - logEx.add((HttpEventCollectorErrorHandler.ServerErrorException) ex); - } + HttpEventCollectorErrorHandler.onError((data, ex) -> { + synchronized (errors) { + errors.add(data); + logEx.add((HttpEventCollectorErrorHandler.ServerErrorException) ex); } }); diff --git a/src/test/java/HttpEventCollector_Test.java b/src/test/java/HttpEventCollector_Test.java index fa8e4c39..1577c2ac 100644 --- a/src/test/java/HttpEventCollector_Test.java +++ b/src/test/java/HttpEventCollector_Test.java @@ -200,13 +200,11 @@ private boolean insertDataWithLoggerAndVerify(String token, String loggerType, i } private void LogToSplunk(boolean batching) throws Exception { - HttpEventCollectorErrorHandler.onError(new HttpEventCollectorErrorHandler.ErrorCallback() { - public void error(final List data, final Exception ex) { - HttpEventCollectorErrorHandler.ServerErrorException serverErrorException = - (HttpEventCollectorErrorHandler.ServerErrorException) ex; - System.out.printf("ERROR: %s", ex.toString()); - Assert.assertTrue(false); - } + HttpEventCollectorErrorHandler.onError((data, ex) -> { + HttpEventCollectorErrorHandler.ServerErrorException serverErrorException = + (HttpEventCollectorErrorHandler.ServerErrorException) ex; + System.out.printf("ERROR: %s", ex.toString()); + Assert.assertTrue(false); }); int expectedCounter = 2; System.out.printf("\tSetting up http event collector with %s ... ", batching ? "batching" : "no batching"); @@ -265,13 +263,11 @@ public void run() { @Test public void ResendDataToSplunk() throws Exception { - HttpEventCollectorErrorHandler.onError(new HttpEventCollectorErrorHandler.ErrorCallback() { - public void error(final List data, final Exception ex) { - HttpEventCollectorErrorHandler.ServerErrorException serverErrorException = - (HttpEventCollectorErrorHandler.ServerErrorException) ex; - System.out.printf("ERROR: %s", ex.toString()); - Assert.assertTrue(false); - } + HttpEventCollectorErrorHandler.onError((data, ex) -> { + HttpEventCollectorErrorHandler.ServerErrorException serverErrorException = + (HttpEventCollectorErrorHandler.ServerErrorException) ex; + System.out.printf("ERROR: %s", ex.toString()); + Assert.assertTrue(false); }); boolean batching = false; System.out.printf("\tSetting up http event collector with %s ... ", batching ? "batching" : "no batching"); diff --git a/src/test/java/Util.java b/src/test/java/Util.java index 603897d3..208083e8 100644 --- a/src/test/java/Util.java +++ b/src/test/java/Util.java @@ -60,36 +60,33 @@ public static class StringContainer { public static StringContainer readLineFromPort(final int port, final int timeoutInMs) { final StringContainer container = new StringContainer(); - new Thread(new Runnable() { - @Override - public void run() { - ServerSocket serverSocket = null; - Socket socket = null; + new Thread(() -> { + ServerSocket serverSocket = null; + Socket socket = null; - try { - serverSocket = new ServerSocket(port); - serverSocket.setSoTimeout(timeoutInMs); - socket = serverSocket.accept(); - BufferedReader in = new BufferedReader(new InputStreamReader(socket.getInputStream())); - container.value = in.readLine(); + try { + serverSocket = new ServerSocket(port); + serverSocket.setSoTimeout(timeoutInMs); + socket = serverSocket.accept(); + BufferedReader in = new BufferedReader(new InputStreamReader(socket.getInputStream())); + container.value = in.readLine(); + } catch (IOException e) { + e.printStackTrace(); + } finally { + if (socket != null) try { + socket.close(); } catch (IOException e) { e.printStackTrace(); - } finally { - if (socket != null) try { - socket.close(); - } catch (IOException e) { - e.printStackTrace(); - } + } - if (serverSocket != null) try { - serverSocket.close(); - } catch (IOException e) { - e.printStackTrace(); - } + if (serverSocket != null) try { + serverSocket.close(); + } catch (IOException e) { + e.printStackTrace(); + } - synchronized (container) { - container.notifyAll(); - } + synchronized (container) { + container.notifyAll(); } } }).start(); From ba793b01859f457b978a772396ae2f383a980f13 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 01:26:35 -0400 Subject: [PATCH 03/33] Replace javadoc comments with block comments --- .../HttpEventCollectorErrorHandler.java | 4 ++-- .../logging/HttpEventCollectorEventInfo.java | 4 ++-- .../HttpEventCollectorLoggingHandler.java | 18 +++++++++--------- .../logging/HttpEventCollectorMiddleware.java | 4 ++-- .../HttpEventCollectorResendMiddleware.java | 4 ++-- .../logging/HttpEventCollectorSender.java | 4 ++-- .../com/splunk/logging/SplunkCimLogEvent.java | 4 ++-- src/test/java/HttpEventCollectorUnitTest.java | 4 ++-- .../HttpEventCollectorUnitTestMiddleware.java | 4 ++-- src/test/java/HttpEventCollector_Test.java | 4 ++-- 10 files changed, 27 insertions(+), 27 deletions(-) diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorErrorHandler.java b/src/main/java/com/splunk/logging/HttpEventCollectorErrorHandler.java index b8e1074c..c11a75c0 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorErrorHandler.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorErrorHandler.java @@ -1,7 +1,7 @@ package com.splunk.logging; -/** - * @copyright +/* + @copyright * * Copyright 2013-2015 Splunk, Inc. * diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorEventInfo.java b/src/main/java/com/splunk/logging/HttpEventCollectorEventInfo.java index 7fd9f977..6359513d 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorEventInfo.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorEventInfo.java @@ -1,7 +1,7 @@ package com.splunk.logging; -/** - * @copyright +/* + @copyright * * Copyright 2013-2015 Splunk, Inc. * diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorLoggingHandler.java b/src/main/java/com/splunk/logging/HttpEventCollectorLoggingHandler.java index 912d4bd2..2792788f 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorLoggingHandler.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorLoggingHandler.java @@ -1,7 +1,7 @@ package com.splunk.logging; -/** - * @copyright +/* + @copyright * * Copyright 2013-2015 Splunk, Inc. * @@ -18,13 +18,13 @@ * under the License. */ -/** - * A handler for java.util.logging that works with Splunk http event collector. - * - * details - * This is a Splunk custom java.util.logging handler that intercepts logging - * information and forwards it to a Splunk server through http event collector. - * @todo - link to http event collector documentation +/* + A handler for java.util.logging that works with Splunk http event collector. + + details + This is a Splunk custom java.util.logging handler that intercepts logging + information and forwards it to a Splunk server through http event collector. + @todo - link to http event collector documentation * java.util.logging is configure by specifying java.util.logging.config.file * properties file. For example: * -Djava.util.logging.config.file=splunk-http-input.properties diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorMiddleware.java b/src/main/java/com/splunk/logging/HttpEventCollectorMiddleware.java index e4123b7c..4ccf998c 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorMiddleware.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorMiddleware.java @@ -1,7 +1,7 @@ package com.splunk.logging; -/** - * @copyright +/* + @copyright * * Copyright 2013-2015 Splunk, Inc. * diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorResendMiddleware.java b/src/main/java/com/splunk/logging/HttpEventCollectorResendMiddleware.java index b4e7b201..82939436 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorResendMiddleware.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorResendMiddleware.java @@ -1,7 +1,7 @@ package com.splunk.logging; -/** - * @copyright +/* + @copyright * * Copyright 2013-2015 Splunk, Inc. * diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorSender.java b/src/main/java/com/splunk/logging/HttpEventCollectorSender.java index 032f681b..81c29259 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorSender.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorSender.java @@ -1,7 +1,7 @@ package com.splunk.logging; -/** - * @copyright +/* + @copyright * * Copyright 2013-2015 Splunk, Inc. * diff --git a/src/main/java/com/splunk/logging/SplunkCimLogEvent.java b/src/main/java/com/splunk/logging/SplunkCimLogEvent.java index cf7ea0ae..7574b718 100644 --- a/src/main/java/com/splunk/logging/SplunkCimLogEvent.java +++ b/src/main/java/com/splunk/logging/SplunkCimLogEvent.java @@ -157,8 +157,8 @@ public String toString() { private static final String THROWABLE_MESSAGE = "throwable_message"; private static final String THROWABLE_STACKTRACE_ELEMENTS = "stacktrace_elements"; - /** - * Splunk Common Information Model(CIM) Fields + /* + Splunk Common Information Model(CIM) Fields */ // ------------------ diff --git a/src/test/java/HttpEventCollectorUnitTest.java b/src/test/java/HttpEventCollectorUnitTest.java index c1ccfbe8..9a5501fb 100644 --- a/src/test/java/HttpEventCollectorUnitTest.java +++ b/src/test/java/HttpEventCollectorUnitTest.java @@ -1,5 +1,5 @@ -/** - * @copyright +/* + @copyright * * Copyright 2013-2015 Splunk, Inc. * diff --git a/src/test/java/HttpEventCollectorUnitTestMiddleware.java b/src/test/java/HttpEventCollectorUnitTestMiddleware.java index 0d272cd0..9fc59f65 100644 --- a/src/test/java/HttpEventCollectorUnitTestMiddleware.java +++ b/src/test/java/HttpEventCollectorUnitTestMiddleware.java @@ -3,8 +3,8 @@ import java.util.List; -/** - * @copyright +/* + @copyright * * Copyright 2013-2015 Splunk, Inc. * diff --git a/src/test/java/HttpEventCollector_Test.java b/src/test/java/HttpEventCollector_Test.java index 1577c2ac..99df5bf1 100644 --- a/src/test/java/HttpEventCollector_Test.java +++ b/src/test/java/HttpEventCollector_Test.java @@ -1,5 +1,5 @@ -/** - * @copyright +/* + @copyright * * Copyright 2013-2015 Splunk, Inc. * From 0c0d4c94198a17d1936af1eba04677b09d47c015 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 01:29:37 -0400 Subject: [PATCH 04/33] Revert "Replace javadoc comments with block comments" This reverts commit ba793b01859f457b978a772396ae2f383a980f13. --- .../HttpEventCollectorErrorHandler.java | 4 ++-- .../logging/HttpEventCollectorEventInfo.java | 4 ++-- .../HttpEventCollectorLoggingHandler.java | 18 +++++++++--------- .../logging/HttpEventCollectorMiddleware.java | 4 ++-- .../HttpEventCollectorResendMiddleware.java | 4 ++-- .../logging/HttpEventCollectorSender.java | 4 ++-- .../com/splunk/logging/SplunkCimLogEvent.java | 4 ++-- src/test/java/HttpEventCollectorUnitTest.java | 4 ++-- .../HttpEventCollectorUnitTestMiddleware.java | 4 ++-- src/test/java/HttpEventCollector_Test.java | 4 ++-- 10 files changed, 27 insertions(+), 27 deletions(-) diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorErrorHandler.java b/src/main/java/com/splunk/logging/HttpEventCollectorErrorHandler.java index c11a75c0..b8e1074c 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorErrorHandler.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorErrorHandler.java @@ -1,7 +1,7 @@ package com.splunk.logging; -/* - @copyright +/** + * @copyright * * Copyright 2013-2015 Splunk, Inc. * diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorEventInfo.java b/src/main/java/com/splunk/logging/HttpEventCollectorEventInfo.java index 6359513d..7fd9f977 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorEventInfo.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorEventInfo.java @@ -1,7 +1,7 @@ package com.splunk.logging; -/* - @copyright +/** + * @copyright * * Copyright 2013-2015 Splunk, Inc. * diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorLoggingHandler.java b/src/main/java/com/splunk/logging/HttpEventCollectorLoggingHandler.java index 2792788f..912d4bd2 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorLoggingHandler.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorLoggingHandler.java @@ -1,7 +1,7 @@ package com.splunk.logging; -/* - @copyright +/** + * @copyright * * Copyright 2013-2015 Splunk, Inc. * @@ -18,13 +18,13 @@ * under the License. */ -/* - A handler for java.util.logging that works with Splunk http event collector. - - details - This is a Splunk custom java.util.logging handler that intercepts logging - information and forwards it to a Splunk server through http event collector. - @todo - link to http event collector documentation +/** + * A handler for java.util.logging that works with Splunk http event collector. + * + * details + * This is a Splunk custom java.util.logging handler that intercepts logging + * information and forwards it to a Splunk server through http event collector. + * @todo - link to http event collector documentation * java.util.logging is configure by specifying java.util.logging.config.file * properties file. For example: * -Djava.util.logging.config.file=splunk-http-input.properties diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorMiddleware.java b/src/main/java/com/splunk/logging/HttpEventCollectorMiddleware.java index 4ccf998c..e4123b7c 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorMiddleware.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorMiddleware.java @@ -1,7 +1,7 @@ package com.splunk.logging; -/* - @copyright +/** + * @copyright * * Copyright 2013-2015 Splunk, Inc. * diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorResendMiddleware.java b/src/main/java/com/splunk/logging/HttpEventCollectorResendMiddleware.java index 82939436..b4e7b201 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorResendMiddleware.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorResendMiddleware.java @@ -1,7 +1,7 @@ package com.splunk.logging; -/* - @copyright +/** + * @copyright * * Copyright 2013-2015 Splunk, Inc. * diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorSender.java b/src/main/java/com/splunk/logging/HttpEventCollectorSender.java index 81c29259..032f681b 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorSender.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorSender.java @@ -1,7 +1,7 @@ package com.splunk.logging; -/* - @copyright +/** + * @copyright * * Copyright 2013-2015 Splunk, Inc. * diff --git a/src/main/java/com/splunk/logging/SplunkCimLogEvent.java b/src/main/java/com/splunk/logging/SplunkCimLogEvent.java index 7574b718..cf7ea0ae 100644 --- a/src/main/java/com/splunk/logging/SplunkCimLogEvent.java +++ b/src/main/java/com/splunk/logging/SplunkCimLogEvent.java @@ -157,8 +157,8 @@ public String toString() { private static final String THROWABLE_MESSAGE = "throwable_message"; private static final String THROWABLE_STACKTRACE_ELEMENTS = "stacktrace_elements"; - /* - Splunk Common Information Model(CIM) Fields + /** + * Splunk Common Information Model(CIM) Fields */ // ------------------ diff --git a/src/test/java/HttpEventCollectorUnitTest.java b/src/test/java/HttpEventCollectorUnitTest.java index 9a5501fb..c1ccfbe8 100644 --- a/src/test/java/HttpEventCollectorUnitTest.java +++ b/src/test/java/HttpEventCollectorUnitTest.java @@ -1,5 +1,5 @@ -/* - @copyright +/** + * @copyright * * Copyright 2013-2015 Splunk, Inc. * diff --git a/src/test/java/HttpEventCollectorUnitTestMiddleware.java b/src/test/java/HttpEventCollectorUnitTestMiddleware.java index 9fc59f65..0d272cd0 100644 --- a/src/test/java/HttpEventCollectorUnitTestMiddleware.java +++ b/src/test/java/HttpEventCollectorUnitTestMiddleware.java @@ -3,8 +3,8 @@ import java.util.List; -/* - @copyright +/** + * @copyright * * Copyright 2013-2015 Splunk, Inc. * diff --git a/src/test/java/HttpEventCollector_Test.java b/src/test/java/HttpEventCollector_Test.java index 99df5bf1..1577c2ac 100644 --- a/src/test/java/HttpEventCollector_Test.java +++ b/src/test/java/HttpEventCollector_Test.java @@ -1,5 +1,5 @@ -/* - @copyright +/** + * @copyright * * Copyright 2013-2015 Splunk, Inc. * From c3ffbd1d7491c5f968e278306bf7a824d90dd64a Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 01:32:27 -0400 Subject: [PATCH 05/33] Replace javadoc comments with block comments --- .../java/com/splunk/logging/HttpEventCollectorErrorHandler.java | 2 +- .../java/com/splunk/logging/HttpEventCollectorEventInfo.java | 2 +- .../com/splunk/logging/HttpEventCollectorLoggingHandler.java | 2 +- .../java/com/splunk/logging/HttpEventCollectorMiddleware.java | 2 +- .../com/splunk/logging/HttpEventCollectorResendMiddleware.java | 2 +- src/main/java/com/splunk/logging/HttpEventCollectorSender.java | 2 +- src/test/java/HttpEventCollectorUnitTest.java | 2 +- src/test/java/HttpEventCollectorUnitTestMiddleware.java | 2 +- src/test/java/HttpEventCollector_Test.java | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorErrorHandler.java b/src/main/java/com/splunk/logging/HttpEventCollectorErrorHandler.java index b8e1074c..e8777989 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorErrorHandler.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorErrorHandler.java @@ -1,6 +1,6 @@ package com.splunk.logging; -/** +/* * @copyright * * Copyright 2013-2015 Splunk, Inc. diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorEventInfo.java b/src/main/java/com/splunk/logging/HttpEventCollectorEventInfo.java index 7fd9f977..0ab24a0f 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorEventInfo.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorEventInfo.java @@ -1,6 +1,6 @@ package com.splunk.logging; -/** +/* * @copyright * * Copyright 2013-2015 Splunk, Inc. diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorLoggingHandler.java b/src/main/java/com/splunk/logging/HttpEventCollectorLoggingHandler.java index 912d4bd2..71af3869 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorLoggingHandler.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorLoggingHandler.java @@ -1,6 +1,6 @@ package com.splunk.logging; -/** +/* * @copyright * * Copyright 2013-2015 Splunk, Inc. diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorMiddleware.java b/src/main/java/com/splunk/logging/HttpEventCollectorMiddleware.java index e4123b7c..e2ec6fd6 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorMiddleware.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorMiddleware.java @@ -1,6 +1,6 @@ package com.splunk.logging; -/** +/* * @copyright * * Copyright 2013-2015 Splunk, Inc. diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorResendMiddleware.java b/src/main/java/com/splunk/logging/HttpEventCollectorResendMiddleware.java index b4e7b201..0ec855ee 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorResendMiddleware.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorResendMiddleware.java @@ -1,6 +1,6 @@ package com.splunk.logging; -/** +/* * @copyright * * Copyright 2013-2015 Splunk, Inc. diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorSender.java b/src/main/java/com/splunk/logging/HttpEventCollectorSender.java index 032f681b..59d2cc8b 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorSender.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorSender.java @@ -1,6 +1,6 @@ package com.splunk.logging; -/** +/* * @copyright * * Copyright 2013-2015 Splunk, Inc. diff --git a/src/test/java/HttpEventCollectorUnitTest.java b/src/test/java/HttpEventCollectorUnitTest.java index c1ccfbe8..1507d7d8 100644 --- a/src/test/java/HttpEventCollectorUnitTest.java +++ b/src/test/java/HttpEventCollectorUnitTest.java @@ -1,4 +1,4 @@ -/** +/* * @copyright * * Copyright 2013-2015 Splunk, Inc. diff --git a/src/test/java/HttpEventCollectorUnitTestMiddleware.java b/src/test/java/HttpEventCollectorUnitTestMiddleware.java index 0d272cd0..57410f8c 100644 --- a/src/test/java/HttpEventCollectorUnitTestMiddleware.java +++ b/src/test/java/HttpEventCollectorUnitTestMiddleware.java @@ -3,7 +3,7 @@ import java.util.List; -/** +/* * @copyright * * Copyright 2013-2015 Splunk, Inc. diff --git a/src/test/java/HttpEventCollector_Test.java b/src/test/java/HttpEventCollector_Test.java index 1577c2ac..5b056434 100644 --- a/src/test/java/HttpEventCollector_Test.java +++ b/src/test/java/HttpEventCollector_Test.java @@ -1,4 +1,4 @@ -/** +/* * @copyright * * Copyright 2013-2015 Splunk, Inc. From 0b612c1dcb53b6c5ca34610a779700a3d1082ec1 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 01:38:28 -0400 Subject: [PATCH 06/33] Comment is not javadoc, remove javadoc notation --- src/main/java/com/splunk/logging/SplunkCimLogEvent.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/splunk/logging/SplunkCimLogEvent.java b/src/main/java/com/splunk/logging/SplunkCimLogEvent.java index cf7ea0ae..9738e80f 100644 --- a/src/main/java/com/splunk/logging/SplunkCimLogEvent.java +++ b/src/main/java/com/splunk/logging/SplunkCimLogEvent.java @@ -157,7 +157,7 @@ public String toString() { private static final String THROWABLE_MESSAGE = "throwable_message"; private static final String THROWABLE_STACKTRACE_ELEMENTS = "stacktrace_elements"; - /** + /* * Splunk Common Information Model(CIM) Fields */ From d018701a6742f76140970b4b554fc16f958187cc Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 01:42:31 -0400 Subject: [PATCH 07/33] Remove unused imports --- .../splunk/logging/serialization/EventInfoTypeAdapter.java | 1 - .../com/splunk/logging/serialization/HecJsonSerializer.java | 1 - src/test/java/HttpEventCollectorUnitTest.java | 5 ----- src/test/java/HttpEventCollector_Test.java | 1 - src/test/java/JULFunctionalTest.java | 6 ------ src/test/java/SplunkCimLogEventUnitTest.java | 3 --- src/test/java/TestFormatter.java | 1 - 7 files changed, 18 deletions(-) diff --git a/src/main/java/com/splunk/logging/serialization/EventInfoTypeAdapter.java b/src/main/java/com/splunk/logging/serialization/EventInfoTypeAdapter.java index 6aedb536..4fef1149 100644 --- a/src/main/java/com/splunk/logging/serialization/EventInfoTypeAdapter.java +++ b/src/main/java/com/splunk/logging/serialization/EventInfoTypeAdapter.java @@ -6,7 +6,6 @@ package com.splunk.logging.serialization; import com.google.gson.*; -import com.splunk.logging.EventBodySerializer; import com.splunk.logging.HttpEventCollectorEventInfo; import java.lang.reflect.Type; diff --git a/src/main/java/com/splunk/logging/serialization/HecJsonSerializer.java b/src/main/java/com/splunk/logging/serialization/HecJsonSerializer.java index 64ba99d8..ec4bf173 100644 --- a/src/main/java/com/splunk/logging/serialization/HecJsonSerializer.java +++ b/src/main/java/com/splunk/logging/serialization/HecJsonSerializer.java @@ -13,7 +13,6 @@ import com.splunk.logging.hec.MetadataTags; import java.util.*; -import java.util.stream.Collectors; public class HecJsonSerializer { private static final Set KEYWORDS = MetadataTags.HEC_TAGS; diff --git a/src/test/java/HttpEventCollectorUnitTest.java b/src/test/java/HttpEventCollectorUnitTest.java index 1507d7d8..5cf38402 100644 --- a/src/test/java/HttpEventCollectorUnitTest.java +++ b/src/test/java/HttpEventCollectorUnitTest.java @@ -17,21 +17,16 @@ */ import java.io.IOException; -import java.io.OutputStream; -import java.net.InetSocketAddress; import com.splunk.logging.HttpEventCollectorErrorHandler; import com.splunk.logging.HttpEventCollectorEventInfo; import org.junit.Assert; import org.junit.Test; -import sun.rmi.runtime.Log; import java.io.ByteArrayInputStream; -import java.util.Date; import java.util.HashMap; import java.util.List; import java.util.logging.LogManager; -import java.util.logging.Logger; public class HttpEventCollectorUnitTest { @Test diff --git a/src/test/java/HttpEventCollector_Test.java b/src/test/java/HttpEventCollector_Test.java index 5b056434..9a90d4d2 100644 --- a/src/test/java/HttpEventCollector_Test.java +++ b/src/test/java/HttpEventCollector_Test.java @@ -30,7 +30,6 @@ import java.lang.reflect.*; import com.splunk.*; -import org.slf4j.*; public class HttpEventCollector_Test { public static void addPath(String s) throws Exception { diff --git a/src/test/java/JULFunctionalTest.java b/src/test/java/JULFunctionalTest.java index 54de6b02..17c31131 100644 --- a/src/test/java/JULFunctionalTest.java +++ b/src/test/java/JULFunctionalTest.java @@ -16,12 +16,6 @@ import org.junit.Assert; import org.junit.Test; -import java.io.BufferedReader; -import java.io.IOException; -import java.io.InputStreamReader; -import java.io.Reader; -import java.net.ServerSocket; -import java.net.Socket; import java.util.logging.Logger; public class JULFunctionalTest { diff --git a/src/test/java/SplunkCimLogEventUnitTest.java b/src/test/java/SplunkCimLogEventUnitTest.java index 35407ec8..9ff52cb8 100644 --- a/src/test/java/SplunkCimLogEventUnitTest.java +++ b/src/test/java/SplunkCimLogEventUnitTest.java @@ -18,9 +18,6 @@ import org.junit.Assert; import org.junit.Test; -import java.util.regex.Matcher; -import java.util.regex.Pattern; - /** * Check that SplunkCimLogEvent produces what we expect it to. */ diff --git a/src/test/java/TestFormatter.java b/src/test/java/TestFormatter.java index 945346ac..fa6405b1 100644 --- a/src/test/java/TestFormatter.java +++ b/src/test/java/TestFormatter.java @@ -13,7 +13,6 @@ * License for the specific language governing permissions and limitations * under the License. */ -import java.net.Inet4Address; import java.util.logging.Formatter; import java.util.logging.LogRecord; From 676eac8039974b2a2477223f0473797071fa4029 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 02:00:50 -0400 Subject: [PATCH 08/33] Remove unnecessary toString calls in String.format and System.out/error.println calls --- .../HttpEventCollector_JavaLoggingTest.java | 38 +++++++++---------- .../java/HttpEventCollector_Log4j2Test.java | 34 ++++++++--------- .../java/HttpEventCollector_LogbackTest.java | 34 ++++++++--------- src/test/java/TestUtil.java | 2 +- 4 files changed, 54 insertions(+), 54 deletions(-) diff --git a/src/test/java/HttpEventCollector_JavaLoggingTest.java b/src/test/java/HttpEventCollector_JavaLoggingTest.java index 79762002..b450799f 100644 --- a/src/test/java/HttpEventCollector_JavaLoggingTest.java +++ b/src/test/java/HttpEventCollector_JavaLoggingTest.java @@ -49,7 +49,7 @@ public void canSendEventUsingJavaLogging() throws Exception { TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); Date date = new Date(); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging canSendEventUsingJavaLogging}", date.toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging canSendEventUsingJavaLogging}", date); Logger logger = Logger.getLogger(loggerName); logger.info(jsonMsg); @@ -77,7 +77,7 @@ public void canSendEventUsingJavaLoggingWithOptions() throws Exception { TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); Date date = new Date(); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging canSendEventUsingJavaLoggingWithOptions}", date.toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging canSendEventUsingJavaLoggingWithOptions}", date); Logger logger = Logger.getLogger(loggerName); logger.info(jsonMsg); @@ -104,7 +104,7 @@ public void sendBatchedEventsUsingJavaLogging() throws Exception { TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); Date date = new Date(); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging sendBatchedEventsUsingJavaLogging}", date.toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging sendBatchedEventsUsingJavaLogging}", date); Logger logger = Logger.getLogger(loggerName); logger.info(jsonMsg); @@ -127,7 +127,7 @@ public void sendBatchedEventsByCount() throws Exception { userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_logger_name", loggerName); TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging sendBatchedEventsByCount}", new Date().toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging sendBatchedEventsByCount}", new Date()); Logger logger = Logger.getLogger(loggerName); logger.info(jsonMsg); @@ -146,22 +146,22 @@ public void sendBatchedEventsByCount() throws Exception { List msgs = new ArrayList<>(); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging1}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging1}", new Date()); logger.info(jsonMsg); msgs.add(jsonMsg); System.out.println("event 1"); TestUtil.verifyNoEventSentToSplunk(msgs); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging2}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging2}", new Date()); logger.info(jsonMsg); msgs.add(jsonMsg); System.out.println("event 2"); TestUtil.verifyNoEventSentToSplunk(msgs); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging3}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging3}", new Date()); logger.info(jsonMsg); msgs.add(jsonMsg); System.out.println("event 3"); TestUtil.verifyNoEventSentToSplunk(msgs); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging4}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging4}", new Date()); logger.info(jsonMsg); msgs.add(jsonMsg); System.out.println("event 4"); @@ -170,7 +170,7 @@ public void sendBatchedEventsByCount() throws Exception { Thread.sleep(6000); TestUtil.verifyNoEventSentToSplunk(msgs); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging5}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging5}", new Date()); logger.info(jsonMsg); msgs.add(jsonMsg); @@ -203,11 +203,11 @@ public void sendBatchedEventsByBatchsize() throws Exception { List msgs = new ArrayList<>(); int size = 0; - String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for java logging size 1}", new Date().toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for java logging size 1}", new Date()); size += jsonMsg.length(); logger.info(jsonMsg); msgs.add(jsonMsg); - jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for java logging size 2}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for java logging size 2}", new Date()); size += jsonMsg.length(); logger.info(jsonMsg); msgs.add(jsonMsg); @@ -215,7 +215,7 @@ public void sendBatchedEventsByBatchsize() throws Exception { Thread.sleep(6000); TestUtil.verifyNoEventSentToSplunk(msgs); - jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for java logging size 3, adding more msg to exceed the maxsize}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for java logging size 3, adding more msg to exceed the maxsize}", new Date()); while (size + jsonMsg.length() < 550) { jsonMsg = String.format("%saaaaa", jsonMsg); } @@ -255,14 +255,14 @@ public void errorHandlingInvalidToken() throws Exception { //disable the token so that it becomes invalid TestUtil.disableHttpEventCollector(httpEventCollectorName); Thread.sleep(5000); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event disabled token }", new Date().toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event disabled token }", new Date()); logger.info(jsonMsg); Thread.sleep(2000); //delete the token so that it becomes invalid TestUtil.deleteHttpEventCollectorToken(httpEventCollectorName); Thread.sleep(5000); - jsonMsg = String.format("{EventDate:%s, EventMsg:'test event deleted token}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'test event deleted token}", new Date()); logger.info(jsonMsg); //wait for async process to return the error @@ -320,7 +320,7 @@ public void errorHandlingDisabledHttpEventCollectorEndpoint() throws Exception { //disable httpEventCollector endpoint TestUtil.disableHttpEventCollector(); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event httpEventCollector disabled}", new Date().toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event httpEventCollector disabled}", new Date()); logger.info(jsonMsg); //wait for async process to return the error @@ -364,7 +364,7 @@ private String queueEvents() throws Exception { userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_logger_name", loggerName); TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging}", new Date().toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging}", new Date()); Logger logger = Logger.getLogger(loggerName); logger.info(jsonMsg); @@ -383,7 +383,7 @@ private String queueEvents() throws Exception { List msgs = new ArrayList<>(); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging1}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging1}", new Date()); logger.info(jsonMsg); msgs.add(jsonMsg); TestUtil.verifyNoEventSentToSplunk(msgs); @@ -463,7 +463,7 @@ public void canSendEventUsingJavaLoggingWithUserEventBodySerializer() throws Exc TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); Date date = new Date(); - String jsonMsg = String.format("EventDate:%s, EventMsg:test event for java logging With User EventBodySerializer", date.toString()); + String jsonMsg = String.format("EventDate:%s, EventMsg:test event for java logging With User EventBodySerializer", date); Logger logger = Logger.getLogger(loggerName); logger.info(jsonMsg); @@ -491,7 +491,7 @@ public void canSendEventUsingJavaLoggingWithUserEventHeaderSerializer() throws E TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); Date date = new Date(); - String jsonMsg = String.format("EventDate:%s, EventMsg:test event for java logging With User EventHeaderSerializer", date.toString()); + String jsonMsg = String.format("EventDate:%s, EventMsg:test event for java logging With User EventHeaderSerializer", date); Logger logger = Logger.getLogger(loggerName); logger.info(jsonMsg); diff --git a/src/test/java/HttpEventCollector_Log4j2Test.java b/src/test/java/HttpEventCollector_Log4j2Test.java index 8bd34ddd..0ef9f2dc 100644 --- a/src/test/java/HttpEventCollector_Log4j2Test.java +++ b/src/test/java/HttpEventCollector_Log4j2Test.java @@ -49,13 +49,13 @@ public void canSendEventUsingLog4j2() throws Exception, IOException, Interrupted List msgs = new ArrayList<>(); Date date = new Date(); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for log4j2}", date.toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for log4j2}", date); Logger logger = context.getLogger(loggerName); logger.info(jsonMsg); msgs.add(jsonMsg); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test error for log4j2}", date.toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test error for log4j2}", date); logger.error(jsonMsg); msgs.add(jsonMsg); @@ -87,13 +87,13 @@ public void canSendEventUsingLog4j2WithOptions() throws Exception, IOException, List msgs = new ArrayList<>(); Date date = new Date(); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for log4j2}", date.toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for log4j2}", date); Logger logger = context.getLogger(loggerName); logger.info(jsonMsg); msgs.add(jsonMsg); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test error for log4j2}", date.toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test error for log4j2}", date); logger.error(jsonMsg); msgs.add(jsonMsg); @@ -116,7 +116,7 @@ public void sendBatchedEventsByCount() throws Exception { userInputs.put("user_logger_name", loggerName); userInputs.put("user_httpEventCollector_token", token); LoggerContext context = TestUtil.resetLog4j2Configuration("log4j2_template.xml", "log4j2.xml", userInputs); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging}", new Date().toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging}", new Date()); Logger logger = context.getLogger(loggerName); logger.info(jsonMsg); @@ -136,22 +136,22 @@ public void sendBatchedEventsByCount() throws Exception { List msgs = new ArrayList<>(); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging1}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging1}", new Date()); logger.info(jsonMsg); msgs.add(jsonMsg); System.out.println("event 1"); TestUtil.verifyNoEventSentToSplunk(msgs); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging2}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging2}", new Date()); logger.info(jsonMsg); msgs.add(jsonMsg); System.out.println("event 2"); TestUtil.verifyNoEventSentToSplunk(msgs); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging3}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging3}", new Date()); logger.info(jsonMsg); msgs.add(jsonMsg); System.out.println("event 3"); TestUtil.verifyNoEventSentToSplunk(msgs); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging4}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging4}", new Date()); logger.info(jsonMsg); msgs.add(jsonMsg); System.out.println("event 4"); @@ -160,7 +160,7 @@ public void sendBatchedEventsByCount() throws Exception { Thread.sleep(6000); TestUtil.verifyNoEventSentToSplunk(msgs); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging5}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging5}", new Date()); logger.info(jsonMsg); msgs.add(jsonMsg); @@ -190,11 +190,11 @@ public void sendBatchedEventsByBatchsize() throws Exception { List msgs = new ArrayList<>(); int size = 0; - String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for log4j size 1}", new Date().toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for log4j size 1}", new Date()); logger.info(jsonMsg); size += jsonMsg.length(); msgs.add(jsonMsg); - jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for log4j size 2}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for log4j size 2}", new Date()); size += jsonMsg.length(); logger.info(jsonMsg); msgs.add(jsonMsg); @@ -202,7 +202,7 @@ public void sendBatchedEventsByBatchsize() throws Exception { Thread.sleep(6000); TestUtil.verifyNoEventSentToSplunk(msgs); - jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for log4j size 3, adding more msg to exceed the maxsize}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for log4j size 3, adding more msg to exceed the maxsize}", new Date()); while (size + jsonMsg.length() < 550) { jsonMsg = String.format("%saaaaa", jsonMsg); } @@ -242,14 +242,14 @@ public void errorHandlingInvalidToken() throws Exception { //disable the token so that it becomes invalid TestUtil.disableHttpEventCollector(httpEventCollectorName); Thread.sleep(5000); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event disabled token }", new Date().toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event disabled token }", new Date()); logger.info(jsonMsg); Thread.sleep(5000); //delete the token so that it becomes invalid TestUtil.deleteHttpEventCollectorToken(httpEventCollectorName); Thread.sleep(5000); - jsonMsg = String.format("{EventDate:%s, EventMsg:'test event deleted token}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'test event deleted token}", new Date()); logger.info(jsonMsg); //wait for async process to return the error @@ -310,7 +310,7 @@ public void errorHandlingDisabledHttpEventCollectorEndpoint() throws Exception { //disable httpEventCollector endpoint TestUtil.disableHttpEventCollector(); Thread.sleep(1000); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event httpEventCollector disabled}", new Date().toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event httpEventCollector disabled}", new Date()); logger.info(jsonMsg); //wait for async process to return the error @@ -325,7 +325,7 @@ public void errorHandlingDisabledHttpEventCollectorEndpoint() throws Exception { Assert.fail("didn't catch errors"); Assert.assertTrue(errors.size() >= 1); - System.out.println(logEx.toString()); + System.out.println(logEx); if (!StringUtils.containsAny(logEx.toString(), "Failed to connect to", "Remote host terminated the handshake", "Connection reset")) Assert.fail(String.format("Unexpected error message '%s'", logEx.toString())); } diff --git a/src/test/java/HttpEventCollector_LogbackTest.java b/src/test/java/HttpEventCollector_LogbackTest.java index 6d87f10d..92376ac6 100644 --- a/src/test/java/HttpEventCollector_LogbackTest.java +++ b/src/test/java/HttpEventCollector_LogbackTest.java @@ -51,16 +51,16 @@ public void canSendEventUsingLogback() throws Exception { List msgs = new ArrayList<>(); Date date = new Date(); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for Logback Test}", date.toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for Logback Test}", date); Logger logger = LoggerFactory.getLogger(loggerName); logger.info(jsonMsg); msgs.add(jsonMsg); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test error for Logback Test}", date.toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test error for Logback Test}", date); logger.error(jsonMsg); msgs.add(jsonMsg); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test debug for Logback Test}", date.toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test debug for Logback Test}", date); logger.debug(jsonMsg); msgs.add(jsonMsg); @@ -87,16 +87,16 @@ public void canSendEventUsingLogbackWithOptions() throws Exception { List msgs = new ArrayList<>(); Date date = new Date(); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for Logback Test}", date.toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for Logback Test}", date); Logger logger = LoggerFactory.getLogger(loggerName); logger.info(jsonMsg); msgs.add(jsonMsg); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test error for Logback Test}", date.toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test error for Logback Test}", date); logger.error(jsonMsg); msgs.add(jsonMsg); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test debug for Logback Test}", date.toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test debug for Logback Test}", date); logger.debug(jsonMsg); msgs.add(jsonMsg); @@ -126,22 +126,22 @@ public void canSendBatchEventByCount() throws Exception { Logger logger = LoggerFactory.getLogger(loggerName); List msgs = new ArrayList<>(); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for logback 1}", new Date().toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for logback 1}", new Date()); logger.info(jsonMsg); msgs.add(jsonMsg); System.out.println("event 1"); TestUtil.verifyNoEventSentToSplunk(msgs); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for logback 2}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for logback 2}", new Date()); logger.info(jsonMsg); msgs.add(jsonMsg); System.out.println("event 2"); TestUtil.verifyNoEventSentToSplunk(msgs); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for logback 3}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for logback 3}", new Date()); logger.info(jsonMsg); msgs.add(jsonMsg); System.out.println("event 3"); TestUtil.verifyNoEventSentToSplunk(msgs); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for logback 4}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for logback 4}", new Date()); logger.info(jsonMsg); msgs.add(jsonMsg); System.out.println("event 4"); @@ -150,7 +150,7 @@ public void canSendBatchEventByCount() throws Exception { Thread.sleep(6000); TestUtil.verifyNoEventSentToSplunk(msgs); - jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for logback 5}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for logback 5}", new Date()); logger.info(jsonMsg); msgs.add(jsonMsg); @@ -182,11 +182,11 @@ public void canSendBatchEventBySize() throws Exception { List msgs = new ArrayList<>(); int size = 0; - String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for java logging size 1}", new Date().toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for java logging size 1}", new Date()); size += jsonMsg.length(); logger.info(jsonMsg); msgs.add(jsonMsg); - jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for java logging size 2}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for java logging size 2}", new Date()); size += jsonMsg.length(); logger.info(jsonMsg); msgs.add(jsonMsg); @@ -194,7 +194,7 @@ public void canSendBatchEventBySize() throws Exception { Thread.sleep(6000); TestUtil.verifyNoEventSentToSplunk(msgs); - jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for java logging size 3, adding more msg to exceed the maxsize}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'test event for java logging size 3, adding more msg to exceed the maxsize}", new Date()); while (size + jsonMsg.length() < 550) { jsonMsg = String.format("%saaaaa", jsonMsg); } @@ -235,12 +235,12 @@ public void errorHandlingInvalidToken() throws Exception { //disable the token so that it becomes invalid TestUtil.disableHttpEventCollector(httpEventCollectorName); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event disabled token }", new Date().toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event disabled token }", new Date()); logger.info(jsonMsg); //delete the token so that it becomes invalid TestUtil.deleteHttpEventCollectorToken(httpEventCollectorName); - jsonMsg = String.format("{EventDate:%s, EventMsg:'test event deleted token}", new Date().toString()); + jsonMsg = String.format("{EventDate:%s, EventMsg:'test event deleted token}", new Date()); logger.info(jsonMsg); //wait for async process to return the error @@ -300,7 +300,7 @@ public void errorHandlingDisabledHttpEventCollectorEndpoint() throws Exception { //disable httpEventCollector endpoint TestUtil.disableHttpEventCollector(); - String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event httpEventCollector disabled}", new Date().toString()); + String jsonMsg = String.format("{EventDate:%s, EventMsg:'test event httpEventCollector disabled}", new Date()); logger.info(jsonMsg); //wait for async process to return the error diff --git a/src/test/java/TestUtil.java b/src/test/java/TestUtil.java index b88d6e1d..d4033549 100644 --- a/src/test/java/TestUtil.java +++ b/src/test/java/TestUtil.java @@ -470,7 +470,7 @@ private static InputStream searchJsonMessageEvent(final JsonObject jsonObject) { searchQuery.append(String.format(" | search \"message.%s\"=%s", jsonEntry.getKey(), jsonEntry.getValue())); } } - System.err.println(searchQuery.toString()); + System.err.println(searchQuery); return service.oneshotSearch(searchQuery.toString()); } From 43f16ef20aa259a3346a23b893ed72122ef083b7 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 02:27:58 -0400 Subject: [PATCH 09/33] Remove unneccessary semicolon --- src/main/java/com/splunk/logging/HttpEventCollectorSender.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorSender.java b/src/main/java/com/splunk/logging/HttpEventCollectorSender.java index 59d2cc8b..e1347f0a 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorSender.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorSender.java @@ -63,7 +63,7 @@ public enum SendMode { Sequential, Parallel - }; + } /** * Recommended default values for events batching. From 75c901624f6a57d8a14640e0566ca6df71e5bef6 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 02:41:37 -0400 Subject: [PATCH 10/33] Remove un-necessary thrown clause (overridden method does not throw declared exception) --- .../java/com/splunk/logging/HttpEventCollectorSender.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorSender.java b/src/main/java/com/splunk/logging/HttpEventCollectorSender.java index e1347f0a..1cab0e66 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorSender.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorSender.java @@ -27,7 +27,6 @@ import javax.net.ssl.*; import java.io.IOException; import java.io.Serializable; -import java.security.cert.CertificateException; import java.util.*; import java.util.concurrent.TimeUnit; import java.util.stream.Collectors; @@ -316,11 +315,11 @@ private void startHttpClient() { final TrustManager[] trustAllCerts = new TrustManager[]{ new X509TrustManager() { @Override - public void checkClientTrusted(java.security.cert.X509Certificate[] chain, String authType) throws CertificateException { + public void checkClientTrusted(java.security.cert.X509Certificate[] chain, String authType) { } @Override - public void checkServerTrusted(java.security.cert.X509Certificate[] chain, String authType) throws CertificateException { + public void checkServerTrusted(java.security.cert.X509Certificate[] chain, String authType) { } @Override From 017af650759ad54912ee03e7ae10a661d3d38821 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 02:43:13 -0400 Subject: [PATCH 11/33] Remove redundant initializers --- .../com/splunk/logging/HttpEventCollectorLog4jAppender.java | 2 +- .../com/splunk/logging/HttpEventCollectorLoggingHandler.java | 2 +- .../com/splunk/logging/HttpEventCollectorResendMiddleware.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorLog4jAppender.java b/src/main/java/com/splunk/logging/HttpEventCollectorLog4jAppender.java index 8afb25d4..e87b03d6 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorLog4jAppender.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorLog4jAppender.java @@ -40,7 +40,7 @@ @SuppressWarnings("serial") public final class HttpEventCollectorLog4jAppender extends AbstractAppender { - private HttpEventCollectorSender sender = null; + private HttpEventCollectorSender sender; private final boolean includeLoggerName; private final boolean includeThreadName; private final boolean includeMDC; diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorLoggingHandler.java b/src/main/java/com/splunk/logging/HttpEventCollectorLoggingHandler.java index 71af3869..9ce0861a 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorLoggingHandler.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorLoggingHandler.java @@ -93,7 +93,7 @@ * properties file. */ public final class HttpEventCollectorLoggingHandler extends Handler { - private HttpEventCollectorSender sender = null; + private HttpEventCollectorSender sender; private final String IncludeLoggerNameConfTag = "include_logger_name"; private final boolean includeLoggerName; private final String IncludeThreadNameConfTag = "include_thread_name"; diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorResendMiddleware.java b/src/main/java/com/splunk/logging/HttpEventCollectorResendMiddleware.java index 0ec855ee..b1586790 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorResendMiddleware.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorResendMiddleware.java @@ -30,7 +30,7 @@ */ public class HttpEventCollectorResendMiddleware extends HttpEventCollectorMiddleware.HttpSenderMiddleware { - private long retriesOnError = 0; + private long retriesOnError; /** * Create a resend middleware component. From e1f368d3398e2d1e7643b10e13fa61b261d83fe6 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 02:45:47 -0400 Subject: [PATCH 12/33] Remove redundant annotation parameters --- .../splunk/logging/HttpEventCollectorLog4jAppender.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorLog4jAppender.java b/src/main/java/com/splunk/logging/HttpEventCollectorLog4jAppender.java index e87b03d6..8edc1383 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorLog4jAppender.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorLog4jAppender.java @@ -154,10 +154,10 @@ public static HttpEventCollectorLog4jAppender createAppender( @PluginAttribute(value = "includeException", defaultBoolean = true) final boolean includeException, @PluginAttribute(value = "includeMarker", defaultBoolean = true) final boolean includeMarker, @PluginAttribute(value = "connect_timeout", defaultLong = HttpEventCollectorSender.TimeoutSettings.DEFAULT_CONNECT_TIMEOUT) final long connectTimeout, - @PluginAttribute(value = "call_timeout", defaultLong = HttpEventCollectorSender.TimeoutSettings.DEFAULT_CALL_TIMEOUT) final long callTimeout, - @PluginAttribute(value = "read_timeout", defaultLong = HttpEventCollectorSender.TimeoutSettings.DEFAULT_READ_TIMEOUT) final long readTimeout, - @PluginAttribute(value = "write_timeout", defaultLong = HttpEventCollectorSender.TimeoutSettings.DEFAULT_WRITE_TIMEOUT) final long writeTimeout, - @PluginAttribute(value = "termination_timeout", defaultLong = HttpEventCollectorSender.TimeoutSettings.DEFAULT_TERMINATION_TIMEOUT) final long terminationTimeout, + @PluginAttribute(value = "call_timeout") final long callTimeout, + @PluginAttribute(value = "read_timeout") final long readTimeout, + @PluginAttribute(value = "write_timeout") final long writeTimeout, + @PluginAttribute(value = "termination_timeout") final long terminationTimeout, @PluginElement("Layout") Layout layout, @PluginElement("Filter") final Filter filter ) From f5e29b6557f09176cd1bcccf0a20a9244ce06c87 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 02:52:56 -0400 Subject: [PATCH 13/33] Remove redundant interface method modifiers --- .../com/splunk/logging/HttpEventCollectorMiddleware.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/com/splunk/logging/HttpEventCollectorMiddleware.java b/src/main/java/com/splunk/logging/HttpEventCollectorMiddleware.java index e2ec6fd6..671501a3 100644 --- a/src/main/java/com/splunk/logging/HttpEventCollectorMiddleware.java +++ b/src/main/java/com/splunk/logging/HttpEventCollectorMiddleware.java @@ -38,16 +38,16 @@ public class HttpEventCollectorMiddleware { * An interface that describes an abstract events sender working asynchronously. */ public interface IHttpSender { - public void postEvents(final List events, - IHttpSenderCallback callback); + void postEvents(final List events, + IHttpSenderCallback callback); } /** * Callback methods invoked by events sender. */ public interface IHttpSenderCallback { - public void completed(int statusCode, final String reply); - public void failed(final Exception ex); + void completed(int statusCode, final String reply); + void failed(final Exception ex); } /** From da7517626a75714f20f31db09ac77f2e5e179bda Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 02:59:03 -0400 Subject: [PATCH 14/33] Collapse identical exception handlers into single catch statement --- src/main/java/com/splunk/logging/TcpAppender.java | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/main/java/com/splunk/logging/TcpAppender.java b/src/main/java/com/splunk/logging/TcpAppender.java index f0fc704c..d9d3fbe6 100644 --- a/src/main/java/com/splunk/logging/TcpAppender.java +++ b/src/main/java/com/splunk/logging/TcpAppender.java @@ -148,13 +148,7 @@ private SocketConnector initSocketConnector() { connector = getDefaultSocketConnectorConstr().newInstance(address, port, 0, reconnectionDelay); } - catch (InvocationTargetException e) { - throwRuntimeException(e); - } - catch (InstantiationException e) { - throwRuntimeException(e); - } - catch (IllegalAccessException e) { + catch (InvocationTargetException | InstantiationException | IllegalAccessException e) { throwRuntimeException(e); } From 10c38baf09cb80eefcfe51c2663c7b66450964ac Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 03:19:29 -0400 Subject: [PATCH 15/33] When you synchronize on a field, it should be final --- src/test/java/HttpEventCollector_JavaLoggingTest.java | 4 ++-- src/test/java/HttpEventCollector_Log4j2Test.java | 4 ++-- src/test/java/HttpEventCollector_LogbackTest.java | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/test/java/HttpEventCollector_JavaLoggingTest.java b/src/test/java/HttpEventCollector_JavaLoggingTest.java index b450799f..6c9ba56e 100644 --- a/src/test/java/HttpEventCollector_JavaLoggingTest.java +++ b/src/test/java/HttpEventCollector_JavaLoggingTest.java @@ -30,8 +30,8 @@ public final class HttpEventCollector_JavaLoggingTest { private String httpEventCollectorName = "JavaLoggingTest"; - List> errors = new ArrayList<>(); - List logEx = new ArrayList<>(); + private final List> errors = new ArrayList<>(); + private final List logEx = new ArrayList<>(); /** * sending a message via httplogging using java.logging to splunk diff --git a/src/test/java/HttpEventCollector_Log4j2Test.java b/src/test/java/HttpEventCollector_Log4j2Test.java index 0ef9f2dc..1d4b16fa 100644 --- a/src/test/java/HttpEventCollector_Log4j2Test.java +++ b/src/test/java/HttpEventCollector_Log4j2Test.java @@ -30,8 +30,8 @@ public final class HttpEventCollector_Log4j2Test { private String httpEventCollectorName = "Log4j2Test"; - List> errors = new ArrayList<>(); - List logEx = new ArrayList<>(); + private final List> errors = new ArrayList<>(); + private final List logEx = new ArrayList<>(); /** * sending a message via httplogging using log4j2 to splunk diff --git a/src/test/java/HttpEventCollector_LogbackTest.java b/src/test/java/HttpEventCollector_LogbackTest.java index 92376ac6..96ca3c33 100644 --- a/src/test/java/HttpEventCollector_LogbackTest.java +++ b/src/test/java/HttpEventCollector_LogbackTest.java @@ -30,8 +30,8 @@ public final class HttpEventCollector_LogbackTest { private String httpEventCollectorName = "LogbackTest"; - List> errors = new ArrayList<>(); - List logEx = new ArrayList<>(); + private final List> errors = new ArrayList<>(); + private final List logEx = new ArrayList<>(); /** * sending a message via httplogging using logback to splunk From 201591a1743c2270dc754007e06c9eb70657acb7 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 03:22:55 -0400 Subject: [PATCH 16/33] Remove unnecessary toString calls in String.format and System.out/error.println calls --- src/test/java/HttpEventCollector_JavaLoggingTest.java | 6 +++--- src/test/java/HttpEventCollector_Log4j2Test.java | 4 ++-- src/test/java/HttpEventCollector_LogbackTest.java | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/test/java/HttpEventCollector_JavaLoggingTest.java b/src/test/java/HttpEventCollector_JavaLoggingTest.java index 6c9ba56e..e5c007e1 100644 --- a/src/test/java/HttpEventCollector_JavaLoggingTest.java +++ b/src/test/java/HttpEventCollector_JavaLoggingTest.java @@ -278,7 +278,7 @@ public void errorHandlingInvalidToken() throws Exception { System.out.println("======print logEx"); - System.out.println(logEx.toString()); + System.out.println(logEx); System.out.println("======finish print logEx"); Assert.assertEquals("Invalid token", logEx.get(1).getErrorText()); Assert.assertEquals(4, logEx.get(1).getErrorCode()); @@ -338,9 +338,9 @@ public void errorHandlingDisabledHttpEventCollectorEndpoint() throws Exception { Assert.fail("didn't catch errors"); Assert.assertEquals(1, errors.size()); - System.out.println(logEx.toString()); + System.out.println(logEx); if (!StringUtils.containsAny(logEx.toString(), "Failed to connect to", "Remote host terminated the handshake", "Connection reset")) - Assert.fail(String.format("Unexpected error message '%s'", logEx.toString())); + Assert.fail(String.format("Unexpected error message '%s'", logEx)); } diff --git a/src/test/java/HttpEventCollector_Log4j2Test.java b/src/test/java/HttpEventCollector_Log4j2Test.java index 1d4b16fa..7cad5bf6 100644 --- a/src/test/java/HttpEventCollector_Log4j2Test.java +++ b/src/test/java/HttpEventCollector_Log4j2Test.java @@ -270,7 +270,7 @@ public void errorHandlingInvalidToken() throws Exception { } System.out.println("======print logEx"); - System.out.println(logEx.toString()); + System.out.println(logEx); System.out.println("======finish print logEx"); Assert.assertEquals("Invalid token", logEx.get(1).getErrorText()); Assert.assertEquals(4, logEx.get(1).getErrorCode()); @@ -327,7 +327,7 @@ public void errorHandlingDisabledHttpEventCollectorEndpoint() throws Exception { System.out.println(logEx); if (!StringUtils.containsAny(logEx.toString(), "Failed to connect to", "Remote host terminated the handshake", "Connection reset")) - Assert.fail(String.format("Unexpected error message '%s'", logEx.toString())); + Assert.fail(String.format("Unexpected error message '%s'", logEx)); } /** diff --git a/src/test/java/HttpEventCollector_LogbackTest.java b/src/test/java/HttpEventCollector_LogbackTest.java index 96ca3c33..30860ebd 100644 --- a/src/test/java/HttpEventCollector_LogbackTest.java +++ b/src/test/java/HttpEventCollector_LogbackTest.java @@ -256,7 +256,7 @@ public void errorHandlingInvalidToken() throws Exception { System.out.println("======print logEx"); - System.out.println(logEx.toString()); + System.out.println(logEx); System.out.println("======finish print logEx"); Assert.assertEquals("Invalid token", logEx.get(1).getErrorText()); Assert.assertEquals(4, logEx.get(1).getErrorCode()); @@ -317,9 +317,9 @@ public void errorHandlingDisabledHttpEventCollectorEndpoint() throws Exception { Assert.fail("didn't catch errors"); Assert.assertEquals(1, errors.size()); - System.out.println(logEx.toString()); + System.out.println(logEx); if (!StringUtils.containsAny(logEx.toString(), "Failed to connect to", "Remote host terminated the handshake", "Connection reset")) - Assert.fail(String.format("Unexpected error message '%s'", logEx.toString())); + Assert.fail(String.format("Unexpected error message '%s'", logEx)); } /** From 2afc16c35c9f28eb39b44a3bdfa302d60bec1f08 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 03:28:30 -0400 Subject: [PATCH 17/33] Duplicate key/value is added to map --- src/test/java/HttpEventCollector_Log4j2Test.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/test/java/HttpEventCollector_Log4j2Test.java b/src/test/java/HttpEventCollector_Log4j2Test.java index 7cad5bf6..8f8aa976 100644 --- a/src/test/java/HttpEventCollector_Log4j2Test.java +++ b/src/test/java/HttpEventCollector_Log4j2Test.java @@ -126,7 +126,6 @@ public void sendBatchedEventsByCount() throws Exception { userInputs.put("user_httpEventCollector_token", token); userInputs.put("user_batch_interval","0"); userInputs.put("user_batch_size_count", "5"); - userInputs.put("user_logger_name", loggerName); userInputs.put("user_host", "host.example.com"); userInputs.put("user_source", "splunktest_BatchCount"); userInputs.put("user_sourcetype", "battlecat_BatchCount"); From 1b555a03c346a4465db5443c26ea018d345c1595 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 03:34:53 -0400 Subject: [PATCH 18/33] Collapse exceptions in throws clause --- src/test/java/HttpEventCollector_Log4j2Test.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/test/java/HttpEventCollector_Log4j2Test.java b/src/test/java/HttpEventCollector_Log4j2Test.java index 8f8aa976..bf4c1368 100644 --- a/src/test/java/HttpEventCollector_Log4j2Test.java +++ b/src/test/java/HttpEventCollector_Log4j2Test.java @@ -14,7 +14,6 @@ * under the License. */ -import java.io.*; import java.util.*; import com.google.gson.JsonObject; @@ -37,7 +36,7 @@ public final class HttpEventCollector_Log4j2Test { * sending a message via httplogging using log4j2 to splunk */ @Test - public void canSendEventUsingLog4j2() throws Exception, IOException, InterruptedException { + public void canSendEventUsingLog4j2() throws Exception { TestUtil.enableHttpEventCollector(); String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "splunkLogger4j2"; @@ -70,7 +69,7 @@ public void canSendEventUsingLog4j2() throws Exception, IOException, Interrupted * sending a message via httplogging using log4j2 to splunk and set index, source and sourcetype */ @Test - public void canSendEventUsingLog4j2WithOptions() throws Exception, IOException, InterruptedException { + public void canSendEventUsingLog4j2WithOptions() throws Exception { String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "splunkLogger4j2WithOptions"; From c351e5488e785e0135f73a614f9537db71411802 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 03:43:59 -0400 Subject: [PATCH 19/33] Add generics to un-parameterized Map --- src/test/java/TestUtil.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/java/TestUtil.java b/src/test/java/TestUtil.java index d4033549..da020107 100644 --- a/src/test/java/TestUtil.java +++ b/src/test/java/TestUtil.java @@ -224,7 +224,7 @@ public static void disableHttpEventCollector() throws IOException { connectToSplunk(); //disable logging endpoint - Map args = new HashMap(); + Map args = new HashMap<>(); args.put("disabled", 1); ResponseMessage response = service.post("/servicesNS/admin/search/data/inputs/http/http", args); assert response.getStatus() == 200; @@ -237,7 +237,7 @@ public static void enableHttpEventCollector() throws IOException { connectToSplunk(); //enable logging endpoint - Map args = new HashMap(); + Map args = new HashMap<>(); args.put("disabled", 0); ResponseMessage response = service.post("/servicesNS/admin/search/data/inputs/http/http", args); assert response.getStatus() == 200; @@ -250,7 +250,7 @@ public static void enableHttpEventCollector() throws IOException { public static void disableHttpEventCollector(String httpEventCollectorName) throws IOException { connectToSplunk(); - Map args = new HashMap(); + Map args = new HashMap<>(); args.put("disabled", 1); ResponseMessage response = service.post(httpEventCollectorTokenEndpointPath + "/" + httpEventCollectorName, args); From aa17af3b1f46f68e09a6858a8158d45dd53d4151 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 03:53:11 -0400 Subject: [PATCH 20/33] Use containsKey() over keySet().contains() --- src/test/java/TestUtil.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/TestUtil.java b/src/test/java/TestUtil.java index da020107..4cb863cf 100644 --- a/src/test/java/TestUtil.java +++ b/src/test/java/TestUtil.java @@ -280,7 +280,7 @@ public static String updateConfigFile(String configFileTemplate, String configFi String match = FindUserInputConfiguration(lines.get(i)); if (!match.isEmpty()) { - if (userInputs.keySet().contains(match)) + if (userInputs.containsKey(match)) lines.set(i, lines.get(i).replace("%" + match + "%", userInputs.get(match))); else lines.set(i, ""); From d0572fc00cf41d3c6cac447e0d1cf934add5b7c4 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 04:00:20 -0400 Subject: [PATCH 21/33] Remove un-necessary thrown clause (overridden method does not throw declared exception) --- src/test/java/TestUtil.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/java/TestUtil.java b/src/test/java/TestUtil.java index 4cb863cf..72ba83f9 100644 --- a/src/test/java/TestUtil.java +++ b/src/test/java/TestUtil.java @@ -315,7 +315,7 @@ private static String FindUserInputConfiguration(String line) { /* create log4j2.xml and force log4j2 context manager to reload the configurations, return context and using this context to retrieve logger instead of using LogManager */ - public static org.apache.logging.log4j.core.LoggerContext resetLog4j2Configuration(String configFileTemplate, String configFile, HashMap userInputs) throws IOException, JoranException { + public static org.apache.logging.log4j.core.LoggerContext resetLog4j2Configuration(String configFileTemplate, String configFile, HashMap userInputs) throws IOException { String configFilePath = updateConfigFile(configFileTemplate, configFile, userInputs); org.apache.logging.log4j.core.LoggerContext context = new org.apache.logging.log4j.core.LoggerContext(userInputs.get("user_logger_name")); context.reconfigure(); @@ -340,7 +340,7 @@ public static void resetLogbackConfiguration(String configFileTemplate, String c /* create logging.property and force java logging manager to reload the configurations */ - public static void resetJavaLoggingConfiguration(String configFileTemplate, String configFile, HashMap userInputs) throws IOException, JoranException { + public static void resetJavaLoggingConfiguration(String configFileTemplate, String configFile, HashMap userInputs) throws IOException { String configFilePath = updateConfigFile(configFileTemplate, configFile, userInputs); FileInputStream configFileStream = new FileInputStream(configFilePath); LogManager.getLogManager().readConfiguration(configFileStream); From 355c47da9e7f7f4a8b5067a2c9e645b308dea2cc Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 04:07:45 -0400 Subject: [PATCH 22/33] object equality should not be used to compare strings --- src/test/java/HttpEventCollector_Test.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/java/HttpEventCollector_Test.java b/src/test/java/HttpEventCollector_Test.java index 9a90d4d2..62900de7 100644 --- a/src/test/java/HttpEventCollector_Test.java +++ b/src/test/java/HttpEventCollector_Test.java @@ -159,7 +159,7 @@ private boolean insertDataWithLoggerAndVerify(String token, String loggerType, i userInputs.put("user_batch_size_bytes", "12"); } - if (loggerType == "log4j") { + if (Objects.equals(loggerType, "log4j")) { String loggerName = "splunk.log4jInsertVerify"; userInputs.put("user_logger_name", loggerName); org.apache.logging.log4j.core.LoggerContext context = TestUtil.resetLog4j2Configuration("log4j2_template.xml", "log4j2.xml", userInputs); @@ -168,7 +168,7 @@ private boolean insertDataWithLoggerAndVerify(String token, String loggerType, i LOG4J.info(String.format("log4j message%d", i)); } } - if (loggerType == "logback") { + if (Objects.equals(loggerType, "logback")) { String loggerName = "logBackLogger"; userInputs.put("user_logger_name", loggerName); userInputs.put("user_defined_httpEventCollector_token", token); @@ -178,7 +178,7 @@ private boolean insertDataWithLoggerAndVerify(String token, String loggerType, i LOGBACK.info(String.format("logback message%d", i)); } } - if (loggerType == "javautil") { + if (Objects.equals(loggerType, "javautil")) { String loggerName = batching?"splunkLogger_batching":"splunkLogger_nobatching"; userInputs.put("user_logger_name", loggerName); TestUtil.resetJavaLoggingConfiguration("logging_template.properties", "logging.properties", userInputs); From b417687d616003f9a3c62a8ea5a3dd47ed033cf1 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 04:20:14 -0400 Subject: [PATCH 23/33] Use primitive boolean over Boolean object when applicable --- src/test/java/HttpEventCollector_Test.java | 3 +-- src/test/java/HttpLoggerStressTest.java | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/test/java/HttpEventCollector_Test.java b/src/test/java/HttpEventCollector_Test.java index 62900de7..9e6042c6 100644 --- a/src/test/java/HttpEventCollector_Test.java +++ b/src/test/java/HttpEventCollector_Test.java @@ -209,8 +209,7 @@ private void LogToSplunk(boolean batching) throws Exception { System.out.printf("\tSetting up http event collector with %s ... ", batching ? "batching" : "no batching"); String token = setupHttpEventCollector(batching); System.out.printf("Set\n"); - Boolean testPassed = true; - testPassed &= insertDataWithLoggerAndVerify(token, "log4j", expectedCounter, batching); + boolean testPassed = insertDataWithLoggerAndVerify(token, "log4j", expectedCounter, batching); testPassed &= insertDataWithLoggerAndVerify(token, "logback", expectedCounter, batching); testPassed &= insertDataWithLoggerAndVerify(token, "javautil", expectedCounter, batching); Assert.assertTrue(testPassed); diff --git a/src/test/java/HttpLoggerStressTest.java b/src/test/java/HttpLoggerStressTest.java index d089ab10..53690e8a 100644 --- a/src/test/java/HttpLoggerStressTest.java +++ b/src/test/java/HttpLoggerStressTest.java @@ -149,7 +149,7 @@ public void canSendEventUsingJavaLogging() throws Exception { System.out.printf("\tCompleted wait for iteration %d\r\n", i); } } - Boolean testPassed = true; + boolean testPassed = true; for (int i = 0; i < numberOfThreads; i++) { String arguments = String.format("search Thread%d earliest=%d| stats count", i, startTime); eventCount = getEventsCount(arguments); From 30d8c3fe8651dc39a2722446213d455bbcf1a148 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 04:39:03 -0400 Subject: [PATCH 24/33] Remove redundant casts --- src/test/java/SplunkCimLogEventUnitTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/java/SplunkCimLogEventUnitTest.java b/src/test/java/SplunkCimLogEventUnitTest.java index 9ff52cb8..ed82a2c1 100644 --- a/src/test/java/SplunkCimLogEventUnitTest.java +++ b/src/test/java/SplunkCimLogEventUnitTest.java @@ -49,7 +49,7 @@ public void addFieldWithShortValue() { @Test public void addFieldWithIntValue() { SplunkCimLogEvent event = new SplunkCimLogEvent("name", "event-id"); - event.addField("key", (int)129); + event.addField("key", 129); Assert.assertEquals("\"name=name\" \"event_id=event-id\" \"key=129\"", event.toString()); } @@ -57,7 +57,7 @@ public void addFieldWithIntValue() { @Test public void addFieldWithLongValue() { SplunkCimLogEvent event = new SplunkCimLogEvent("name", "event-id"); - event.addField("key", (long)129L); + event.addField("key", 129L); Assert.assertEquals("\"name=name\" \"event_id=event-id\" \"key=129\"", event.toString()); } @@ -73,7 +73,7 @@ public void addFieldWithFloatValue() { @Test public void addFieldWithDoubleValue() { SplunkCimLogEvent event = new SplunkCimLogEvent("name", "event-id"); - event.addField("key", (double)129.32); + event.addField("key", 129.32); Assert.assertEquals("\"name=name\" \"event_id=event-id\" \"key=129.32\"", event.toString()); } From d79d2671e364d32ed55a2803206cc1bec04594dd Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 04:51:13 -0400 Subject: [PATCH 25/33] No need to mark private method final --- src/test/java/HttpEventCollectorUnitTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/HttpEventCollectorUnitTest.java b/src/test/java/HttpEventCollectorUnitTest.java index 5cf38402..1b894187 100644 --- a/src/test/java/HttpEventCollectorUnitTest.java +++ b/src/test/java/HttpEventCollectorUnitTest.java @@ -338,7 +338,7 @@ private void readConf(final String conf) { } } - private final String repeat(String str, int times) { + private String repeat(String str, int times) { StringBuilder sb = new StringBuilder(); for (int i = 0 ; i < times ; i ++) sb.append(str); From 5bfdd2361374599c614b79e4772c76993a988356 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 04:52:02 -0400 Subject: [PATCH 26/33] Remove unneccessary semicolon --- src/test/java/HttpLoggerStressTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/HttpLoggerStressTest.java b/src/test/java/HttpLoggerStressTest.java index 53690e8a..f18046a1 100644 --- a/src/test/java/HttpLoggerStressTest.java +++ b/src/test/java/HttpLoggerStressTest.java @@ -119,7 +119,7 @@ public void canSendEventUsingJavaLogging() throws Exception { Thread[] tList = new Thread[numberOfThreads]; for (int i = 0; i < numberOfThreads; i++) { dsList[i] = new DataSender(String.format("Thread%s", i), testDurationInSecs); - tList[i] = new Thread(dsList[i]);; + tList[i] = new Thread(dsList[i]); } for (Thread t : tList) t.start(); From 6cc9804280ee670547d29887f73d660abf3a847d Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 05:08:51 -0400 Subject: [PATCH 27/33] Explicit null checking --- src/test/java/TestUtil.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/test/java/TestUtil.java b/src/test/java/TestUtil.java index 72ba83f9..328a675d 100644 --- a/src/test/java/TestUtil.java +++ b/src/test/java/TestUtil.java @@ -369,8 +369,8 @@ public static void verifyOneAndOnlyOneEventSentToSplunk(String msg) throws IOExc break; } - resultsReader.close(); - resultsStream.close(); + Objects.requireNonNull(resultsReader, "resultsReader must not be null").close(); + Objects.requireNonNull(resultsStream, "resultsStream must not be null").close(); Assert.assertTrue(eventCount == 1); } @@ -399,8 +399,8 @@ public static void verifyNoEventSentToSplunk(List msgs) throws IOExcepti break; } - resultsReader.close(); - resultsStream.close(); + Objects.requireNonNull(resultsReader, "resultsReader must not be null").close(); + Objects.requireNonNull(resultsStream, "resultsStream must not be null").close(); Assert.assertTrue(eventCount == 0); } @@ -444,8 +444,8 @@ public static void verifyEventsSentToSplunk(List msgs) throws IOExceptio Thread.sleep(5000); } - resultsReader.close(); - resultsStream.close(); + Objects.requireNonNull(resultsReader, "resultsReader must not be null").close(); + Objects.requireNonNull(resultsStream, "resultsStream must not be null").close(); Assert.assertEquals("Event search results did not match.", 1, eventCount); } @@ -496,8 +496,8 @@ public static void verifyEventsSentInOrder(String prefix, int totalEventsCount, break; } - resultsReader.close(); - resultsStream.close(); + Objects.requireNonNull(resultsReader, "resultsReader must not be null").close(); + Objects.requireNonNull(resultsStream, "resultsStream must not be null").close(); assert (results.size() == totalEventsCount) : String.format("expect: %d, actual: %d", totalEventsCount, results.size()); From fc73d326a14fce5b0810995e55079c407a4b4c4c Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 05:15:34 -0400 Subject: [PATCH 28/33] Use assertEquals or fail over always using assertTrue --- src/test/java/HttpEventCollectorUnitTest.java | 68 +++++++++---------- src/test/java/HttpEventCollector_Test.java | 4 +- src/test/java/TestUtil.java | 4 +- 3 files changed, 38 insertions(+), 38 deletions(-) diff --git a/src/test/java/HttpEventCollectorUnitTest.java b/src/test/java/HttpEventCollectorUnitTest.java index 1b894187..dd482588 100644 --- a/src/test/java/HttpEventCollectorUnitTest.java +++ b/src/test/java/HttpEventCollectorUnitTest.java @@ -48,9 +48,9 @@ public void log4j_simple() throws Exception { HttpEventCollectorUnitTestMiddleware.io = new HttpEventCollectorUnitTestMiddleware.IO() { @Override public void input(List events) { - Assert.assertTrue(events.size() == 1); - Assert.assertTrue(events.get(0).getMessage().compareTo("hello log4j") == 0); - Assert.assertTrue(events.get(0).getSeverity().compareTo("INFO") == 0); + Assert.assertEquals(1, events.size()); + Assert.assertEquals(0, events.get(0).getMessage().compareTo("hello log4j")); + Assert.assertEquals(0, events.get(0).getSeverity().compareTo("INFO")); } }; LOG4J.info("hello log4j"); @@ -58,7 +58,7 @@ public void input(List events) { LOG4J.info("hello log4j"); if (HttpEventCollectorUnitTestMiddleware.eventsReceived == 0) sleep(15000); - Assert.assertTrue(HttpEventCollectorUnitTestMiddleware.eventsReceived == 3); + Assert.assertEquals(3, HttpEventCollectorUnitTestMiddleware.eventsReceived); } @Test @@ -78,16 +78,16 @@ public void logback_simple() throws Exception { HttpEventCollectorUnitTestMiddleware.io = new HttpEventCollectorUnitTestMiddleware.IO() { @Override public void input(List events) { - Assert.assertTrue(events.size() == 1); - Assert.assertTrue(events.get(0).getMessage().compareTo("hello logback") == 0); - Assert.assertTrue(events.get(0).getSeverity().compareTo("ERROR") == 0); - Assert.assertTrue(events.get(0).getLoggerName().compareTo(loggerName) == 0); + Assert.assertEquals(1, events.size()); + Assert.assertEquals(0, events.get(0).getMessage().compareTo("hello logback")); + Assert.assertEquals(0, events.get(0).getSeverity().compareTo("ERROR")); + Assert.assertEquals(0, events.get(0).getLoggerName().compareTo(loggerName)); } }; LOGBACK.error("hello logback"); LOGBACK.error("hello logback"); LOGBACK.error("hello logback"); - Assert.assertTrue(HttpEventCollectorUnitTestMiddleware.eventsReceived == 3); + Assert.assertEquals(3, HttpEventCollectorUnitTestMiddleware.eventsReceived); } @Test @@ -110,15 +110,15 @@ public void java_util_logger_simple() { HttpEventCollectorUnitTestMiddleware.io = new HttpEventCollectorUnitTestMiddleware.IO() { @Override public void input(List events) { - Assert.assertTrue(events.size() == 1); - Assert.assertTrue(events.get(0).getMessage().compareTo("hello java logger") == 0); - Assert.assertTrue(events.get(0).getSeverity().compareTo("WARNING") == 0); + Assert.assertEquals(1, events.size()); + Assert.assertEquals(0, events.get(0).getMessage().compareTo("hello java logger")); + Assert.assertEquals(0, events.get(0).getSeverity().compareTo("WARNING")); } }; LOGGER.warning("hello java logger"); LOGGER.warning("hello java logger"); LOGGER.warning("hello java logger"); - Assert.assertTrue(HttpEventCollectorUnitTestMiddleware.eventsReceived == 3); + Assert.assertEquals(3, HttpEventCollectorUnitTestMiddleware.eventsReceived); } @Test @@ -147,11 +147,11 @@ public HttpEventCollectorUnitTestMiddleware.HttpResponse output() { HttpEventCollectorErrorHandler.onError((data, ex) -> { HttpEventCollectorErrorHandler.ServerErrorException serverErrorException = (HttpEventCollectorErrorHandler.ServerErrorException) ex; - Assert.assertTrue(serverErrorException.getReply().compareTo("{\"text\":\"error\",\"code\":4}") == 0); - Assert.assertTrue(serverErrorException.getErrorCode() == 4); + Assert.assertEquals(0, serverErrorException.getReply().compareTo("{\"text\":\"error\",\"code\":4}")); + Assert.assertEquals(4, serverErrorException.getErrorCode()); }); LOGGER.info("hello"); - Assert.assertTrue(HttpEventCollectorUnitTestMiddleware.eventsReceived == 1); + Assert.assertEquals(1, HttpEventCollectorUnitTestMiddleware.eventsReceived); } @Test @@ -173,8 +173,8 @@ public void java_util_logger_resend() { int retries = 0; @Override public void input(List events) { - Assert.assertTrue(events.get(0).getMessage().compareTo("hello") == 0); - Assert.assertTrue(events.get(0).getSeverity().compareTo("INFO") == 0); + Assert.assertEquals(0, events.get(0).getMessage().compareTo("hello")); + Assert.assertEquals(0, events.get(0).getSeverity().compareTo("INFO")); } @Override public HttpEventCollectorUnitTestMiddleware.HttpResponse output() { @@ -191,7 +191,7 @@ public HttpEventCollectorUnitTestMiddleware.HttpResponse output() { }; LOGGER.info("hello"); // the system should make 2 retries - Assert.assertTrue(HttpEventCollectorUnitTestMiddleware.eventsReceived == 2); + Assert.assertEquals(2, HttpEventCollectorUnitTestMiddleware.eventsReceived); } @Test @@ -212,8 +212,8 @@ public void java_util_logger_resend_max_retries() { HttpEventCollectorUnitTestMiddleware.io = new HttpEventCollectorUnitTestMiddleware.IO() { @Override public void input(List events) { - Assert.assertTrue(events.get(0).getMessage().compareTo("hello") == 0); - Assert.assertTrue(events.get(0).getSeverity().compareTo("INFO") == 0); + Assert.assertEquals(0, events.get(0).getMessage().compareTo("hello")); + Assert.assertEquals(0, events.get(0).getSeverity().compareTo("INFO")); } @Override public HttpEventCollectorUnitTestMiddleware.HttpResponse output() { @@ -227,7 +227,7 @@ public HttpEventCollectorUnitTestMiddleware.HttpResponse output() { }); LOGGER.info("hello"); // the system should make only 2 retries and stop after that - Assert.assertTrue(HttpEventCollectorUnitTestMiddleware.eventsReceived == 3); + Assert.assertEquals(3, HttpEventCollectorUnitTestMiddleware.eventsReceived); } @Test @@ -245,16 +245,16 @@ public void java_util_logger_batching() { HttpEventCollectorUnitTestMiddleware.io = new HttpEventCollectorUnitTestMiddleware.IO() { @Override public void input(List events) { - Assert.assertTrue(events.size() == 3); - Assert.assertTrue(events.get(0).getMessage().compareTo("one") == 0); - Assert.assertTrue(events.get(1).getMessage().compareTo("two") == 0); - Assert.assertTrue(events.get(2).getMessage().compareTo("three") == 0); + Assert.assertEquals(3, events.size()); + Assert.assertEquals(0, events.get(0).getMessage().compareTo("one")); + Assert.assertEquals(0, events.get(1).getMessage().compareTo("two")); + Assert.assertEquals(0, events.get(2).getMessage().compareTo("three")); } }; LOGGER.info("one"); LOGGER.info("two"); LOGGER.info("three"); - Assert.assertTrue(HttpEventCollectorUnitTestMiddleware.eventsReceived == 3); + Assert.assertEquals(3, HttpEventCollectorUnitTestMiddleware.eventsReceived); } @Test @@ -271,13 +271,13 @@ public void java_util_logger_batching_default_count() { HttpEventCollectorUnitTestMiddleware.io = new HttpEventCollectorUnitTestMiddleware.IO() { @Override public void input(List events) { - Assert.assertTrue(events.size() == DefaultBatchCount); + Assert.assertEquals(DefaultBatchCount, events.size()); } }; for (int i = 0; i < DefaultBatchCount * 100; i ++) { LOGGER.info("*"); } - Assert.assertTrue(HttpEventCollectorUnitTestMiddleware.eventsReceived == DefaultBatchCount * 100); + Assert.assertEquals(DefaultBatchCount * 100, HttpEventCollectorUnitTestMiddleware.eventsReceived); } @Test @@ -294,13 +294,13 @@ public void java_util_logger_batching_default_size() { HttpEventCollectorUnitTestMiddleware.io = new HttpEventCollectorUnitTestMiddleware.IO() { @Override public void input(List events) { - Assert.assertTrue(events.size() == 1); + Assert.assertEquals(1, events.size()); } }; for (int i = 0; i < 10; i ++) { LOGGER.info(repeat("x", DefaultBatchSize)); } - Assert.assertTrue(HttpEventCollectorUnitTestMiddleware.eventsReceived == 10); + Assert.assertEquals(10, HttpEventCollectorUnitTestMiddleware.eventsReceived); } @Test @@ -317,14 +317,14 @@ public void java_util_logger_batching_default_interval() { HttpEventCollectorUnitTestMiddleware.io = new HttpEventCollectorUnitTestMiddleware.IO() { @Override public void input(List events) { - Assert.assertTrue(events.size() == 1); + Assert.assertEquals(1, events.size()); } }; LOGGER.info("=|:-)"); sleep(DefaultInterval / 2); - Assert.assertTrue(HttpEventCollectorUnitTestMiddleware.eventsReceived == 0); + Assert.assertEquals(0, HttpEventCollectorUnitTestMiddleware.eventsReceived); sleep(DefaultInterval); - Assert.assertTrue(HttpEventCollectorUnitTestMiddleware.eventsReceived == 1); + Assert.assertEquals(1, HttpEventCollectorUnitTestMiddleware.eventsReceived); } //-------------------------------------------------------------------------- diff --git a/src/test/java/HttpEventCollector_Test.java b/src/test/java/HttpEventCollector_Test.java index 9e6042c6..79ac99e0 100644 --- a/src/test/java/HttpEventCollector_Test.java +++ b/src/test/java/HttpEventCollector_Test.java @@ -203,7 +203,7 @@ private void LogToSplunk(boolean batching) throws Exception { HttpEventCollectorErrorHandler.ServerErrorException serverErrorException = (HttpEventCollectorErrorHandler.ServerErrorException) ex; System.out.printf("ERROR: %s", ex.toString()); - Assert.assertTrue(false); + Assert.fail(); }); int expectedCounter = 2; System.out.printf("\tSetting up http event collector with %s ... ", batching ? "batching" : "no batching"); @@ -265,7 +265,7 @@ public void ResendDataToSplunk() throws Exception HttpEventCollectorErrorHandler.ServerErrorException serverErrorException = (HttpEventCollectorErrorHandler.ServerErrorException) ex; System.out.printf("ERROR: %s", ex.toString()); - Assert.assertTrue(false); + Assert.fail(); }); boolean batching = false; System.out.printf("\tSetting up http event collector with %s ... ", batching ? "batching" : "no batching"); diff --git a/src/test/java/TestUtil.java b/src/test/java/TestUtil.java index 328a675d..49ffb0f4 100644 --- a/src/test/java/TestUtil.java +++ b/src/test/java/TestUtil.java @@ -372,7 +372,7 @@ public static void verifyOneAndOnlyOneEventSentToSplunk(String msg) throws IOExc Objects.requireNonNull(resultsReader, "resultsReader must not be null").close(); Objects.requireNonNull(resultsStream, "resultsStream must not be null").close(); - Assert.assertTrue(eventCount == 1); + Assert.assertEquals(1, eventCount); } public static void verifyNoEventSentToSplunk(List msgs) throws IOException { @@ -402,7 +402,7 @@ public static void verifyNoEventSentToSplunk(List msgs) throws IOExcepti Objects.requireNonNull(resultsReader, "resultsReader must not be null").close(); Objects.requireNonNull(resultsStream, "resultsStream must not be null").close(); - Assert.assertTrue(eventCount == 0); + Assert.assertEquals(0, eventCount); } /* From d561060162b7ffd86e16cb80cd40652fc53dbf97 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 05:22:54 -0400 Subject: [PATCH 29/33] Avoid obvious implicit casts --- src/test/java/HttpEventCollector_Test.java | 2 +- src/test/java/HttpLoggerStressTest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/java/HttpEventCollector_Test.java b/src/test/java/HttpEventCollector_Test.java index 79ac99e0..ae35a7cd 100644 --- a/src/test/java/HttpEventCollector_Test.java +++ b/src/test/java/HttpEventCollector_Test.java @@ -245,7 +245,7 @@ public DataSender(String threadName, int testDurationInSecs, java.util.logging.L public void run() { Date dCurrent = new Date(); Date dEnd = new Date(); - dEnd.setTime(dCurrent.getTime() + testDurationInSecs * 1000); + dEnd.setTime(dCurrent.getTime() + testDurationInSecs * 1000L); while (dCurrent.before(dEnd)) { this.logger.info(String.format("javautil thread: %s, event: %d", this.threadName, eventsGenerated++)); try { diff --git a/src/test/java/HttpLoggerStressTest.java b/src/test/java/HttpLoggerStressTest.java index f18046a1..c909fd02 100644 --- a/src/test/java/HttpLoggerStressTest.java +++ b/src/test/java/HttpLoggerStressTest.java @@ -28,7 +28,7 @@ public DataSender(String threadName, int testDurationInSecs) { public void run() { Date dCurrent = new Date(); Date dEnd = new Date(); - dEnd.setTime(dCurrent.getTime() + testDurationInSecs * 1000); + dEnd.setTime(dCurrent.getTime() + testDurationInSecs * 1000L); while(dCurrent.before(dEnd)) { this.logger.info(String.format("Thread: %s, event: %d", this.threadName, eventsGenerated++)); dCurrent = new Date(); From 448005d193f94155977f2be84fec3989d794b254 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Mon, 25 Oct 2021 05:38:40 -0400 Subject: [PATCH 30/33] Mark fields static/final in tests --- src/test/java/HttpEventCollector_JavaLoggingTest.java | 3 ++- src/test/java/HttpEventCollector_Test.java | 6 +++--- src/test/java/HttpLoggerStressTest.java | 6 +++--- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/test/java/HttpEventCollector_JavaLoggingTest.java b/src/test/java/HttpEventCollector_JavaLoggingTest.java index e5c007e1..2389ab87 100644 --- a/src/test/java/HttpEventCollector_JavaLoggingTest.java +++ b/src/test/java/HttpEventCollector_JavaLoggingTest.java @@ -29,7 +29,8 @@ public final class HttpEventCollector_JavaLoggingTest { - private String httpEventCollectorName = "JavaLoggingTest"; + private static final String httpEventCollectorName = "JavaLoggingTest"; + private final List> errors = new ArrayList<>(); private final List logEx = new ArrayList<>(); diff --git a/src/test/java/HttpEventCollector_Test.java b/src/test/java/HttpEventCollector_Test.java index ae35a7cd..4ad3188c 100644 --- a/src/test/java/HttpEventCollector_Test.java +++ b/src/test/java/HttpEventCollector_Test.java @@ -81,7 +81,7 @@ private static int getEventsCount(String searchQuery) throws IOException, Interr } private static ServiceArgs serviceArgs; - private static String httpEventCollectorName = "functionalhttp"; + private static final String httpEventCollectorName = "functionalhttp"; private static String setupHttpEventCollector(boolean batching) throws Exception { TestUtil.enableHttpEventCollector(); @@ -232,9 +232,9 @@ private void waitForIndexingToComplete(String query, int expectedCounter) throws } private static class DataSender implements Runnable { - private String threadName; + private final String threadName; public int eventsGenerated = 0, testDurationInSecs = 300; - java.util.logging.Logger logger; + private final java.util.logging.Logger logger; public DataSender(String threadName, int testDurationInSecs, java.util.logging.Logger logger) { this.threadName = threadName; diff --git a/src/test/java/HttpLoggerStressTest.java b/src/test/java/HttpLoggerStressTest.java index c909fd02..961a9cb2 100644 --- a/src/test/java/HttpLoggerStressTest.java +++ b/src/test/java/HttpLoggerStressTest.java @@ -15,9 +15,9 @@ public class HttpLoggerStressTest { private static class DataSender implements Runnable { - private String threadName; + private final String threadName; public int eventsGenerated = 0, testDurationInSecs = 300; - Logger logger; + private final Logger logger; public DataSender(String threadName, int testDurationInSecs) { this.threadName = threadName; @@ -93,7 +93,7 @@ private static int getEventsCount(String searchQuery) throws IOException, Interr } private static ServiceArgs serviceArgs; - private static String httpEventCollectorName = "stressHttpEventCollector"; + private static final String httpEventCollectorName = "stressHttpEventCollector"; private static void setupHttpEventCollector() throws Exception { String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); From 51acf6736310f599f5198a458c9d28ca188a67d5 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Tue, 26 Oct 2021 00:56:48 -0400 Subject: [PATCH 31/33] logEx can never be null --- src/test/java/HttpEventCollector_JavaLoggingTest.java | 5 ----- src/test/java/HttpEventCollector_Log4j2Test.java | 5 ----- src/test/java/HttpEventCollector_LogbackTest.java | 8 +------- 3 files changed, 1 insertion(+), 17 deletions(-) diff --git a/src/test/java/HttpEventCollector_JavaLoggingTest.java b/src/test/java/HttpEventCollector_JavaLoggingTest.java index 2389ab87..588ce87d 100644 --- a/src/test/java/HttpEventCollector_JavaLoggingTest.java +++ b/src/test/java/HttpEventCollector_JavaLoggingTest.java @@ -274,9 +274,6 @@ public void errorHandlingInvalidToken() throws Exception { Thread.sleep(1000); } - if (logEx == null) - Assert.fail("didn't catch errors"); - System.out.println("======print logEx"); System.out.println(logEx); @@ -335,8 +332,6 @@ public void errorHandlingDisabledHttpEventCollectorEndpoint() throws Exception { // Enable httpEventCollector endpoint TestUtil.enableHttpEventCollector(); - if (logEx == null) - Assert.fail("didn't catch errors"); Assert.assertEquals(1, errors.size()); System.out.println(logEx); diff --git a/src/test/java/HttpEventCollector_Log4j2Test.java b/src/test/java/HttpEventCollector_Log4j2Test.java index bf4c1368..ef0d1f51 100644 --- a/src/test/java/HttpEventCollector_Log4j2Test.java +++ b/src/test/java/HttpEventCollector_Log4j2Test.java @@ -258,9 +258,6 @@ public void errorHandlingInvalidToken() throws Exception { Thread.sleep(1000); } - if (logEx == null) - Assert.fail("didn't catch errors"); - for (List infos : errors) { for (HttpEventCollectorEventInfo info : infos) { System.out.println(info.getMessage()); @@ -319,8 +316,6 @@ public void errorHandlingDisabledHttpEventCollectorEndpoint() throws Exception { Thread.sleep(1000); } - if (logEx == null) - Assert.fail("didn't catch errors"); Assert.assertTrue(errors.size() >= 1); System.out.println(logEx); diff --git a/src/test/java/HttpEventCollector_LogbackTest.java b/src/test/java/HttpEventCollector_LogbackTest.java index 30860ebd..b28b5575 100644 --- a/src/test/java/HttpEventCollector_LogbackTest.java +++ b/src/test/java/HttpEventCollector_LogbackTest.java @@ -251,10 +251,6 @@ public void errorHandlingInvalidToken() throws Exception { Thread.sleep(1000); } - if (logEx == null) - Assert.fail("didn't catch errors"); - - System.out.println("======print logEx"); System.out.println(logEx); System.out.println("======finish print logEx"); @@ -312,9 +308,7 @@ public void errorHandlingDisabledHttpEventCollectorEndpoint() throws Exception { } TestUtil.enableHttpEventCollector(); - - if (logEx == null) - Assert.fail("didn't catch errors"); + Assert.assertEquals(1, errors.size()); System.out.println(logEx); From 423d85e26fcc66b965e091523c7404ad63b88732 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Tue, 15 Feb 2022 05:00:30 -0500 Subject: [PATCH 32/33] Remove unread collection --- src/test/java/HttpEventCollector_Log4j2Test.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/test/java/HttpEventCollector_Log4j2Test.java b/src/test/java/HttpEventCollector_Log4j2Test.java index ef0d1f51..aec304d0 100644 --- a/src/test/java/HttpEventCollector_Log4j2Test.java +++ b/src/test/java/HttpEventCollector_Log4j2Test.java @@ -343,7 +343,6 @@ public void eventsIsIndexedInOrderOfSent() throws Exception { org.apache.logging.log4j.core.LoggerContext context = TestUtil.resetLog4j2Configuration("log4j2_template.xml", "log4j2.xml", userInputs); //send multiple events and verify they are indexed in the order of sending - List msgs = new ArrayList<>(); Date date = new Date(); int totalEventsCount = 1000; Logger logger = context.getLogger(loggerName); @@ -351,7 +350,6 @@ public void eventsIsIndexedInOrderOfSent() throws Exception { for (int i = 0; i < totalEventsCount; i++) { String jsonMsg = String.format("%s %s", prefix,i); logger.info(jsonMsg); - msgs.add(jsonMsg); } TestUtil.verifyEventsSentInOrder(prefix,totalEventsCount,indexName); From e8530bc6687f15535b15233d1cafd54fe9dbeb25 Mon Sep 17 00:00:00 2001 From: stevejagodzinski Date: Tue, 15 Feb 2022 05:02:00 -0500 Subject: [PATCH 33/33] Fix typo --- src/test/java/HttpEventCollector_Log4j2Test.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/HttpEventCollector_Log4j2Test.java b/src/test/java/HttpEventCollector_Log4j2Test.java index aec304d0..20c9878a 100644 --- a/src/test/java/HttpEventCollector_Log4j2Test.java +++ b/src/test/java/HttpEventCollector_Log4j2Test.java @@ -171,7 +171,7 @@ public void sendBatchedEventsByCount() throws Exception { * sending a message via httplogging using java.logging with batched_size_bytes */ @Test - public void sendBatchedEventsByBatchsize() throws Exception { + public void sendBatchedEventsByBatchSize() throws Exception { String token = TestUtil.createHttpEventCollectorToken(httpEventCollectorName); String loggerName = "splunkLoggerBatchSize"; HashMap userInputs = new HashMap<>();