Merge pull request #8 from splunk/bugfix/upgrade_bootstart

[SAS-5320] Remove disable boot-start task during uprades

Author: Mason Morales

README.md

@@ -148,7 +148,7 @@ Note: Any task with an **adhoc** prefix means that it is intended to be used adh
 - **splunk_restart.yml**  - Restarts splunk via CLI command. Used when waiting for a handler to run at the end of the play would be inappapropriate.
 - **splunk_start.yml** - Starts splunk via CLI command. This task will also accept the license and answers yes for any prompts.  Used when waiting for a handler to run at the end of the play would be inappapropriate.
 - **splunk_stop.yml** - Stops splunk via CLI command.  Used when waiting for a handler to run at the end of the play would be inappapropriate.
-- **upgrade_splunk.yml** - Called by check_splunk.yml. Performs an upgrade of an existing splunk installation. Configures .bash_profile and .bashrc for splunk user (by calling configure_bash.yml), disables THP and increases ulimits (by calling configure_os.yml), disables boot-start (this addresses a bug in 7.2.x -- it gets re-enabled by a hander at the end), kills any stale splunkd processes present (by calling adhoc_kill_splunkd.yml). Note: You should NOT run the upgrade_splunk.yml task directly from a playbook. check_splunk.yml will call upgrade_splunk.yml if it determines that an upgrade is needed; It will then download and unarchive the new version of Splunk (by calling download_and_unarchive.yml), ensure that mongod is in a good stopped state (by calling adhoc_fix_mongo.yml), and will then perform post-installation tasks using the post_install.yml task.
+- **upgrade_splunk.yml** - Called by check_splunk.yml. Performs an upgrade of an existing splunk installation. Configures .bash_profile and .bashrc for splunk user (by calling configure_bash.yml), disables THP and increases ulimits (by calling configure_os.yml), kills any stale splunkd processes present (by calling adhoc_kill_splunkd.yml). Note: You should NOT run the upgrade_splunk.yml task directly from a playbook. check_splunk.yml will call upgrade_splunk.yml if it determines that an upgrade is needed; It will then download and unarchive the new version of Splunk (by calling download_and_unarchive.yml), ensure that mongod is in a good stopped state (by calling adhoc_fix_mongo.yml), and will then perform post-installation tasks using the post_install.yml task.
 
 ## Frequently Asked Questions
 **Q:** What is the difference between this and splunk-ansible?

roles/splunk/tasks/upgrade_splunk.yml

@@ -7,11 +7,6 @@
 - name: Configure OS to disable THP and increase ulimits for splunk process
   include_tasks: configure_os.yml
 
-- name: Disable boot-start to ensure restart is successful in 7.2.2+ (this will get re-enabled by a handler with the correct parameters at the end)
-  shell: "{{ splunk_home }}/bin/splunk disable boot-start -user {{ splunk_nix_user }}"
-  become: yes
-  ignore_errors: true
-
 - name: Include task to kill any stale splunkd processes
   include_tasks: adhoc_kill_splunkd.yml