chore: add GS Scorecard versioning and improve ECR login process

Author: mbruzda-splunk

.github/workflows/reusable-build-test-release.yml

@@ -113,6 +113,7 @@ env:
   PYTHON_VERSION: "3.9"
   POETRY_VERSION: "2.1.4"
   POETRY_EXPORT_PLUGIN_VERSION: "1.9.0"
+  GS_SCORECARD_VERSION: "1.0.0"
 jobs:
   validate-custom-version:
     runs-on: ubuntu-latest
@@ -832,11 +833,10 @@ jobs:
           aws-secret-access-key: ${{ secrets.GSSA_AWS_SECRET_ACCESS_KEY }}
           aws-region: us-west-2
       - name: Login to Amazon ECR
-        run: |
-          aws ecr get-login-password --region us-west-2 | docker login --username AWS --password-stdin 956110764581.dkr.ecr.us-west-2.amazonaws.com
+        uses: aws-actions/amazon-ecr-login@v2
       - name: Pull GS Scorecard image
-        run: |
-          docker pull 956110764581.dkr.ecr.us-west-2.amazonaws.com/ta-automation/gs-scorecard:1.0.0
+        run:
+          docker pull 956110764581.dkr.ecr.us-west-2.amazonaws.com/ta-automation/gs-scorecard:${{ env.GS_SCORECARD_VERSION }}
       - name: Run GS Scorecard
         env:
           GITHUB_TOKEN: ${{ secrets.GH_TOKEN_ADMIN }}