chore: resolving review comments of dev to main pr (398) (#415)

### Description

Resolving review comments of PR:
#398

- This PR addresses [this
comment](#398 (comment))
by removing redundant updates to both test-inventory and setup-workflow
for docs-only changes. Updating both is unnecessary since failure in
either prevents tests from running.
- Test runs:
https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/15754544427/job/44407048288?pr=1486
- A few minor review comment changes were also made; they don't require
testing.

### Checklist

- [ ] `README.md` has been updated or is not required
- [ ] push trigger tests
- [ ] manual release test
- [ ] automated releases test
- [ ] pull request trigger tests
- [ ] schedule trigger tests
- [ ] workflow errors/warnings reviewed and addressed

### Testing done 
(for each selected checkbox, the corresponding test results link should
be listed here)

Author: siddharth-khatsuriya

.github/workflows/reusable-build-test-release.yml

@@ -39,7 +39,7 @@ on:
         required: false
         description: "branch for k8s manifests to run the tests on"
         type: string
-        default: "v3.4.1"
+        default: "v3.5.0"
       scripted-inputs-os-list:
         required: false
         description: "list of OS used for scripted input tests"
@@ -139,7 +139,6 @@ jobs:
           set -o xtrace
           # List all files modified in the commit or PR
           changed_files=$(git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.sha }})
-          # changed_files=$(git diff --name-only ${{ github.event.before }} ${{ github.sha }})
 
           # Check if any of the changed files are not in docs/*, mkdocs.yml, or .github/workflows/docs.yml
           if echo "$changed_files" | grep -vqE '^(docs/|mkdocs.yml|.github/workflows/docs.yml)'; then
@@ -198,9 +197,7 @@ jobs:
           case "${{ github.event_name }}" in
           "pull_request")
             labels=$(echo '${{ toJSON(github.event.pull_request.labels) }}' | jq -r '.[] | .name')
-            if ${{ needs.check-docs-changes.outputs.docs-only == 'true' }}; then
-              echo -e "\033[1;33m⚠️ Skipping tests as there are only documentation related changes ⚠️\033[0m"
-            elif ${{ github.base_ref == 'main' }} && ${{ contains(github.event.pull_request.labels.*.name, 'use_labels') }}; then
+            if ${{ github.base_ref == 'main' }} && ${{ contains(github.event.pull_request.labels.*.name, 'use_labels') }}; then
               for test_type in "${TESTSET[@]}"; do
                 if [[ "$labels" =~ $test_type ]]; then
                   EXECUTE_LABELED["$test_type"]="true"

runbooks/update_appinspect_cli_action.md

@@ -22,7 +22,7 @@ Once Splunk AppInspect team releases AppInspect CLI - we need to make sure that
 
 - create a PR in this repository with a new version of the action ([example PR](https://github.com/splunk/addonfactory-workflow-addon-release/pull/247))
     - make sure that PR is towards `main` branch
-    - make sure the tile of the PR follows the format: "fix: update AppInspect CLI action to v.X.Y"
+    - make sure the title of the PR follows the format: "fix: update AppInspect CLI action to v.X.Y"
     - make sure that the pipeline is green
     - attach a link to a test run of reusable workflow
     - get review from the team