chore: release v4.16 (#256)

Customer-facing release notes:

* feat: remove Firefox from ui tests (#228)
* fix: remove artifact-registry (#226) 
* feat(release): addonfactory-packaging-toolkit-action removal (#230) 
* fix: move poetry lock --check to unit tests job (#245) 
* feat: remove ESCU tests from reusable workflow (#234) 
* Splunk AppInspect CLI Action update to v2.6
* fix: combining splunk versions for python3.9 matrix issues (#257)

Test runs:

* splunk/splunk-add-on-for-microsoft-sysmon#315
* splunk/splunk-add-on-for-google-workspace#545

Author: mkolasinski-splunk

.github/workflows/branch-test-release.yml

@@ -20,7 +20,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: apache/skywalking-eyes@v0.5.0
+      - uses: apache/skywalking-eyes@v0.6.0
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
@@ -33,7 +33,7 @@ jobs:
           python-version: "3.7"
       - run: |
           bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/v1.6.26/scripts/download-actionlint.bash)
-      - uses: pre-commit/action@v3.0.0
+      - uses: pre-commit/action@v3.0.1
 
   publish:
     needs:

.github/workflows/build-test-release.yaml

@@ -24,3 +24,4 @@ header:
     - "README.md"
     - "LICENSE"
     - ".*"
+    - "runbooks/"

.github/workflows/reusable-build-test-release.yml

@@ -19,7 +19,7 @@ Workflow defines jobs which perform security code scanning, execute different ty
   * test it
   * create a PR to the `main` branch
   * get all the approvals from the team
-  * merge it using "merge commit" option
+  * merge it using "squash commit" option
   * backport the change back to the `develop` branch
   * new version of the workflow is going to be released (v4.17.0 (before) -> v4.17.1 (after)) and it will automatically applied to all the repositories
 
@@ -411,30 +411,6 @@ appinspect-api-html-report-self-service
 
 **Action used:** NA
 
-# artifact-registry
-
-**Description:**
-
-- Uploads the generated addon build to ghcr.io.
-
-**Action used:** 
-
-- https://github.com/actions/download-artifact
-- https://github.com/docker/setup-buildx-action
-- https://github.com/docker/login-action 
-
-**Artifacts:** 
-
-- No Artifacts
-
-- This build can be downloaded using oras if it’s not availale in ghcr yet
-
-- User can use the following command to download build for the respective PR
-
-```
-oras pull -u <github-username> -p <github-token> ghcr.io/splunk/splunk-add-on-for-microsoft-sql-server:Splunk_TA_microsoft-sqlserver-<PR-no> 
-```
-
 # test-unit-python3
 
 **Description:**
@@ -657,69 +633,6 @@ source_code.zip
 source_code.tar.gz
 ```
 
-Publish-untested (Publish a manual release):
-============================================
-
-**NOTE:** This stage will create a new release with the main branch code irrespective of the test-execution status hence before creating a new release via this stage make sure all stakeholders are aware before the release. 
-
-- Follow the below steps to create a manual release and publish the relevant packages:
-
-- Go to "Actions" tab of your Github repo link.
-
-- On the left side, you'd have **"publish-untested"** workflow mentioned. Click on this stage.
-
-- Click on **"Run Workflow"**.
-
-- Select the branch from which you to create the tag.
-
-- Ideally, all our final code would be in the main branch. Hence, in majority of cases the branch would be "main" only.
-
-- Provide the version in "Tag to release" textbox.
-
-- Example, if you are releasing a new version v4.0.1 of your add-on, just enter **"4.0.1"** (just the dot delimited digits, do not prefix it with "v").
-
-- Click on **"Run Workflow"**.
-
-- Wait for a couple minutes for the build to be generated and published. 
-
-- Once the above stage completes, go to "Releases" section of your repo.
-
-- Edit the release and write the relevant release notes you want to for your bugfix/ hotfix release and save the changes.
-
-<img src="images/publish-untested/publish-untested.png" alt="publish-untested" style="width:200px;"/> 
-
-
-release-set-git-tags
-====================
-**Description**
-
-- This action updates major/minor release tags on a tag push. e.g. Update v1 and v1.2 tag when released v1.2.3.
-
-**Action used** https://github.com/haya14busa/action-update-semver
-
-
-Artifacts for different stages:
-================================
-
-- Artifacts can be found in the summary if we scroll to the bottom as shown in the screenshot below. <br />
-<img src="images/artifacts_all.png" alt="publish-untested" style="width:200px;"/> 
-
-- Link to the test-report for the stage can be found inside logs as shown here: 
-
-<img src="images/modinput/report_link.png" alt="report_link" style="width:200px;"/> 
-<img src="images/modinput/report_stage.png" alt="report_stage" style="width:200px;"/> 
-
-
-Different Test reports stages
-=============================
-- addonfactory-sample-scanner
-- splunk 8.x.y knowledge test report
-- splunk 8.x.y modinput_functional test report
-- splunk 8.x.y ui chrome test report
-- splunk 8.x.y requirement_test test report
-- splunk 8.x.y unit test report
-
-
 Vendor Addon Matrix tests
 =========================
 

.licenserc.yaml

@@ -0,0 +1,39 @@
+# Runbook to update splunk/appinspect-cli-action
+
+Once Splunk AppInspect team releases AppInspect CLI - we need to make sure that everyone runs the latest version.
+
+## Steps
+
+### Merge splunk/appinspect-cli-action PR
+
+- go to the PR [example](https://github.com/splunk/appinspect-cli-action/pull/127)
+    - check [release notes](https://dev.splunk.com/enterprise/docs/relnotes/relnotes-appinspectcli/whatsnew/) for the new version add release notes link in the PR comment
+    - make sure that the pipeline is green
+        - if not - investigate why and report and issue to the AppInspect team
+    - determine which version of `appinspect-cli-action` needs to be released based on the [splunk-appinspect release](https://dev.splunk.com/enterprise/docs/relnotes/relnotes-appinspectcli/whatsnew/)
+        - if it is a bug fix release (E.g. v3.6.0 > v3.6.1) - change "chore" to "fix" in the title of the PR and skip [update section](#update-splunkaddonfactory-workflow-addon-release)
+        - if it is a minor release (E.g v3.6.0 > v3.7.0) - change "chore" to "feat" in the title of the PR
+    - get review from the team
+    - "Squash and merge" the PR
+    - wait for the release
+        - make sure that the proper version of the action is released
+
+### Update splunk/addonfactory-workflow-addon-release
+
+- create a PR in this repository with a new version of the action ([example PR](https://github.com/splunk/addonfactory-workflow-addon-release/pull/247))
+    - make sure that PR is towards `main` branch
+    - make sure that the pipeline is green
+    - determine which version of `appinspect-cli-action` needs to be released based on the PR
+      - if it is a bug fix or dependecnies update - "fix" in the title of the PR
+      - if it is a feature release - "feat" in the title of the PR
+    - attach a link to a test run of reusable workflow
+    - get review from the team
+    - "Squash and merge" the PR
+- backport this change to develop right away ([example PR](https://github.com/splunk/addonfactory-workflow-addon-release/pull/239))
+    - create a PR from `main` to `develop`
+    - get review from the team
+    - "Merge pull request" the PR
+
+### Notify teams
+
+- notify development teams in #ta-engineering-dev-all Slack channel (look for the previous announcements to see the format)