Skip to content

Commit ecbb499

Browse files
committed
BREAKING CHANGE: removed urllib3 from solnlib dependencies
1 parent ae5cecb commit ecbb499

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

docs/release_6_0_0.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1-
# Removed requests from solnlib
1+
# Removed requests and urllib3 from solnlib
22

3-
The `requests` library has been removed from solnlib, so solnlib now depends on the `requests` library from the running environment.
4-
By default, splunk delivers `requests` whose version depends on the splunk version. More information [here](https://docs.splunk.com/Documentation/Splunk/9.2.3/ReleaseNotes/Credits).
3+
The `requests` and `urllib3` libraries has been removed from solnlib, so solnlib now depends on the `requests` and `urllib3` libraries from the running environment.
4+
By default, Splunk delivers the above libraries and their version depends on the Splunk version. More information [here](https://docs.splunk.com/Documentation/Splunk/9.2.3/ReleaseNotes/Credits).
55

6-
Please note that if `requests` are installed in `<Add-on>/lib` e.g. as a dependency of another library, that version will be taken first.
7-
If `requests` are missing from the add-on's `lib` directory, then `requests` provided from splunk will be used. In case the splunk `requests` version is not sufficient for you,
6+
**IMPORTANT**: `urllib3` is available in Splunk `v8.1.0` and later
7+
8+
Please note that if `requests` or `urllib3` are installed in `<Add-on>/lib` e.g. as a dependency of another library, that version will be taken first.
9+
If `requests` or `urllib3` is missing in the add-on's `lib` directory, the version provided by Splunk will be used. In case the Splunk `requests` or `urllib3` version is not sufficient for you,
810
you can deliver version you need by simply adding it to the `requirements.txt` or `pyproject.toml` file in your add-on.

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ classifiers = [
4040

4141
[tool.poetry.dependencies]
4242
python = ">=3.7,<3.14"
43-
urllib3 = "<2"
4443
sortedcontainers = ">=2"
4544
defusedxml = ">=0.7"
4645
splunk-sdk = ">=1.6"

0 commit comments

Comments
 (0)