Skip to content

Commit 3f4ff72

Browse files
fix: bump psa version (#446)
- bump the PSA to latest verison (i.e. v6.0.0) - Update the `upload-artifact` and `download-artifact` action version to v4 since v3 is deprecated now. - Correction in the HEC token value being passed when executing the tests. HEC token value was different in pytest.ini and in the run_splunk.sh file resulting in failure of HEC validation when executing the tests. It didn't failed the tests earlier because the PSA v5.2.6 and earlier didn't had the HEC token validation. test run: https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/13941331735
1 parent 742e632 commit 3f4ff72

File tree

4 files changed

+11
-12
lines changed

4 files changed

+11
-12
lines changed

.github/workflows/build-test-release.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
fossa report attribution --format text > /tmp/THIRDPARTY
3838
env:
3939
FOSSA_API_KEY: ${{ secrets.FOSSA_API_KEY }}
40-
- uses: actions/upload-artifact@v3
40+
- uses: actions/upload-artifact@v4
4141
with:
4242
name: THIRDPARTY
4343
path: /tmp/THIRDPARTY
@@ -118,7 +118,7 @@ jobs:
118118
--config=tests/testdata/Splunk_TA_UCCExample/globalConfig.json \
119119
--ta-version=0.0.1
120120
if: always()
121-
- uses: actions/upload-artifact@v3
121+
- uses: actions/upload-artifact@v4
122122
with:
123123
name: output
124124
path: output/*
@@ -155,7 +155,7 @@ jobs:
155155
- uses: actions/setup-python@v4
156156
with:
157157
python-version: ${{ env.PYTHON_VERSION }}
158-
- uses: actions/download-artifact@v3
158+
- uses: actions/download-artifact@v4
159159
with:
160160
name: output
161161
path: output/
@@ -180,7 +180,7 @@ jobs:
180180
./run_splunk.sh ${{ matrix.splunk.version }}
181181
until curl -Lsk "https://localhost:8088/services/collector/health" &>/dev/null ; do echo -n "Waiting for HEC-" && sleep 5 ; done
182182
- run: poetry run pytest tests/ui -k "${{ matrix.test_suite }}" --headless --junitxml=test-results/junit.xml
183-
- uses: actions/upload-artifact@v3
183+
- uses: actions/upload-artifact@v4
184184
if: always()
185185
with:
186186
name: test-results-${{ matrix.splunk.version }}_${{ matrix.python-version }}_${{ matrix.browser }}_${{ matrix.test_suite }}

poetry.lock

Lines changed: 5 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ webdriver-manager = "*"
4747
msedge-selenium-tools = "*"
4848
cssselect = "*"
4949
lxml = "^5.1.0"
50-
pytest-splunk-addon = "^5.0.0"
50+
pytest-splunk-addon = "^6.0.0"
5151

5252
[tool.poetry.plugins]
5353
pytest11 = { "ucc-smartx" = "pytest_splunk_addon_ui_smartx.plugin" }

tests/ui/pytest.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ addopts = -vv
2020
--splunk-host=localhost
2121
--splunk-user=admin
2222
--splunk-password=Chang3d!
23-
--splunk-hec-token=9b741d03-43e9-4164-908b-e09102327d22
23+
--splunk-hec-token=4a8a737d-5452-426c-a6f7-106dca4e813f
2424
--browser=chrome
2525
--local
2626
--persist-browser

0 commit comments

Comments
 (0)