Use ModuleSpec.origin (#13973)

Author: AA-Turner

sphinx/ext/autodoc/_documenters.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import sys
 from typing import TYPE_CHECKING, NewType, TypeVar
 
 from docutils.statemachine import StringList
@@ -27,7 +28,6 @@
 
 if TYPE_CHECKING:
     from collections.abc import Callable, Iterator, Sequence
-    from types import ModuleType
     from typing import Any, ClassVar, Final, Literal, NoReturn
 
     from sphinx.config import Config
@@ -97,7 +97,6 @@ def __init__(
         self.get_attr = directive.get_attr
         self.name = name
         self.indent: Final = indent
-        self.module: ModuleType | None = None
         # the parent/owner of the object to document
         self.parent: Any = None
         # the module analyzer to get at attribute docs, or None
@@ -144,10 +143,9 @@ def _load_object_by_name(self) -> Literal[True] | None:
         )
         if ret is None:
             return None
-        props, module, parent = ret
+        props, parent = ret
 
         self.props = props
-        self.module = module
         self.parent = parent
         self._load_object_has_been_called = True
         return True
@@ -407,9 +405,19 @@ def _generate(
             logger.debug('[autodoc] module analyzer failed: %s', exc)
             # no source file -- e.g. for builtin and C modules
             self.analyzer = None
-            # at least add the module.__file__ as a dependency
-            if module___file__ := getattr(self.module, '__file__', ''):
-                self.directive.record_dependencies.add(module___file__)
+            # at least add the module source file as a dependency
+            if self.props.module_name:
+                try:
+                    module_spec = sys.modules[self.props.module_name].__spec__
+                except (AttributeError, KeyError):
+                    pass
+                else:
+                    if (
+                        module_spec is not None
+                        and module_spec.has_location
+                        and module_spec.origin
+                    ):
+                        self.directive.record_dependencies.add(module_spec.origin)
         else:
             self.directive.record_dependencies.add(self.analyzer.srcname)
 

sphinx/ext/autodoc/importer.py

@@ -495,7 +495,7 @@ def _load_object_by_name(
     events: EventManager,
     get_attr: _AttrGetter,
     options: _AutoDocumenterOptions,
-) -> tuple[_ItemProperties, ModuleType | None, Any] | None:
+) -> tuple[_ItemProperties, Any] | None:
     """Import and load the object given by *name*."""
     parsed = _parse_name(
         name=name,
@@ -542,13 +542,18 @@ def _load_object_by_name(
 
     # Assemble object properties from the imported object.
     props: _ItemProperties
-    module = im.module
     parent = im.parent
     object_name = im.object_name
     obj = im.obj
     obj_properties: set[_AutodocFuncProperty] = set()
     if objtype == 'module':
-        file_path = getattr(module, '__file__', None)
+        try:
+            mod_origin = im.module.__spec__.origin  # type: ignore[union-attr]
+        except AttributeError:
+            file_path = None
+        else:
+            file_path = Path(mod_origin) if mod_origin is not None else None
+
         mod_all = safe_getattr(obj, '__all__', None)
         if isinstance(mod_all, (list, tuple)) and all(
             isinstance(e, str) for e in mod_all
@@ -564,7 +569,7 @@ def _load_object_by_name(
             obj_type=objtype,
             module_name=module_name,
             docstring_lines=(),
-            file_path=Path(file_path) if file_path is not None else None,
+            file_path=file_path,
             all=mod_all,
             _obj=obj,
             _obj___module__=obj.__name__,
@@ -911,7 +916,7 @@ def _load_object_by_name(
         f'{args} -> {retann}' if retann else str(args) for args, retann in signatures
     )
 
-    return props, module, parent
+    return props, parent
 
 
 def _parse_name(