Skip to content

Commit 4e08f1a

Browse files
committed
render_response_content -> render_response_example
Because it's what it actually does! Moreover, I even use '_example' suffix in the similar situation for request body's example, and I am about to add another rendering method that also deals with content but leaves alone example.
1 parent 7de882b commit 4e08f1a

File tree

2 files changed

+33
-35
lines changed

2 files changed

+33
-35
lines changed

sphinxcontrib/openapi/renderers/_httpdomain.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ def render_response(self, status_code, response):
329329
if "content" in response and status_code in self._response_examples_for:
330330
yield ""
331331
yield from indented(
332-
self.render_response_content(response["content"], status_code)
332+
self.render_response_example(response["content"], status_code)
333333
)
334334

335335
if "headers" in response:
@@ -362,7 +362,7 @@ def render_response(self, status_code, response):
362362
markers = ", ".join(markers)
363363
yield f":resheadertype {header_name}: {markers}"
364364

365-
def render_response_content(self, media_type, status_code):
365+
def render_response_example(self, media_type, status_code):
366366
# OpenAPI 3.0 spec may contain more than one response media type, and
367367
# each media type may contain more than one example. Rendering all
368368
# invariants normally is not an option because the result will be hard

tests/renderers/httpdomain/test_render_response_content.py renamed to tests/renderers/httpdomain/test_render_response_example.py

Lines changed: 31 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
"""OpenAPI spec renderer: render_response_content."""
1+
"""OpenAPI spec renderer: render_response_example."""
22

33
import textwrap
44

@@ -109,11 +109,11 @@ def textify(generator):
109109
),
110110
],
111111
)
112-
def test_render_response_content_example(testrenderer, oas_fragment, media_type):
112+
def test_render_response_example(testrenderer, oas_fragment, media_type):
113113
"""Path response's example is rendered."""
114114

115115
markup = textify(
116-
testrenderer.render_response_content(oas_fragment(media_type), "200")
116+
testrenderer.render_response_example(oas_fragment(media_type), "200")
117117
)
118118
assert markup == textwrap.dedent(
119119
"""\
@@ -130,11 +130,11 @@ def test_render_response_content_example(testrenderer, oas_fragment, media_type)
130130
)
131131

132132

133-
def test_render_response_content_example_1st_from_examples(testrenderer, oas_fragment):
133+
def test_render_response_example_1st_from_examples(testrenderer, oas_fragment):
134134
"""Path response's first example is rendered."""
135135

136136
markup = textify(
137-
testrenderer.render_response_content(
137+
testrenderer.render_response_example(
138138
oas_fragment(
139139
"""
140140
application/json:
@@ -166,13 +166,11 @@ def test_render_response_content_example_1st_from_examples(testrenderer, oas_fra
166166
)
167167

168168

169-
def test_render_response_content_example_1st_from_media_type(
170-
testrenderer, oas_fragment
171-
):
169+
def test_render_response_example_1st_from_media_type(testrenderer, oas_fragment):
172170
"""Path response's example from first media type is rendered."""
173171

174172
markup = textify(
175-
testrenderer.render_response_content(
173+
testrenderer.render_response_example(
176174
oas_fragment(
177175
"""
178176
text/plain:
@@ -205,7 +203,7 @@ def test_render_response_content_example_1st_from_media_type(
205203
["example_preference_key"],
206204
[pytest.param("response-example-preference"), pytest.param("example-preference")],
207205
)
208-
def test_render_response_content_example_preference(
206+
def test_render_response_example_preference(
209207
fakestate, example_preference_key, oas_fragment
210208
):
211209
"""Path response's example from preferred media type is rendered."""
@@ -215,7 +213,7 @@ def test_render_response_content_example_preference(
215213
)
216214

217215
markup = textify(
218-
testrenderer.render_response_content(
216+
testrenderer.render_response_example(
219217
oas_fragment(
220218
"""
221219
application/json:
@@ -249,7 +247,7 @@ def test_render_response_content_example_preference(
249247
["example_preference_key"],
250248
[pytest.param("response-example-preference"), pytest.param("example-preference")],
251249
)
252-
def test_render_response_content_example_preference_complex(
250+
def test_render_response_example_preference_complex(
253251
fakestate, example_preference_key, oas_fragment
254252
):
255253
"""Path response's example from preferred media type is rendered."""
@@ -259,7 +257,7 @@ def test_render_response_content_example_preference_complex(
259257
)
260258

261259
markup = textify(
262-
testrenderer.render_response_content(
260+
testrenderer.render_response_example(
263261
oas_fragment(
264262
"""
265263
text/csv:
@@ -292,7 +290,7 @@ def test_render_response_content_example_preference_complex(
292290
)
293291

294292

295-
def test_render_response_content_example_preference_priority(fakestate, oas_fragment):
293+
def test_render_response_example_preference_priority(fakestate, oas_fragment):
296294
"""Path response's example from preferred media type is rendered."""
297295

298296
testrenderer = renderers.HttpdomainRenderer(
@@ -304,7 +302,7 @@ def test_render_response_content_example_preference_priority(fakestate, oas_frag
304302
)
305303

306304
markup = textify(
307-
testrenderer.render_response_content(
305+
testrenderer.render_response_example(
308306
oas_fragment(
309307
"""
310308
application/json:
@@ -335,7 +333,7 @@ def test_render_response_content_example_preference_priority(fakestate, oas_frag
335333

336334

337335
@responses.activate
338-
def test_render_response_content_example_external(testrenderer, oas_fragment):
336+
def test_render_response_example_external(testrenderer, oas_fragment):
339337
"""Path response's example can be retrieved from external location."""
340338

341339
responses.add(
@@ -346,7 +344,7 @@ def test_render_response_content_example_external(testrenderer, oas_fragment):
346344
)
347345

348346
markup = textify(
349-
testrenderer.render_response_content(
347+
testrenderer.render_response_example(
350348
oas_fragment(
351349
"""
352350
application/json:
@@ -371,7 +369,7 @@ def test_render_response_content_example_external(testrenderer, oas_fragment):
371369

372370

373371
@responses.activate
374-
def test_render_response_content_example_external_errored_next_example(
372+
def test_render_response_example_external_errored_next_example(
375373
testrenderer, caplog, oas_fragment
376374
):
377375
"""Path response's example fallbacks on next when external cannot be retrieved."""
@@ -381,7 +379,7 @@ def test_render_response_content_example_external_errored_next_example(
381379
)
382380

383381
markup = textify(
384-
testrenderer.render_response_content(
382+
testrenderer.render_response_example(
385383
oas_fragment(
386384
"""
387385
application/json:
@@ -408,7 +406,7 @@ def test_render_response_content_example_external_errored_next_example(
408406

409407

410408
@responses.activate
411-
def test_render_response_content_example_external_errored_next_media_type(
409+
def test_render_response_example_external_errored_next_media_type(
412410
testrenderer, oas_fragment, caplog
413411
):
414412
"""Path response's example fallbacks on next when external cannot be retrieved."""
@@ -418,7 +416,7 @@ def test_render_response_content_example_external_errored_next_media_type(
418416
)
419417

420418
markup = textify(
421-
testrenderer.render_response_content(
419+
testrenderer.render_response_example(
422420
oas_fragment(
423421
"""
424422
application/json:
@@ -444,11 +442,11 @@ def test_render_response_content_example_external_errored_next_media_type(
444442
)
445443

446444

447-
def test_render_response_content_example_content_type(testrenderer, oas_fragment):
445+
def test_render_response_example_content_type(testrenderer, oas_fragment):
448446
"""Path response's example can render something other than application/json."""
449447

450448
markup = textify(
451-
testrenderer.render_response_content(
449+
testrenderer.render_response_example(
452450
oas_fragment(
453451
"""
454452
text/csv:
@@ -473,11 +471,11 @@ def test_render_response_content_example_content_type(testrenderer, oas_fragment
473471
)
474472

475473

476-
def test_render_response_content_example_noop(testrenderer, oas_fragment):
474+
def test_render_response_example_noop(testrenderer, oas_fragment):
477475
"""Path response's example is not rendered if there's nothing to render."""
478476

479477
markup = textify(
480-
testrenderer.render_response_content(
478+
testrenderer.render_response_example(
481479
oas_fragment(
482480
"""
483481
application/json:
@@ -500,13 +498,13 @@ def test_render_response_content_example_noop(testrenderer, oas_fragment):
500498
pytest.param("422", "Unprocessable Entity", id="422"),
501499
],
502500
)
503-
def test_render_response_content_status_code(
501+
def test_render_response_status_code(
504502
testrenderer, oas_fragment, status_code, status_text
505503
):
506504
"""Path response's example is rendered with proper status code."""
507505

508506
markup = textify(
509-
testrenderer.render_response_content(
507+
testrenderer.render_response_example(
510508
oas_fragment(
511509
"""
512510
text/csv:
@@ -539,13 +537,13 @@ def test_render_response_content_status_code(
539537
pytest.param("4XX", "400", "Bad Request", id="4XX"),
540538
],
541539
)
542-
def test_render_response_content_status_code_range(
540+
def test_render_response_status_code_range(
543541
testrenderer, oas_fragment, status_range, status_code, status_text
544542
):
545543
"""Path response's example is rendered with proper status range."""
546544

547545
markup = textify(
548-
testrenderer.render_response_content(
546+
testrenderer.render_response_example(
549547
oas_fragment(
550548
"""
551549
text/csv:
@@ -578,13 +576,13 @@ def test_render_response_content_status_code_range(
578576
pytest.param("422", "Unprocessable Entity", id="422"),
579577
],
580578
)
581-
def test_render_response_content_status_code_int(
579+
def test_render_response_status_code_int(
582580
testrenderer, oas_fragment, status_code, status_text
583581
):
584582
"""Path response's example is rendered with proper status code."""
585583

586584
markup = textify(
587-
testrenderer.render_response_content(
585+
testrenderer.render_response_example(
588586
oas_fragment(
589587
"""
590588
text/csv:
@@ -609,11 +607,11 @@ def test_render_response_content_status_code_int(
609607
)
610608

611609

612-
def test_render_response_content_status_code_default(testrenderer, oas_fragment):
610+
def test_render_response_status_code_default(testrenderer, oas_fragment):
613611
"""Path response's example is rendered when default is passed."""
614612

615613
markup = textify(
616-
testrenderer.render_response_content(
614+
testrenderer.render_response_example(
617615
oas_fragment(
618616
"""
619617
text/csv:

0 commit comments

Comments
 (0)