-
Notifications
You must be signed in to change notification settings - Fork 42
fix: adjusted highlight color for multi select elements #7513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@kwhuber Nice work! I suggest retitling this issue to reflect the underlying change instead of focusing on just one result. Sometimes, users or testers create issues with very narrow titles (e.g., "Dark Mode: Selected chronostrat in dropdown for age 'Name' queries is too bright to read"), but the actual change affects all multi-select elements in the app. |
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Create a Collection Object query, add the Age field to the mapping, add the Name operator, select an item from the list
- Click away from the list and see that the item turns a very light grey color
- Verify another query with a select option in a different database (and add that example to your review)
Looks good, I tested on ojsmnh with the storage information picklist using the 'in' operator.
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
Iwantexpresso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Create a Collection Object query, add the Age field to the mapping, add the Name operator, select an item from the list
-
Click away from the list and see that the item turns a very light grey color
Verify another query with a select option in a different database (and add that example to your review) -
Verify another query with a select option in a different database (and add that example to your review)
it looks great! I tested on Geo_swiss database using "in" and the Collection Object type pick-list
|
@kwhuber could you remove all the files that are not necessary for this pr? |
acwhite211
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a commit to reverse the newline changes in the docker-compose.yml, Dockerfile, and manage.py files. 👍
Fixes #7262
This PR introduces changes to fix a styling issue with the
Selectcomponent inForm.tsx.Specifically, the class added to selected options was too light when using
'dark:bg-neutral-100', hence the following change:specify7/specifyweb/frontend/js_src/lib/components/Atoms/Form.tsx
Lines 350 to 359 in e89852b
After following the testing instructions, this was the result prior to the fix:
Following the fix and after selecting the chronostrat then clicking outside of the pick list, this is the corrected behavior:
Screen.Recording.2025-10-27.at.1.32.58.PM.mov
Checklist
self-explanatory (or properly documented)
Testing instructions
This must be tested in a Geology, Vertebrate Paleontology, or Invertebrate Paleontology discipline. I used the
uw_geo_collections_2025_09_09.sqldatabase and then the Fossil Vertebrates collection.