chore: Update golangci and fix issues it found

Author: BlakeTheAwesome

.mise.toml

@@ -1,17 +1,18 @@
 [tools]
 go = "1.24.3"
-golangci-lint = "2.1.1"
 gotestsum = "latest"
 
 [tasks.setup-vscode-symlinks]
 description = "Create VSCode symlinks for tools not automatically handled by mise-vscode"
 run = [
   "mkdir -p .vscode/mise-tools",
-  "ln -sf $(mise exec golangci-lint@2.1.1 -- which golangci-lint) .vscode/mise-tools/golangci-lint",
+  "ln -sf $(mise exec golangci-lint@2.5.0 -- which golangci-lint) .vscode/mise-tools/golangci-lint",
 ]
 
 [hooks]
 postinstall = [
+  "git submodule update --init --recursive",
+  "mise exec go@1.24.3 -- go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.5.0",
   "mise run setup-vscode-symlinks",
   "go install go.uber.org/nilaway/cmd/nilaway@8ad05f0",
 ]

validation/errors.go

@@ -37,19 +37,19 @@ func (e Error) GetColumnNumber() int {
 	return e.Node.Column
 }
 
-type valueNodeGetter interface {
+type ValueNodeGetter interface {
 	GetValueNodeOrRoot(root *yaml.Node) *yaml.Node
 }
 
-type sliceNodeGetter interface {
+type SliceNodeGetter interface {
 	GetSliceValueNodeOrRoot(index int, root *yaml.Node) *yaml.Node
 }
 
-type mapKeyNodeGetter interface {
+type MapKeyNodeGetter interface {
 	GetMapKeyNodeOrRoot(key string, root *yaml.Node) *yaml.Node
 }
 
-type mapValueNodeGetter interface {
+type MapValueNodeGetter interface {
 	GetMapValueNodeOrRoot(key string, root *yaml.Node) *yaml.Node
 }
 
@@ -64,7 +64,7 @@ type CoreModeler interface {
 	GetRootNode() *yaml.Node
 }
 
-func NewValueError(err error, core CoreModeler, node valueNodeGetter) error {
+func NewValueError(err error, core CoreModeler, node ValueNodeGetter) error {
 	rootNode := core.GetRootNode()
 
 	if rootNode == nil {
@@ -82,7 +82,7 @@ func NewValueError(err error, core CoreModeler, node valueNodeGetter) error {
 	}
 }
 
-func NewSliceError(err error, core CoreModeler, node sliceNodeGetter, index int) error {
+func NewSliceError(err error, core CoreModeler, node SliceNodeGetter, index int) error {
 	rootNode := core.GetRootNode()
 
 	if rootNode == nil {
@@ -100,7 +100,7 @@ func NewSliceError(err error, core CoreModeler, node sliceNodeGetter, index int)
 	}
 }
 
-func NewMapKeyError(err error, core CoreModeler, node mapKeyNodeGetter, key string) error {
+func NewMapKeyError(err error, core CoreModeler, node MapKeyNodeGetter, key string) error {
 	rootNode := core.GetRootNode()
 
 	if rootNode == nil {
@@ -118,7 +118,7 @@ func NewMapKeyError(err error, core CoreModeler, node mapKeyNodeGetter, key stri
 	}
 }
 
-func NewMapValueError(err error, core CoreModeler, node mapValueNodeGetter, key string) error {
+func NewMapValueError(err error, core CoreModeler, node MapValueNodeGetter, key string) error {
 	rootNode := core.GetRootNode()
 
 	if rootNode == nil {

validation/validation_test.go

@@ -230,7 +230,7 @@ func TestNewValueError_Success(t *testing.T) {
 	tests := []struct {
 		name         string
 		core         CoreModeler
-		nodeGetter   valueNodeGetter
+		nodeGetter   ValueNodeGetter
 		expectedNode *yaml.Node
 	}{
 		{
@@ -287,7 +287,7 @@ func TestNewSliceError_Success(t *testing.T) {
 	tests := []struct {
 		name         string
 		core         CoreModeler
-		nodeGetter   sliceNodeGetter
+		nodeGetter   SliceNodeGetter
 		index        int
 		expectedNode *yaml.Node
 	}{
@@ -337,7 +337,7 @@ func TestNewMapKeyError_Success(t *testing.T) {
 	tests := []struct {
 		name         string
 		core         CoreModeler
-		nodeGetter   mapKeyNodeGetter
+		nodeGetter   MapKeyNodeGetter
 		key          string
 		expectedNode *yaml.Node
 	}{
@@ -387,7 +387,7 @@ func TestNewMapValueError_Success(t *testing.T) {
 	tests := []struct {
 		name         string
 		core         CoreModeler
-		nodeGetter   mapValueNodeGetter
+		nodeGetter   MapValueNodeGetter
 		key          string
 		expectedNode *yaml.Node
 	}{