style(rubocop): Minitest safe autocorrections

Author: flavorjones

.rubocop.yml

@@ -4,6 +4,7 @@ require:
   - standard-custom
   - standard-performance
   - rubocop-performance
+  - rubocop-minitest
 
 inherit_gem:
   standard: config/base.yml
@@ -13,3 +14,72 @@ inherit_gem:
 AllCops:
   SuggestExtensions: false
   TargetRubyVersion: 3.0
+
+Minitest/AssertInDelta: # new in 0.10
+  Enabled: true
+Minitest/AssertKindOf: # new in 0.10
+  Enabled: true
+Minitest/AssertOperator: # new in 0.32
+  Enabled: true
+Minitest/AssertOutput: # new in 0.10
+  Enabled: true
+Minitest/AssertPathExists: # new in 0.10
+  Enabled: true
+Minitest/AssertPredicate: # new in 0.18
+  Enabled: true
+Minitest/AssertRaisesCompoundBody: # new in 0.21
+  Enabled: true
+Minitest/AssertRaisesWithRegexpArgument: # new in 0.22
+  Enabled: true
+Minitest/AssertSame: # new in 0.26
+  Enabled: true
+Minitest/AssertSilent: # new in 0.10
+  Enabled: true
+Minitest/AssertWithExpectedArgument: # new in 0.11
+  Enabled: true
+Minitest/AssertionInLifecycleHook: # new in 0.10
+  Enabled: true
+Minitest/DuplicateTestRun: # new in 0.19
+  Enabled: true
+Minitest/EmptyLineBeforeAssertionMethods: # new in 0.23
+  Enabled: false
+Minitest/LifecycleHooksOrder: # new in 0.28
+  Enabled: true
+Minitest/LiteralAsActualArgument: # new in 0.10
+  Enabled: true
+Minitest/MultipleAssertions: # new in 0.10
+  Enabled: true
+Minitest/NonExecutableTestMethod: # new in 0.34
+  Enabled: true
+Minitest/NonPublicTestMethod: # new in 0.27
+  Enabled: true
+Minitest/RedundantMessageArgument: # new in 0.34
+  Enabled: true
+Minitest/RefuteInDelta: # new in 0.10
+  Enabled: true
+Minitest/RefuteKindOf: # new in 0.10
+  Enabled: true
+Minitest/RefuteOperator: # new in 0.32
+  Enabled: true
+Minitest/RefutePathExists: # new in 0.10
+  Enabled: true
+Minitest/RefutePredicate: # new in 0.18
+  Enabled: true
+Minitest/RefuteSame: # new in 0.26
+  Enabled: true
+Minitest/ReturnInTestMethod: # new in 0.31
+  Enabled: true
+Minitest/SkipEnsure: # new in 0.20
+  Enabled: true
+Minitest/SkipWithoutReason: # new in 0.24
+  Enabled: true
+Minitest/TestFileName: # new in 0.26
+  Enabled: true
+Minitest/TestMethodName: # new in 0.10
+  Enabled: true
+Minitest/UnreachableAssertion: # new in 0.14
+  Enabled: true
+Minitest/UnspecifiedException: # new in 0.10
+  Enabled: true
+Minitest/UselessAssertion: # new in 0.26
+  Enabled: true

Gemfile

@@ -14,4 +14,5 @@ group :development do
 
   gem "rubocop", require: false
   gem "standardrb", require: false
+  gem "rubocop-minitest", require: false
 end

test/test_database.rb

@@ -150,16 +150,16 @@ def test_execute_batch2
         INSERT INTO items (name) VALUES ("bar");
         SELECT * FROM items;
       EOSQL
-      assert_equal return_value, [{"id" => "1", "name" => "foo"}, {"id" => "2", "name" => "bar"}]
+      assert_equal [{"id" => "1", "name" => "foo"}, {"id" => "2", "name" => "bar"}], return_value
 
       return_value = @db.execute_batch2("SELECT * FROM items;") do |result|
         result["id"] = result["id"].to_i
         result
       end
-      assert_equal return_value, [{"id" => 1, "name" => "foo"}, {"id" => 2, "name" => "bar"}]
+      assert_equal [{"id" => 1, "name" => "foo"}, {"id" => 2, "name" => "bar"}], return_value
 
       return_value = @db.execute_batch2('INSERT INTO items (name) VALUES ("oof")')
-      assert_equal return_value, []
+      assert_empty return_value
 
       return_value = @db.execute_batch2(
         'CREATE TABLE employees (id integer PRIMARY KEY AUTOINCREMENT, name string, age integer(3));
@@ -171,10 +171,10 @@ def test_execute_batch2
         result["age"] = result["age"].to_i
         result
       end
-      assert_equal return_value, [{"age" => 30}, {"age" => 40}, {"age" => 20}]
+      assert_equal [{"age" => 30}, {"age" => 40}, {"age" => 20}], return_value
 
       return_value = @db.execute_batch2("SELECT name FROM employees")
-      assert_equal return_value, [{"name" => nil}, {"name" => nil}, {"name" => nil}]
+      assert_equal [{"name" => nil}, {"name" => nil}, {"name" => nil}], return_value
 
       @db.results_as_hash = false
       return_value = @db.execute_batch2(
@@ -188,7 +188,7 @@ def test_execute_batch2
         end
         result
       end
-      assert_equal return_value, [[1, 50], [2, 60]]
+      assert_equal [[1, 50], [2, 60]], return_value
 
       assert_raises(RuntimeError) do
         # "names" is not a valid column
@@ -246,7 +246,7 @@ def test_new_with_options
     def test_close
       db = SQLite3::Database.new(":memory:")
       db.close
-      assert db.closed?
+      assert_predicate db, :closed?
     end
 
     def test_block_closes_self
@@ -255,7 +255,7 @@ def test_block_closes_self
         thing = db
         assert !thing.closed?
       end
-      assert thing.closed?
+      assert_predicate thing, :closed?
     end
 
     def test_open_with_block_closes_self
@@ -264,7 +264,7 @@ def test_open_with_block_closes_self
         thing = db
         assert !thing.closed?
       end
-      assert thing.closed?
+      assert_predicate thing, :closed?
     end
 
     def test_block_closes_self_even_raised
@@ -276,7 +276,7 @@ def test_block_closes_self_even_raised
         end
       rescue
       end
-      assert thing.closed?
+      assert_predicate thing, :closed?
     end
 
     def test_open_with_block_closes_self_even_raised
@@ -288,7 +288,7 @@ def test_open_with_block_closes_self_even_raised
         end
       rescue
       end
-      assert thing.closed?
+      assert_predicate thing, :closed?
     end
 
     def test_prepare

test/test_database_flags.rb

@@ -28,7 +28,7 @@ def test_open_database_flags_constants
       if SQLite3::SQLITE_VERSION_NUMBER > 3007013
         defined_to_date += [:MEMORY]
       end
-      assert defined_to_date.sort == SQLite3::Constants::Open.constants.sort
+      assert_equal defined_to_date.sort, SQLite3::Constants::Open.constants.sort
     end
 
     def test_open_database_flags_conflicts_with_readonly
@@ -45,7 +45,7 @@ def test_open_database_flags_conflicts_with_readwrite
 
     def test_open_database_readonly_flags
       @db = SQLite3::Database.new("test-flags.db", flags: SQLite3::Constants::Open::READONLY)
-      assert @db.readonly?
+      assert_predicate @db, :readonly?
     end
 
     def test_open_database_readwrite_flags
@@ -81,15 +81,15 @@ def test_open_database_create_flags
         db.execute("CREATE TABLE foos (id integer)")
         db.execute("INSERT INTO foos (id) VALUES (12)")
       end
-      assert File.exist?("test-flags.db")
+      assert_path_exists "test-flags.db"
     end
 
     def test_open_database_exotic_flags
       flags = SQLite3::Constants::Open::READWRITE | SQLite3::Constants::Open::CREATE
       exotic_flags = SQLite3::Constants::Open::NOMUTEX | SQLite3::Constants::Open::TEMP_DB
       @db = SQLite3::Database.new("test-flags.db", flags: flags | exotic_flags)
       @db.execute("INSERT INTO foos (id) VALUES (12)")
-      assert @db.changes == 1
+      assert_equal 1, @db.changes
     end
   end
 end

test/test_database_readonly.rb

@@ -16,7 +16,7 @@ def teardown
 
     def test_open_readonly_database
       @db = SQLite3::Database.new("test-readonly.db", readonly: true)
-      assert @db.readonly?
+      assert_predicate @db, :readonly?
     end
 
     def test_open_readonly_not_exists_database

test/test_database_readwrite.rb

@@ -35,7 +35,7 @@ def test_open_readwrite_not_exists_database
     def test_insert_readwrite_database
       @db = SQLite3::Database.new("test-readwrite.db", readwrite: true)
       @db.execute("INSERT INTO foos (id) VALUES (12)")
-      assert @db.changes == 1
+      assert_equal 1, @db.changes
     end
   end
 end

test/test_integration.rb

@@ -98,7 +98,7 @@ def test_authorizer_error
   def test_authorizer_silent
     @db.authorizer { |type, a, b, c, d| 2 }
     rows = @db.execute "select * from foo"
-    assert rows.empty?
+    assert_empty rows
   end
 
   def test_prepare_invalid_syntax
@@ -121,22 +121,22 @@ def test_prepare_invalid_table
 
   def test_prepare_no_block
     stmt = @db.prepare "select * from foo"
-    assert stmt.respond_to?(:execute)
+    assert_respond_to stmt, :execute
     stmt.close
   end
 
   def test_prepare_with_block
     called = false
     @db.prepare "select * from foo" do |stmt|
       called = true
-      assert stmt.respond_to?(:execute)
+      assert_respond_to stmt, :execute
     end
     assert called
   end
 
   def test_execute_no_block_no_bind_no_match
     rows = @db.execute("select * from foo where a > 100")
-    assert rows.empty?
+    assert_empty rows
   end
 
   def test_execute_with_block_no_bind_no_match
@@ -149,7 +149,7 @@ def test_execute_with_block_no_bind_no_match
 
   def test_execute_no_block_with_bind_no_match
     rows = @db.execute("select * from foo where a > ?", 100)
-    assert rows.empty?
+    assert_empty rows
   end
 
   def test_execute_with_block_with_bind_no_match
@@ -188,7 +188,7 @@ def test_execute_with_block_with_bind_with_match
 
   def test_execute2_no_block_no_bind_no_match
     columns, *rows = @db.execute2("select * from foo where a > 100")
-    assert rows.empty?
+    assert_empty rows
     assert_equal ["a", "b"], columns
   end
 
@@ -203,7 +203,7 @@ def test_execute2_with_block_no_bind_no_match
 
   def test_execute2_no_block_with_bind_no_match
     columns, *rows = @db.execute2("select * from foo where a > ?", 100)
-    assert rows.empty?
+    assert_empty rows
     assert_equal ["a", "b"], columns
   end
 
@@ -285,7 +285,7 @@ def test_query_with_block_no_bind_no_match
       assert_nil result.next
       r = result
     end
-    assert r.closed?
+    assert_predicate r, :closed?
   end
 
   def test_query_no_block_with_bind_no_match
@@ -300,7 +300,7 @@ def test_query_with_block_with_bind_no_match
       assert_nil result.next
       r = result
     end
-    assert r.closed?
+    assert_predicate r, :closed?
   end
 
   def test_query_no_block_no_bind_with_match
@@ -317,7 +317,7 @@ def test_query_with_block_no_bind_with_match
       assert_nil result.next
       r = result
     end
-    assert r.closed?
+    assert_predicate r, :closed?
   end
 
   def test_query_no_block_with_bind_with_match
@@ -334,7 +334,7 @@ def test_query_with_block_with_bind_with_match
       assert_nil result.next
       r = result
     end
-    assert r.closed?
+    assert_predicate r, :closed?
   end
 
   def test_get_first_row_no_bind_no_match
@@ -464,7 +464,7 @@ def test_transaction_commit_in_block
   def test_transaction_active
     assert !@db.transaction_active?
     @db.transaction
-    assert @db.transaction_active?
+    assert_predicate @db, :transaction_active?
     @db.commit
     assert !@db.transaction_active?
   end
@@ -473,7 +473,7 @@ def test_transaction_implicit_rollback
     assert !@db.transaction_active?
     @db.transaction
     @db.execute("create table bar (x CHECK(1 = 0))")
-    assert @db.transaction_active?
+    assert_predicate @db, :transaction_active?
     assert_raises(SQLite3::ConstraintException) do
       @db.execute("insert or rollback into bar (x) VALUES ('x')")
     end

test/test_integration_open_close.rb

@@ -3,7 +3,7 @@
 class IntegrationOpenCloseTestCase < SQLite3::TestCase
   def test_create_close
     db = SQLite3::Database.new("test-create.db")
-    assert File.exist?("test-create.db")
+    assert_path_exists "test-create.db"
     assert_nothing_raised { db.close }
   ensure
     begin
@@ -15,7 +15,7 @@ def test_create_close
 
   def test_open_close
     File.open("test-open.db", "w") { |f| }
-    assert File.exist?("test-open.db")
+    assert_path_exists "test-open.db"
     db = SQLite3::Database.new("test-open.db")
     assert_nothing_raised { db.close }
   ensure

test/test_integration_pending.rb

@@ -72,6 +72,6 @@ def test_busy_timeout
     busy.unlock
     t.join
 
-    assert time.real * 1000 >= 1000
+    assert_operator time.real * 1000, :>=, 1000
   end
 end