Skip to content

Commit 40e7b29

Browse files
committed
remove: SQLite3::VersionProxy
deprecated in v1.3.2 (circa 2010)
1 parent dc4c05c commit 40e7b29

File tree

4 files changed

+3
-32
lines changed

4 files changed

+3
-32
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Update `/dependencies.yml` to reflect:
2626
A quick checklist:
2727

2828
- [ ] make sure CI is green!
29-
- [ ] update `CHANGELOG.md` and `lib/sqlite3/version.rb` including `VersionProxy::{MINOR,TINY}`
29+
- [ ] update `CHANGELOG.md` and `lib/sqlite3/version.rb`
3030
- [ ] run `bin/build-gems` and make sure it completes and all the tests pass
3131
- [ ] create a git tag using a format that matches the pattern `v\d+\.\d+\.\d+`, e.g. `v1.3.13`
3232
- [ ] `git push && git push --tags`

lib/sqlite3/version.rb

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,3 @@
11
module SQLite3
2-
32
VERSION = "2.0.0.dev"
4-
5-
module VersionProxy
6-
MAJOR = 2
7-
MINOR = 0
8-
TINY = 0
9-
BUILD = "dev"
10-
11-
STRING = [ MAJOR, MINOR, TINY, BUILD ].compact.join( "." )
12-
13-
VERSION = ::SQLite3::VERSION
14-
end
15-
16-
def self.const_missing(name)
17-
return super unless name == :Version
18-
warn(<<-eowarn) if $VERBOSE
19-
#{caller[0]}: `SQLite::Version` will be removed in sqlite3-ruby version 2.0.0
20-
eowarn
21-
VersionProxy
22-
end
233
end

test/helper.rb

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,11 @@
55
$VERBOSE = nil
66
end
77

8-
puts "info: sqlite3-ruby version: #{SQLite3::VERSION}/#{SQLite3::VersionProxy::STRING}"
9-
puts "info: sqlite3 version: #{SQLite3::SQLITE_VERSION}/#{SQLite3::SQLITE_LOADED_VERSION}"
8+
puts "info: gem version: #{SQLite3::VERSION}"
9+
puts "info: sqlite version: #{SQLite3::SQLITE_VERSION}/#{SQLite3::SQLITE_LOADED_VERSION}"
1010
puts "info: sqlcipher?: #{SQLite3.sqlcipher?}"
1111
puts "info: threadsafe?: #{SQLite3.threadsafe?}"
1212

13-
unless RUBY_VERSION >= "1.9"
14-
require 'iconv'
15-
end
16-
1713
module SQLite3
1814
class TestCase < Minitest::Test
1915
alias :assert_not_equal :refute_equal

test/test_sqlite3.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,6 @@ def test_threadsafe?
1818
end
1919
end
2020

21-
def test_version_strings
22-
skip if SQLite3::VERSION.include?("test") # see set-version-to-timestamp rake task
23-
assert_equal(SQLite3::VERSION, SQLite3::VersionProxy::STRING)
24-
end
25-
2621
def test_compiled_version_and_loaded_version
2722
assert_equal(SQLite3::SQLITE_VERSION, SQLite3::SQLITE_LOADED_VERSION)
2823
end

0 commit comments

Comments
 (0)