Prevent NtripServer from disabling settings.enableNtripServer

PaulZC · PaulZC · commit de3af283ba00 · 2024-06-10T16:45:49.000+01:00
diff --git a/Firmware/RTK_Surveyor/NtripServer.ino b/Firmware/RTK_Surveyor/NtripServer.ino
@@ -561,7 +561,11 @@ void ntripServerStop(int serverIndex, bool shutdown)
                 enabled = true;
                 break;
             }
-        settings.enableNtripServer = enabled;
+        //settings.enableNtripServer = enabled;
+        // ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Why? Setting settings.enableNtripServer to false means
+        // the server connections cannot be (re)started without setting settings.enableNtripServer back
+        // to true via the menu / web config... Was the intent to close the network connection when all
+        // servers have disconnected?
     }
     else
     {

Original file line number	Diff line number	Diff line change
`@@ -561,7 +561,11 @@ void ntripServerStop(int serverIndex, bool shutdown)`
`561`	`561`	`enabled = true;`
`562`	`562`	`break;`
`563`	`563`	`}`
`564`		`- settings.enableNtripServer = enabled;`
	`564`	`+ //settings.enableNtripServer = enabled;`
	`565`	`+ // ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Why? Setting settings.enableNtripServer to false means`
	`566`	`+ // the server connections cannot be (re)started without setting settings.enableNtripServer back`
	`567`	`+ // to true via the menu / web config... Was the intent to close the network connection when all`
	`568`	`+ // servers have disconnected?`
`565`	`569`	`}`
`566`	`570`	`else`
`567`	`571`	`{`