Fix stack overflow

Implement settingsToDefaults(). Reduce large arrays on stack.

Author: nseidle

Firmware/RTK_Surveyor/Form.ino

@@ -255,15 +255,19 @@ static void handleFirmwareFileUpload(AsyncWebServerRequest *request, String file
 //Events triggered by web sockets
 #ifdef COMPILE_WIFI
 #ifdef COMPILE_AP
+char *settingsCSV; //Push large array onto heap
+
 void onWsEvent(AsyncWebSocket * server, AsyncWebSocketClient * client, AwsEventType type, void * arg, uint8_t *data, size_t len)
 {
   if (type == WS_EVT_CONNECT) {
-    char settingsCSV[AP_CONFIG_SETTING_SIZE];
-    memset(settingsCSV, 0, sizeof(settingsCSV));
+    settingsCSV = (char*)malloc(AP_CONFIG_SETTING_SIZE);
+    memset(settingsCSV, 0, AP_CONFIG_SETTING_SIZE); //Clear any garbage from settings array
+
     createSettingsString(settingsCSV);
     log_d("Sending command: %s\n\r", settingsCSV);
     client->text(settingsCSV);
     wifiSetState(WIFI_CONNECTED);
+    free(settingsCSV);
   }
   else if (type == WS_EVT_DISCONNECT) {
     log_d("Websocket client disconnected");
@@ -272,6 +276,7 @@ void onWsEvent(AsyncWebSocket * server, AsyncWebSocketClient * client, AwsEventT
   else if (type == WS_EVT_DATA) {
     for (int i = 0; i < len; i++) {
       incomingSettings[incomingSettingsSpot++] = data[i];
+      incomingSettingsSpot %= AP_CONFIG_SETTING_SIZE;
     }
     timeSinceLastIncomingSetting = millis();
   }
@@ -675,9 +680,7 @@ void updateSettingWithValue(const char *settingName, const char* settingValueStr
   }
   else if (strcmp(settingName, "resetProfile") == 0)
   {
-    //Overwrite our current settings with defaults
-    Settings tempSettings;
-    settings = tempSettings;
+    settingsToDefaults(); //Overwrite our current settings with defaults
 
     recordSystemSettings(); //Overwrite profile file and NVM with these settings
 

Firmware/RTK_Surveyor/States.ino

@@ -606,6 +606,7 @@ void updateSystemState()
         break;
       case (STATE_WIFI_CONFIG):
         {
+
           if (incomingSettingsSpot > 0)
           {
             //Allow for 750ms before we parse buffer for all data to arrive

Firmware/RTK_Surveyor/System.ino

@@ -590,3 +590,9 @@ void createNMEASentence(customNmeaType_e textID, char *nmeaMessage, char *textMe
 
   sprintf(nmeaMessage, "%s%02X", nmeaTxt, CRC);
 }
+
+//Reset settings struct to default initializers 
+void settingsToDefaults()
+{
+  settings = Settings(); //https://stackoverflow.com/questions/15183429/c-completely-erase-or-reset-all-values-of-a-struct
+}

Firmware/RTK_Surveyor/WiFi.ino

@@ -115,7 +115,7 @@ void wifiPeriodicallyDisplayIpAddress()
 }
 
 //Update the state of the WiFi state machine
-void wifiSetState (byte newState)
+void wifiSetState(byte newState)
 {
   if (wifiState == newState)
     Serial.print("*");

Firmware/RTK_Surveyor/menuMain.ino

@@ -186,9 +186,7 @@ void menuUserProfiles()
       byte bContinue = getByteChoice(menuTimeout);
       if (bContinue == 'y')
       {
-        //Overwrite our current settings with defaults
-        Settings tempSettings;
-        settings = tempSettings;
+        settingsToDefaults(); //Overwrite our current settings with defaults
 
         recordSystemSettings(); //Overwrite profile file and NVM with these settings
 
@@ -229,8 +227,7 @@ void menuUserProfiles()
         //If this is an empty/new profile slot, overwrite our current settings with defaults
         if (responseLFS == false && responseSD == false)
         {
-          Settings tempSettings;
-          settings = tempSettings;
+          settingsToDefaults();
         }
 
         //Get bitmask of active profiles
@@ -281,10 +278,7 @@ void changeProfileNumber(byte newProfileNumber)
   if (responseLFS == false && responseSD == false)
   {
     Serial.println("Default the settings");
-    //Create a temporary settings struc on the heap (not the stack because it is ~4500 bytes)
-    Settings *tempSettings = new Settings;
-    settings = *tempSettings;
-    delete tempSettings;
+    settingsToDefaults();
   }
 }