Remove redundant log_d's. Remove redundant AT_POWER_ON's

Author: PaulZC

Firmware/RTK_Surveyor/Begin.ino

@@ -33,9 +33,10 @@ void identifyBoard()
   }
 }
 
+//Setup any essential power pins
+//E.g. turn on power for the display before beginDisplay
 void initializePowerPins()
 {
-  //Setup any essential power pins
 #ifdef COMPILE_SD_MMC
   if (productVariant == REFERENCE_STATION)
   {

Firmware/RTK_Surveyor/RTK_Surveyor.ino

@@ -32,8 +32,6 @@
 #define COMPILE_L_BAND //Comment out to remove L-Band functionality
 #define COMPILE_SD_MMC //Comment out to remove REFERENCE_STATION microSD SD_MMC support
 #define ENABLE_DEVELOPER //Uncomment this line to enable special developer modes (don't check power button at startup)
-//#define FACTORY_RESET_AT_POWER_ON //Uncomment this line to perform a factory reset at every power-on. Needs ENABLE_DEVELOPER
-//#define ERASE_PROFILES_AT_POWER_ON //Uncomment this line to erase _all_ profiles at power-on. Needs FACTORY_RESET_ON_POWER_ON
 //#define REF_STN_GNSS_DEBUG //Uncomment this line to output GNSS library debug messages on serialGNSS. Ref Stn only. Needs ENABLE_DEVELOPER
 
 //Define the RTK board identifier:
@@ -623,69 +621,44 @@ void setup()
   Serial.begin(115200); //UART0 for programming and debugging
 
   identifyBoard(); //Determine what hardware platform we are running on
-  log_d("identifyBoard complete");
 
   initializePowerPins(); //Initialize any essential power pins - e.g. enable power for the Display
-  log_d("initializePowerPins complete");
 
   beginI2C();
-  log_d("beginI2C complete");
 
   beginDisplay(); //Start display to be able to display any errors
-  log_d("beginDisplay complete");
 
   beginGNSS(); //Connect to GNSS to get module type
-  log_d("beginGNSS complete");
 
   beginFS(); //Start file system for settings
-  log_d("beginFS complete");
 
   beginBoard(); //Now finish settup up the board and check the on button
-  log_d("beginBoard complete");
 
   displaySplash(); //Display the RTK product name and firmware version
-  log_d("displaySplash complete");
 
   beginLEDs(); //LED and PWM setup
-  log_d("beginLEDs complete");
 
   beginSD(); //Test if SD is present
-  log_d("beginSD complete");
-
-#if defined(ENABLE_DEVELOPER) && defined(FACTORY_RESET_AT_POWER_ON)
-  if (esp_reset_reason() == ESP_RST_POWERON) //Reset now that beginSD has been called and online.microSD will be valid
-    factoryReset();
-#endif
 
   loadSettings(); //Attempt to load settings after SD is started so we can read the settings file if available
-  log_d("loadSettings complete");
 
   beginIdleTasks(); //Enable processor load calculations
-  log_d("beginIdleTasks complete");
 
   beginUART2(); //Start UART2 on core 0, used to receive serial from ZED and pass out over SPP
-  log_d("beginUART2 complete");
 
   beginFuelGauge(); //Configure battery fuel guage monitor
-  log_d("beginFuelGauge complete");
 
   configureGNSS(); //Configure ZED module
-  log_d("configureGNSS complete");
 
   beginAccelerometer();
-  log_d("beginAccelerometer complete");
 
   beginLBand();
-  log_d("beginLBand complete");
 
   beginExternalTriggers(); //Configure the time pulse output and TM2 input
-  log_d("beginExternalTriggers complete");
 
   beginSystemState(); //Determine initial system state. Start task for button monitoring.
-  log_d("beginSystemState complete");
 
   updateRTC(); //The GNSS likely has time/date. Update ESP32 RTC to match. Needed for PointPerfect key expiration.
-  log_d("updateRTC complete");
 
   Serial.flush(); //Complete any previous prints
 

Firmware/RTK_Surveyor/System.ino

@@ -156,24 +156,18 @@ bool configureUbloxModule()
 
   if (response == false)
     systemPrintln("Module failed config block 0");
-  else
-    log_d("Module config block 0 complete");
   response = true; //Reset
 
   //Enable the constellations the user has set
   response &= setConstellations(true); //19 messages. Send newCfg or sendCfg with value set
   if (response == false)
     systemPrintln("Module failed config block 1");
-  else
-    log_d("Module config block 1 complete");
   response = true; //Reset
 
   //Make sure the appropriate messages are enabled
   response &= setMessages(); //73 messages. Does a complete open/closed val set
   if (response == false)
     systemPrintln("Module failed config block 2");
-  else
-    log_d("Module config block 2 complete");
   response = true; //Reset
 
   //Disable NMEA messages on all but UART1
@@ -210,8 +204,6 @@ bool configureUbloxModule()
 
   if (response == false)
     systemPrintln("Module failed config block 3");
-  else
-    log_d("Module config block 3 complete");
 
   if (zedModuleType == PLATFORM_F9R)
   {
@@ -564,11 +556,8 @@ bool setMessages()
     while (((x % 43) < 42) && (x < MAX_UBX_MSG)); //Limit 1st batch to 42. Batches after that will be (up to) 43 in size. It's a HHGTTG thing.
 
     response &= theGNSS.sendCfgValset();
-    log_d("sent Valset for message %d: %s", x, response ? "OK" : "ERROR");
   }
 
-  log_d("message config complete");
-
   //For SPI GNSS products, we need to add each message to the GNSS Library logging buffer
   //to mimic UART1
   if (USE_SPI_GNSS)
@@ -596,11 +585,7 @@ bool setMessages()
     }
 
     theGNSS.setRTCMLoggingMask(logRTCMMessages);
-    log_d("setRTCMLoggingMask 0x%X", logRTCMMessages);
     theGNSS.setNMEALoggingMask(logNMEAMessages);
-    log_d("setNMEALoggingMask 0x%X", logNMEAMessages);
-
-    log_d("logging config complete");
   }
 
   return (response);
@@ -626,11 +611,8 @@ bool setMessagesUSB()
     while (((x % 43) < 42) && (x < MAX_UBX_MSG)); //Limit 1st batch to 42. Batches after that will be (up to) 43 in size. It's a HHGTTG thing.
 
     response &= theGNSS.sendCfgValset();
-    log_d("sent Valset for message %d", x);
   }
 
-  log_d("setMessagesUSB complete");
-
   return (response);
 }
 

Firmware/RTK_Surveyor/menuMain.ino

@@ -334,19 +334,6 @@ void factoryReset()
 
         sd->remove(stationCoordinateECEFFileName); //Remove station files
         sd->remove(stationCoordinateGeodeticFileName);
-
-#if defined(ENABLE_DEVELOPER) && defined(FACTORY_RESET_AT_POWER_ON) && defined(ERASE_PROFILES_AT_POWER_ON)
-        for (int x = 0 ; x < MAX_PROFILE_COUNT ; x++)
-        {
-          char fileName[56];
-          snprintf(fileName, sizeof(fileName), "/%s_Settings_%d.txt", platformFilePrefix, x);
-          if (sd->exists(fileName))
-          {
-            log_d("Removing %s from SD", fileName);
-            sd->remove(fileName);          
-          }
-        }
-#endif
       }
 #ifdef COMPILE_SD_MMC
       else
@@ -355,19 +342,6 @@ void factoryReset()
 
         SD_MMC.remove(stationCoordinateECEFFileName); //Remove station files
         SD_MMC.remove(stationCoordinateGeodeticFileName);
-
-#if defined(ENABLE_DEVELOPER) && defined(FACTORY_RESET_AT_POWER_ON) && defined(ERASE_PROFILES_AT_POWER_ON)
-        for (int x = 0 ; x < MAX_PROFILE_COUNT ; x++)
-        {
-          char fileName[56];
-          snprintf(fileName, sizeof(fileName), "/%s_Settings_%d.txt", platformFilePrefix, x);
-          if (SD_MMC.exists(fileName))
-          {
-            log_d("Removing %s from SD", fileName);
-            SD_MMC.remove(fileName);
-          }
-        }
-#endif
       }
 #endif