Bug fixes for ESP32 core v2.0.4

The new core settings are a blessing and a curse: many bugs discovered and fixed.

Author: nseidle

Firmware/RTK_Surveyor/Form.ino

@@ -455,7 +455,7 @@ void createSettingsString(char* settingsCSV)
   stringRecord(settingsCSV, "antennaReferencePoint", settings.antennaReferencePoint, 1);
 
   //Radio / ESP-Now settings
-  char radioMAC[15];   //Send radio MAC
+  char radioMAC[18];   //Send radio MAC
   sprintf(radioMAC, "%02X:%02X:%02X:%02X:%02X:%02X",
           wifiMACAddress[0],
           wifiMACAddress[1],

Firmware/RTK_Surveyor/NVM.ino

@@ -282,7 +282,7 @@ void recordSystemSettingsToFile(File * settingsFile)
   settingsFile->printf("%s=%d\n\r", "enableNmeaServer", settings.enableNmeaServer);
   settingsFile->printf("%s=%d\n\r", "espnowBroadcast", settings.espnowBroadcast);
   settingsFile->printf("%s=%d\n\r", "antennaHeight", settings.antennaHeight);
-  settingsFile->printf("%s=%d\n\r", "antennaReferencePoint", settings.antennaReferencePoint);
+  settingsFile->printf("%s=%0.2f\n\r", "antennaReferencePoint", settings.antennaReferencePoint);
 
   //Record constellation settings
   for (int x = 0 ; x < MAX_CONSTELLATIONS ; x++)

Firmware/RTK_Surveyor/NtripClient.ino

@@ -168,7 +168,7 @@ bool ntripClientConnectLimitReached()
 
   //Retry the connection a few times
   bool limitReached = false;
-  if (ntripClientConnectionAttempts++ >= MAX_NTRIP_CLIENT_CONNECTION_ATTEMPTS);
+  if (ntripClientConnectionAttempts++ >= MAX_NTRIP_CLIENT_CONNECTION_ATTEMPTS) limitReached = true;
 
   if (limitReached == false)
   {
@@ -354,7 +354,7 @@ void ntripClientUpdate()
           if (millis() - ntripClientTimeoutPrint > 1000)
           {
             ntripClientTimeoutPrint = millis();
-            Serial.printf("NTRIP Client connection timeout wait: %d of %d seconds \n\r",
+            Serial.printf("NTRIP Client connection timeout wait: %ld of %d seconds \n\r",
                           (millis() - ntripClientLastConnectionAttempt) / 1000,
                           ntripClientConnectionAttemptTimeout / 1000
                          );

Firmware/RTK_Surveyor/NtripServer.ino

@@ -368,7 +368,7 @@ void ntripServerUpdate()
           if (millis() - ntripServerTimeoutPrint > 1000)
           {
             ntripServerTimeoutPrint = millis();
-            Serial.printf("NTRIP Server connection timeout wait: %d of %d seconds \n\r",
+            Serial.printf("NTRIP Server connection timeout wait: %ld of %d seconds \n\r",
                           (millis() - ntripServerLastConnectionAttempt) / 1000,
                           ntripServerConnectionAttemptTimeout / 1000
                          );

Firmware/RTK_Surveyor/WiFi.ino

@@ -216,7 +216,7 @@ void wifiNmeaData(uint8_t * data, uint16_t length)
 {
 #ifdef COMPILE_WIFI
   static IPAddress ipAddress[WIFI_MAX_NMEA_CLIENTS];
-  int index;
+  int index = 0;
   static uint32_t lastNmeaConnectAttempt;
 
   if (online.nmeaClient)
@@ -234,7 +234,7 @@ void wifiNmeaData(uint8_t * data, uint16_t length)
       }
       if (wifiNmeaClient[0].connect(ipAddress[0], WIFI_NMEA_TCP_PORT))
       {
-        online.nmeaClient;
+        online.nmeaClient = true;
         Serial.print("NMEA client connected to ");
         Serial.println(ipAddress[0]);
         wifiNmeaConnected |= 1 << index;
@@ -324,7 +324,6 @@ bool wifiNmeaTcpServerActive()
 void wifiStart(char* ssid, char* pw)
 {
 #ifdef COMPILE_WIFI
-  bool restartESPNow = false;
 
   if ((wifiState == WIFI_OFF) || (wifiState == WIFI_ON))
   {