Nicer IP Address display

Author: PaulZC

Firmware/RTK_Everywhere/Display.ino

@@ -1767,36 +1767,46 @@ void paintConnectingToNtripCaster()
     printTextwithKerning("Connecting", textX, textY, textKerning);
 }
 
-// Scroll through IP address. Wipe with spaces both ends.
+// Shuttle through IP address
 void paintIPAddress()
 {
-    char ipAddress[32];
-    snprintf(ipAddress, sizeof(ipAddress), "       %d.%d.%d.%d       ",
+    char ipAddress[16];
+    snprintf(ipAddress, sizeof(ipAddress), "%d.%d.%d.%d",
 #ifdef COMPILE_ETHERNET
              ETH.localIP()[0], ETH.localIP()[1], ETH.localIP()[2], ETH.localIP()[3]);
 #else  // COMPILE_ETHERNET
              0, 0, 0, 0);
 #endif // COMPILE_ETHERNET
 
-    static uint8_t ipAddressPosition = 0;
-
-    // Check if IP address is all single digits and can be printed without scrolling
-    if (strlen(ipAddress) <= 21)
-        ipAddressPosition = 7;
-
-    // Print seven characters of IP address
-    char printThis[9];
-    snprintf(printThis, sizeof(printThis), "%c%c%c%c%c%c%c", ipAddress[ipAddressPosition + 0],
-             ipAddress[ipAddressPosition + 1], ipAddress[ipAddressPosition + 2], ipAddress[ipAddressPosition + 3],
-             ipAddress[ipAddressPosition + 4], ipAddress[ipAddressPosition + 5], ipAddress[ipAddressPosition + 6]);
-
     oled->setFont(QW_FONT_5X7); // Set font to smallest
     oled->setCursor(0, 3);
-    oled->print(printThis);
 
-    ipAddressPosition++;                       // Increment the print position
-    if (ipAddress[ipAddressPosition + 7] == 0) // Wrap
-        ipAddressPosition = 0;
+    // If we can print the full IP address without shuttling
+    if (strlen(ipAddress) <= 7)
+    {
+        oled->print(ipAddress);
+    }
+    else
+    {
+        // Print as many characters as we can. Shuttle back and forth to display all.
+        static int startPos = 0;
+        char printThis[7 + 1];
+        int extras = strlen(ipAddress) - 7;
+        int shuttle[(2 * extras) + 2]; // Wait for a double state at each end
+        shuttle[0] = 0;
+        int x;
+        for (x = 0; x <= extras; x++)
+            shuttle[x + 1] = x;
+        shuttle[extras + 2] = extras;
+        x += 2;
+        for (int y = extras - 1; y > 0; y--)
+            shuttle[x++] = y;
+        if (startPos >= (2 * extras) + 2)
+            startPos = 0;
+        snprintf(printThis, sizeof(printThis), &ipAddress[shuttle[startPos]]);
+        startPos++;
+        oled->print(printThis);
+    }
 }
 
 void paintMACAddress4digit(uint8_t xPos, uint8_t yPos)