Remove faulty SdFile nullptr checks

Fix #694. SdFile creates a nullptr instance. Testing against the instance for nullptr returns false positive.

Author: nseidle

Firmware/RTK_Everywhere/Developer.ino

@@ -175,6 +175,7 @@ void webServerStop() {}
 void webServerUpdate()  {}
 void webServerVerifyTables() {}
 void wifiSettingsClone() {}
+bool webServerIsRunning() {return false;}
 
 #endif  // COMPILE_AP
 

Firmware/RTK_Everywhere/NTP.ino

@@ -914,7 +914,7 @@ void ntpServerUpdate()
 
                         if (ntpFileExists)
                         {
-                            if (ntpFile && ntpFile.open(fileName, O_APPEND | O_WRITE))
+                            if (ntpFile.open(fileName, O_APPEND | O_WRITE))
                             {
                                 fileOpen = true;
                                 sdUpdateFileCreateTimestamp(&ntpFile);

Firmware/RTK_Everywhere/menuBase.ino

@@ -637,14 +637,9 @@ void recordLineToSD(const char *fileName, const char *lineData)
             gotSemaphore = true;
 
             SdFile file;
-            if (!file)
-            {
-                systemPrintln("ERROR - Failed to allocate file");
-                break;
-            }
             if (file.open(fileName, O_CREAT | O_APPEND | O_WRITE) == false)
             {
-                log_d("File %s not found", fileName);
+                systemPrintf("recordLineToSD: Failed to modify %s\n\r", fileName);
                 break;
             }
 

Firmware/RTK_Everywhere/menuFirmware.ino

@@ -370,11 +370,6 @@ void microSDUpdateFirmware(const char *firmwareFileName)
 
     // Verify that the SdFile object can be allocated
     SdFile firmwareFile;
-    if (!firmwareFile)
-    {
-        systemPrintln("ERROR - Failed to allocate firmwareFile");
-        return;
-    }
 
     // Verify that the firmware file can be opened
     if (!firmwareFile.open(firmwareFileName, O_READ))