Skip to content

Commit a5ee6d8

Browse files
committed
moved to bool status return for example 9
1 parent 5346e81 commit a5ee6d8

File tree

3 files changed

+21
-11
lines changed

3 files changed

+21
-11
lines changed

examples/Example_09_FirmwareVersion/Example_09_FirmwareVersion.ino

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ QwiicBuzzer buzzer;
2626
uint8_t firmwareVersionMajor;
2727
uint8_t firmwareVersionMinor;
2828

29-
sfeTkError_t err; // used for checking for errors
29+
bool err; // used for checking for errors
3030

3131
void setup() {
3232
Serial.begin(115200);
@@ -43,7 +43,7 @@ void setup() {
4343
err = buzzer.firmwareVersionMajor(firmwareVersionMajor);
4444

4545
// Check whether the firmware read was successful
46-
if (err != kSTkErrOk)
46+
if (err == false)
4747
{
4848
Serial.println("Could not read firmware version Major. Freezing.");
4949
while (1);
@@ -52,7 +52,7 @@ void setup() {
5252
err = buzzer.firmwareVersionMinor(firmwareVersionMinor);
5353

5454
// Check whether the firmware read was successful
55-
if (err != kSTkErrOk)
55+
if (err == false)
5656
{
5757
Serial.println("Could not read firmware version Minor. Freezing.");
5858
while (1);

src/sfeQwiicBuzzer.cpp

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,24 @@ sfeTkError_t sfeQwiicBuzzer::deviceId(uint8_t &deviceId)
6363
return _theBus->readRegisterByte(kSfeQwiicBuzzerRegId, deviceId);
6464
}
6565

66-
sfeTkError_t sfeQwiicBuzzer::firmwareVersionMajor(uint8_t &versionMajor)
66+
bool sfeQwiicBuzzer::firmwareVersionMajor(uint8_t &versionMajor)
6767
{
68-
return _theBus->readRegisterByte(kSfeQwiicBuzzerRegFirmwareMajor, versionMajor);
68+
sfeTkError_t err;
69+
err = _theBus->readRegisterByte(kSfeQwiicBuzzerRegFirmwareMajor, versionMajor);
70+
if (err == kSTkErrOk)
71+
return true;
72+
else
73+
return false;
6974
}
7075

71-
sfeTkError_t sfeQwiicBuzzer::firmwareVersionMinor(uint8_t &versionMinor)
76+
bool sfeQwiicBuzzer::firmwareVersionMinor(uint8_t &versionMinor)
7277
{
73-
return _theBus->readRegisterByte(kSfeQwiicBuzzerRegFirmwareMinor, versionMinor);
78+
sfeTkError_t err;
79+
err = _theBus->readRegisterByte(kSfeQwiicBuzzerRegFirmwareMinor, versionMinor);
80+
if (err == kSTkErrOk)
81+
return true;
82+
else
83+
return false;
7484
}
7585

7686
sfeTkError_t sfeQwiicBuzzer::configureBuzzer(const uint16_t toneFrequency, const uint16_t duration,

src/sfeQwiicBuzzer.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,13 @@ class sfeQwiicBuzzer
6363

6464
/// @brief Reads the Firmware Version Major of the Qwiic Buzzer
6565
/// @param versionMajor Variable where the read results will be stored
66-
/// @return 0 for succuss, negative for errors, positive for warnings
67-
sfeTkError_t firmwareVersionMajor(uint8_t &versionMajor);
66+
/// @return 1 for succuss, 0 error
67+
bool firmwareVersionMajor(uint8_t &versionMajor);
6868

6969
/// @brief Reads the Firmware Version Minor of the Qwiic Buzzer
7070
/// @param versionMinor Variable where the read results will be stored
71-
/// @return 0 for succuss, negative for errors, positive for warnings
72-
sfeTkError_t firmwareVersionMinor(uint8_t &versionMinor);
71+
/// @return 1 for succuss, 0 error
72+
bool firmwareVersionMinor(uint8_t &versionMinor);
7373

7474
/// @brief Configures the Qwiic Buzzer without causing the buzzer to buzz.
7575
/// This allows configuration in silence (before you may want to buzz).

0 commit comments

Comments
 (0)