Small error checking improvement to analogReadResolution()

Author: nseidle

cores/arduino/ard_sup/analog/ap3_analog.cpp

@@ -204,9 +204,15 @@ uint16_t analogRead(uint8_t pinNumber)
 
 //Apollo3 is capapble of 14-bit ADC but Arduino defaults to 10-bit
 //This modifies the global var that controls what is returned from analogRead()
-void analogReadResolution(uint8_t bits)
+ap3_err_t analogReadResolution(uint8_t bits)
 {
-    _analogBits = bits;
+    if (bits > 16)
+    {
+        _analogBits = 16; // max out the resolution when this happens
+        return AP3_ERR;
+    }
+    _analogBits = res;
+    return AP3_OK;
 }
 
 ap3_err_t ap3_adc_setup()

cores/arduino/ard_sup/ap3_analog.h

@@ -42,12 +42,11 @@ ap3_err_t ap3_analog_pad_funcsel(ap3_gpio_pad_t padNumber, uint8_t *funcsel);
 ap3_err_t ap3_change_channel(ap3_gpio_pad_t padNumber);
 
 uint16_t analogRead(uint8_t pinNumber);
-void analogReadResolution(uint8_t bits);
-
-ap3_err_t analogWriteResolution( uint8_t res );
-ap3_err_t analogWrite( uint8_t pin, uint32_t val );
-ap3_err_t servoWriteResolution( uint8_t res );
-ap3_err_t servoWrite( uint8_t pin, uint32_t val );
+ap3_err_t analogReadResolution(uint8_t bits);
 
+ap3_err_t analogWriteResolution(uint8_t res);
+ap3_err_t analogWrite(uint8_t pin, uint32_t val);
+ap3_err_t servoWriteResolution(uint8_t res);
+ap3_err_t servoWrite(uint8_t pin, uint32_t val);
 
 #endif // _AP3_ANALOG_H_