chore: clean up php helper functions

- remove old get_template_part, references to deleted directories/files
- update comments and docblocks
- remove old helpers documentation

Author: rise-erpelding

docs/helpers.md

@@ -6,5 +6,4 @@
 // https://timber.github.io/docs/reference/timber/#context
 $context = Timber\Timber::context();
 $timber_post = new Timber\Post();
-$context['searchform'] = get_template_part( 'template-parts/content', 'search' );
 Timber\Timber::render( '404.twig', $context );

docs/helpers/generic.md

@@ -15,14 +15,15 @@ function define_theme_globals() {
 
 /**
  * Given an array of attributes, return a string of key="value" pairs separated by spaces.
- * Also handles escaping the attributes.
+ * Also handles escaping the attributes. Can be helpful when creating a template with optional
+ * parameters.
  *
  * Explaining the ('href' === $key) conditional:
  * - It's best practice to escape strings that will be echoed to the page, for security reasons.
  * - In order to correctly escape the $val string, we want to use esc_url or esc_attr respectively.
  *
  * @param array $atts - html attributes.
- * @param array $exclude - attributes to exclude from the output string.
+ * @param array $exclude - attributes to exclude from the output string. Defaults to `[]`.
  * @return string
  */
 function get_attribute_string( $atts, $exclude = array() ) {

src/php/404.php

@@ -34,7 +34,6 @@ function sparkpress_theme_setup() {
 		 */
 		add_theme_support( 'post-thumbnails' );
 
-		// This theme uses wp_nav_menu() in one location.
 		register_nav_menus( array( 'primary' => 'Primary' ) );
 
 		/*
@@ -68,7 +67,8 @@ function sparkpress_theme_setup() {
 function custom_hide_editor() {
 	global $pagenow;
 	$hidden_pages = array(
-		'example-page.php',
+		// specify page templates where main editor should be hidden
+		// 'example-page-template.php',
 	);
 
 	// Only on editor page.