feat: add header component #11
Open
+81
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Extension packages built successfully! |
marissahuysentruyt
requested changes
Dec 2, 2025
Contributor
marissahuysentruyt
left a comment
marissahuysentruyt
left a comment
There was a problem hiding this comment.
I think there's just the one variable that we should be able to safely remove, and this is good to go. 👍
| gap: 1rem; | ||
| align-items: center; | ||
| padding: 1rem 1.5rem; | ||
| /* TODO: The `border-bottom` color is equal to `--cv-color-gray-50` and should be replaced with the variable when implemented */ |
Contributor
There was a problem hiding this comment.
I can create a ticket for this if needed. I think we could add :root to the selector for all of the color variables, or maybe we could to add the .cv class to the topmost .cv-panel div (I think?).
| /* neutrals */ | ||
| --cv-black: hsl(0deg 0% 0%); | ||
| --cv-white: hsl(0deg 0% 100%); | ||
| --cv-grey: hsl(0deg 0% 50%); |
Contributor
There was a problem hiding this comment.
This doesn't look like it's being used in this file. Can we delete it, or am I missing it somewhere else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work adds a header component that is inserted on the welcome and results panels during initialization.
Relevant links
To validate
feat--branding-header-componentnpm iandnpm run build