MacOS & ARM64 support #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for OpenDream. macOS specifically just needs to be supported in the library loader code, by making it use the same dlopen() path as Linux. byondapi.h does not support ARM64 properly due to missing #if statements for it. This leads to DM_64BIT not being set and u4c being miscompiled as a u64. I decided to just work around this by telling bindgen to add that define if the target is aarch64, instead of modifying the header files themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for OpenDream.
macOS specifically just needs to be supported in the library loader code, by making it use the same dlopen() path as Linux.
byondapi.h does not support ARM64 properly due to missing #if statements for it. This leads to DM_64BIT not being set and u4c being miscompiled as a u64. I decided to just work around this by telling bindgen to add that define if the target is aarch64, instead of modifying the header files themselves.