Address shellcheck errors/warnings in build.sh

Author: zbeekman

prerequisites/build.sh

@@ -5,7 +5,7 @@
 #
 #  - Build OpenCoarrays prerequisite packages and their prerequisites
 #
-# Usage: LOG_LEVEL=7 B3B_USE_CASE=/opt/bash3boilerplate/src/use-case ./my-script.sh -f script_input.txt 
+# Usage: LOG_LEVEL=7 B3B_USE_CASE=/opt/bash3boilerplate/src/use-case ./my-script.sh -f script_input.txt
 #
 # More info:
 #
@@ -28,7 +28,7 @@
 # (1) Import several bash3boilerplate helper functions & default settings.
 # (2) Set several variables describing the current file and its usage page.
 # (3) Parse the usage information (default usage file name: current file's name with -usage appended).
-# (4) Parse the command line using the usage information.  
+# (4) Parse the command line using the usage information.
 
 
 export OPENCOARRAYS_SRC_DIR="${OPENCOARRAYS_SRC_DIR:-${PWD}/..}"
@@ -40,9 +40,10 @@ if [[ ! -f "${OPENCOARRAYS_SRC_DIR}/src/libcaf.h" ]]; then
 fi
 export B3B_USE_CASE="${B3B_USE_CASE:-${OPENCOARRAYS_SRC_DIR}/prerequisites/use-case}"
 if [[ ! -f "${B3B_USE_CASE:-}/bootstrap.sh" ]]; then
-  echo "Please set B3B_USE_CASE to the bash3boilerplate use-case directory path." 
+  echo "Please set B3B_USE_CASE to the bash3boilerplate use-case directory path."
   exit 2
 fi
+# shellcheck source=./use-case/bootstrap.sh
 source "${B3B_USE_CASE}/bootstrap.sh" "$@"
 
 
@@ -59,13 +60,14 @@ trap cleanup_before_exit EXIT # The signal is specified here. Could be SIGINT, S
 
 export __flag_present=1
 
+# shellcheck disable=SC2154
 if [[ "${arg_l}" != "${__flag_present}" && "${arg_L}" != "${__flag_present}" &&
       "${arg_v}" != "${__flag_present}" && "${arg_h}" != "${__flag_present}" &&
       -z "${arg_D:-${arg_p:-${arg_P:-${arg_U:-${arg_V}}}}}" ]]; then
   help "${__base}: Insufficient arguments. Please pass either -D, -h, -l, -L, -p, -P, -U, -v, -V, or a longer equivalent."
 fi
 
-# Suppress info and debug messages if -l, -P, -U, -V, -D, or their longer equivalent is present: 
+# Suppress info and debug messages if -l, -P, -U, -V, -D, or their longer equivalent is present:
 [[ "${arg_l}" == "${__flag_present}" || ! -z "${arg_P:-${arg_U:-${arg_V:-${arg_D}}}}" ]] && suppress_info_debug_messages
 
 [ -z "${LOG_LEVEL:-}" ] && emergency "Cannot continue without LOG_LEVEL. "
@@ -75,10 +77,11 @@ fi
 [ ! -z "${arg_P:-}" ] && [ ! -z "${arg_U:-}" ] && emergency "Only specify one of -P, -U, -V, or their long-form equivalents."
 [ ! -z "${arg_U:-}" ] && [ ! -z "${arg_V:-}" ] && emergency "Only specify one of -P, -U, -V, or their long-form equivalents."
 
-### Print bootstrapped magic variables to STDERR when LOG_LEVEL 
+### Print bootstrapped magic variables to STDERR when LOG_LEVEL
 ### is at the default value (6) or above.
 #####################################################################
-
+# shellcheck disable=SC2154
+{
 info "__file: ${__file}"
 info "__dir: ${__dir}"
 info "__base: ${__base}"
@@ -87,8 +90,8 @@ info "__usage: ${__usage}"
 info "LOG_LEVEL: ${LOG_LEVEL}"
 
 info "-b (--branch):           ${arg_b} "
-info "-c (--with-c):           ${arg_c} " 
-info "-C (--with-cpp):         ${arg_C} " 
+info "-c (--with-c):           ${arg_c} "
+info "-C (--with-cpp):         ${arg_C} "
 info "-d (--debug):            ${arg_d} "
 info "-D (--print-downloader): ${arg_D} "
 info "-e (--verbose):          ${arg_e} "
@@ -103,33 +106,41 @@ info "-m (--with-cmake):       ${arg_m} "
 info "-M (--with-mpi):         ${arg_M} "
 info "-n (--no-color):         ${arg_n} "
 info "-p (--package):          ${arg_p}"
-info "-P (--print-path):       ${arg_P} " 
+info "-P (--print-path):       ${arg_P} "
 info "-t (--with-tau):         ${arg_t} "
 info "-U (--print-url):        ${arg_U} "
 info "-v (--version):          ${arg_v} "
 info "-V (--print-version):    ${arg_V} "
-
+}
+# shellcheck source=./build-functions/set_or_print_default_version.sh
 source "${OPENCOARRAYS_SRC_DIR:-}/prerequisites/build-functions/set_or_print_default_version.sh"
 set_or_print_default_version
 export version_to_build="${arg_I:-${default_version}}"
 
+# shellcheck source=./build-functions/set_or_print_downloader.sh
 source "${OPENCOARRAYS_SRC_DIR:-}/prerequisites/build-functions/set_or_print_downloader.sh"
 set_or_print_downloader
 
+# shellcheck source=./build-functions/set_or_print_url.sh
 source "${OPENCOARRAYS_SRC_DIR:-}/prerequisites/build-functions/set_or_print_url.sh"
 set_or_print_url
 
+# shellcheck source=./build-functions/set_or_print_installation_path.sh
 source "${OPENCOARRAYS_SRC_DIR:-}/prerequisites/build-functions/set_or_print_installation_path.sh"
 set_or_print_installation_path
 
+# shellcheck source=./build-functions/download_if_necessary.sh
 source "${OPENCOARRAYS_SRC_DIR:-}/prerequisites/build-functions/download_if_necessary.sh"
 download_if_necessary
 
+# shellcheck source=./build-functions/unpack_if_necessary.sh
 source "${OPENCOARRAYS_SRC_DIR:-}/prerequisites/build-functions/unpack_if_necessary.sh"
 unpack_if_necessary
 
+# shellcheck source=./build-functions/set_compilers.sh
 source "${OPENCOARRAYS_SRC_DIR:-}/prerequisites/build-functions/set_compilers.sh"
 set_compilers
 
+# shellcheck source=./build-functions/build_and_install.sh
 source "${OPENCOARRAYS_SRC_DIR:-}/prerequisites/build-functions/build_and_install.sh"
 build_and_install