return existing dir when 0 items

Author: evict

internal/servegit/serve_test.go

@@ -139,13 +139,15 @@ func gitInit(t *testing.T, path string) {
 
 func gitInitRepos(t *testing.T, names ...string) string {
 	root := t.TempDir()
-	root = filepath.Join(root, "repos-root")
 
-	err := os.Mkdir(root, 0755)
-	if err != nil {
-		t.Fatal(err)
+	// We cannot set root on a non-existent dir so we return tmpdir
+	// creating repos-root first causes issues with test clean-up on Windows.
+	if len(names) == 0 {
+		return root
 	}
 
+	root = filepath.Join(root, "repos-root")
+
 	for _, name := range names {
 		p := filepath.Join(root, name)
 		if err := os.MkdirAll(p, 0755); err != nil {
@@ -175,6 +177,7 @@ func TestIgnoreGitSubmodules(t *testing.T) {
 
 	rootFS, err := os.OpenRoot(root)
 	if err != nil {
+
 		t.Fatal(err)
 	}