ux: toggle change tree node should trigger rows selection changed event

love-linger · love-linger · commit fd5ec5ee4658 · 2024-07-13T09:51:57.000+08:00
diff --git a/src/Views/ChangeCollectionView.axaml.cs b/src/Views/ChangeCollectionView.axaml.cs
@@ -242,7 +242,6 @@ public void ToggleNodeIsExpanded(ChangeTreeNode node)
         {
             if (_displayContext is ChangeCollectionAsTree tree)
             {
-                _disableSelectionChangingEvent = true;
                 node.IsExpanded = !node.IsExpanded;
 
                 var depth = node.Depth;
@@ -269,8 +268,6 @@ public void ToggleNodeIsExpanded(ChangeTreeNode node)
                     }
                     tree.Rows.RemoveRange(idx + 1, removeCount);
                 }
-
-                _disableSelectionChangingEvent = false;
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,6 @@ public void ToggleNodeIsExpanded(ChangeTreeNode node)`
`242`	`242`	`{`
`243`	`243`	`if (_displayContext is ChangeCollectionAsTree tree)`
`244`	`244`	`{`
`245`		`- _disableSelectionChangingEvent = true;`
`246`	`245`	`node.IsExpanded = !node.IsExpanded;`
`247`	`246`
`248`	`247`	`var depth = node.Depth;`
`@@ -269,8 +268,6 @@ public void ToggleNodeIsExpanded(ChangeTreeNode node)`
`269`	`268`	`}`
`270`	`269`	`tree.Rows.RemoveRange(idx + 1, removeCount);`
`271`	`270`	`}`
`272`		`-`
`273`		`- _disableSelectionChangingEvent = false;`
`274`	`271`	`}`
`275`	`272`	`}`
`276`	`273`