fix: background not fill entire text line (#364)

love-linger · love-linger · commit 9f39a9b29510 · 2024-08-16T17:28:00.000+08:00
diff --git a/src/Views/TextDiffView.axaml.cs b/src/Views/TextDiffView.axaml.cs
@@ -172,8 +172,9 @@ public void Draw(TextView textView, DrawingContext drawingContext)
                     if (bg == null)
                         continue;
 
-                    var y = line.GetTextLineVisualYPosition(line.TextLines[0], VisualYPosition.TextTop) - textView.VerticalOffset;
-                    drawingContext.DrawRectangle(bg, null, new Rect(0, y, width, line.Height));
+                    var startY = line.GetTextLineVisualYPosition(line.TextLines[0], VisualYPosition.LineTop) - textView.VerticalOffset;
+                    var endY = line.GetTextLineVisualYPosition(line.TextLines[^1], VisualYPosition.LineBottom) - textView.VerticalOffset;
+                    drawingContext.DrawRectangle(bg, null, new Rect(0, startY, width, endY - startY));
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -172,8 +172,9 @@ public void Draw(TextView textView, DrawingContext drawingContext)`
`172`	`172`	`if (bg == null)`
`173`	`173`	`continue;`
`174`	`174`
`175`		`- var y = line.GetTextLineVisualYPosition(line.TextLines[0], VisualYPosition.TextTop) - textView.VerticalOffset;`
`176`		`- drawingContext.DrawRectangle(bg, null, new Rect(0, y, width, line.Height));`
	`175`	`+ var startY = line.GetTextLineVisualYPosition(line.TextLines[0], VisualYPosition.LineTop) - textView.VerticalOffset;`
	`176`	`+ var endY = line.GetTextLineVisualYPosition(line.TextLines[^1], VisualYPosition.LineBottom) - textView.VerticalOffset;`
	`177`	`+ drawingContext.DrawRectangle(bg, null, new Rect(0, startY, width, endY - startY));`
`177`	`178`	`}`
`178`	`179`	`}`
`179`	`180`