Skip to content

Commit 2d5e048

Browse files
committed
Merge branch 'fix/stage-list-count' into develop from PR #68
2 parents d64b7a7 + ede96c2 commit 2d5e048

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

src/Converters/ListConverters.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ namespace SourceGit.Converters
77
public static class ListConverters
88
{
99
public static readonly FuncValueConverter<IList, string> ToCount =
10-
new FuncValueConverter<IList, string>(v => $" ({v.Count})");
10+
new FuncValueConverter<IList, string>(v => v == null ? " (0)" : $" ({v.Count})");
1111

1212
public static readonly FuncValueConverter<IList, bool> IsNotNullOrEmpty =
1313
new FuncValueConverter<IList, bool>(v => v != null && v.Count > 0);

src/Views/WorkingCopy.axaml

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,32 +20,33 @@
2020
<Grid Grid.Column="0" RowDefinitions="28,*,28,*">
2121
<!-- Unstaged Toolbar -->
2222
<Border Grid.Row="0" BorderThickness="0,0,0,1" BorderBrush="{DynamicResource Brush.Border0}">
23-
<Grid ColumnDefinitions="Auto,Auto,Auto,*,Auto,Auto,Auto,Auto">
23+
<Grid ColumnDefinitions="Auto,Auto,Auto,Auto,*,Auto,Auto,Auto,Auto">
2424
<v:ChangeViewModeSwitcher Grid.Column="0" Width="14" Height="14" Margin="8,0,0,0" ViewMode="{Binding Source={x:Static vm:Preference.Instance}, Path=UnstagedChangeViewMode, Mode=TwoWay}"/>
2525
<TextBlock Grid.Column="1" Text="{DynamicResource Text.WorkingCopy.Unstaged}" Foreground="{DynamicResource Brush.FG2}" FontWeight="Bold" Margin="8,0,0,0"/>
26-
<Path Grid.Column="2" Classes="rotating" Width="14" Height="14" Data="{StaticResource Icons.Loading}" Margin="8,0,0,0" IsVisible="{Binding IsStaging}"/>
26+
<TextBlock Grid.Column="2" FontWeight="Bold" Foreground="{DynamicResource Brush.FG2}" Text="{Binding Unstaged, Converter={x:Static c:ListConverters.ToCount}}"/>
27+
<Path Grid.Column="3" Classes="rotating" Width="14" Height="14" Data="{StaticResource Icons.Loading}" Margin="8,0,0,0" IsVisible="{Binding IsStaging}"/>
2728

28-
<Button Grid.Column="4"
29+
<Button Grid.Column="5"
2930
Classes="icon_button"
3031
Width="26" Height="14"
3132
Padding="0"
3233
ToolTip.Tip="{DynamicResource Text.WorkingCopy.Unstaged.ViewAssumeUnchaged}"
3334
Click="ViewAssumeUnchanged">
3435
<Path Width="14" Height="14" Data="{StaticResource Icons.File.Ignore}"/>
3536
</Button>
36-
<ToggleButton Grid.Column="5"
37+
<ToggleButton Grid.Column="6"
3738
Classes="toggle_untracked"
3839
Width="26" Height="14"
3940
ToolTip.Tip="{DynamicResource Text.WorkingCopy.IncludeUntracked}"
4041
IsChecked="{Binding $parent[v:Repository].DataContext.(vm:Repository).IncludeUntracked, Mode=TwoWay}"/>
41-
<Button Grid.Column="6"
42+
<Button Grid.Column="7"
4243
Classes="icon_button"
4344
Width="26" Height="14"
4445
Padding="0"
4546
ToolTip.Tip="{DynamicResource Text.WorkingCopy.Unstaged.Stage}" Click="StageSelected">
4647
<Path Width="14" Height="14" Margin="0,6,0,0" Data="{StaticResource Icons.Down}"/>
4748
</Button>
48-
<Button Grid.Column="7"
49+
<Button Grid.Column="8"
4950
Classes="icon_button"
5051
Width="26" Height="14"
5152
Padding="0"
@@ -167,14 +168,15 @@
167168

168169
<!-- Staged Toolbar -->
169170
<Border Grid.Row="2" BorderThickness="0,1" BorderBrush="{DynamicResource Brush.Border0}">
170-
<Grid ColumnDefinitions="Auto,Auto,Auto,*,Auto,Auto">
171+
<Grid ColumnDefinitions="Auto,Auto,Auto,Auto,*,Auto,Auto">
171172
<v:ChangeViewModeSwitcher Grid.Column="0" Width="14" Height="14" Margin="8,0,0,0" ViewMode="{Binding Source={x:Static vm:Preference.Instance}, Path=StagedChangeViewMode, Mode=TwoWay}"/>
172173
<TextBlock Grid.Column="1" Text="{DynamicResource Text.WorkingCopy.Staged}" Foreground="{DynamicResource Brush.FG2}" FontWeight="Bold" Margin="8,0,0,0"/>
173-
<Path Grid.Column="2" Classes="rotating" Width="14" Height="14" Data="{StaticResource Icons.Loading}" Margin="8,0,0,0" IsVisible="{Binding IsUnstaging}"/>
174-
<Button Grid.Column="4" Classes="icon_button" Width="26" Height="14" Padding="0" ToolTip.Tip="{DynamicResource Text.WorkingCopy.Staged.Unstage}" Click="UnstageSelected">
174+
<TextBlock Grid.Column="2" FontWeight="Bold" Foreground="{DynamicResource Brush.FG2}" Text="{Binding Staged, Converter={x:Static c:ListConverters.ToCount}}"/>
175+
<Path Grid.Column="3" Classes="rotating" Width="14" Height="14" Data="{StaticResource Icons.Loading}" Margin="8,0,0,0" IsVisible="{Binding IsUnstaging}"/>
176+
<Button Grid.Column="5" Classes="icon_button" Width="26" Height="14" Padding="0" ToolTip.Tip="{DynamicResource Text.WorkingCopy.Staged.Unstage}" Click="UnstageSelected">
175177
<Path Width="14" Height="14" Margin="0,6,0,0" Data="{StaticResource Icons.Up}"/>
176178
</Button>
177-
<Button Grid.Column="5" Classes="icon_button" Width="26" Height="14" Padding="0" ToolTip.Tip="{DynamicResource Text.WorkingCopy.Staged.UnstageAll}" Click="UnstageAll">
179+
<Button Grid.Column="6" Classes="icon_button" Width="26" Height="14" Padding="0" ToolTip.Tip="{DynamicResource Text.WorkingCopy.Staged.UnstageAll}" Click="UnstageAll">
178180
<Path Width="14" Height="14" Data="{StaticResource Icons.DoubleUp}"/>
179181
</Button>
180182
</Grid>

0 commit comments

Comments
 (0)