Merge branch 'release/v8.13'

Author: love-linger

README.md

@@ -39,8 +39,8 @@ This software creates a folder `$"{System.Environment.SpecialFolder.ApplicationD
 | OS | PATH |
 | --- | --- |
 | Windows | `C:\Users\USER_NAME\AppData\Roaming\SourceGit` |
-| Linux | `/home/USER_NAME/.config/SourceGit` |
-| macOS | `/Users/USER_NAME/.config/SourceGit` |
+| Linux | `${HOME}/.config/SourceGit` |
+| macOS | `${HOME}/Library/Application Support/SourceGit` |
 
 For **Windows** users:
 

VERSION

@@ -1 +1 @@
-8.12
+8.13

build/build.osx.command

@@ -24,7 +24,7 @@ chmod 755 -R $RPM_BUILD_ROOT
 
 %files
 /opt
-/usr/bin
+%attr(555,root,root)/usr/bin
 /usr/share
 
 %changelog

build/resources/rpm/SPECS/build.spec

@@ -26,12 +26,12 @@
   <NativeMenu.Menu>
     <NativeMenu>
       <NativeMenuItem Header="{DynamicResource Text.About.Menu}" Command="{x:Static s:App.OpenAboutCommand}"/>
-      <NativeMenuItem Header="{DynamicResource Text.Hotkeys.Menu}" Command="{x:Static s:App.OpenHotkeysCommand}"/>
+      <NativeMenuItem Header="{DynamicResource Text.Hotkeys}" Command="{x:Static s:App.OpenHotkeysCommand}"/>
       <NativeMenuItem Header="{DynamicResource Text.SelfUpdate}" Command="{x:Static s:App.CheckForUpdateCommand}"/>
       <NativeMenuItemSeparator/>
       <NativeMenuItem Header="{DynamicResource Text.Preference}" Command="{x:Static s:App.OpenPreferenceCommand}" Gesture="⌘+,"/>
       <NativeMenuItemSeparator/>
-      <NativeMenuItem Header="{DynamicResource Text.Quit}" Command="{x:Static s:App.QuitCommand}"/>
+      <NativeMenuItem Header="{DynamicResource Text.Quit}" Command="{x:Static s:App.QuitCommand}" Gesture="⌘+Q"/>
     </NativeMenu>
   </NativeMenu.Menu>
 </Application>

screenshots/theme_dark.png

@@ -266,6 +266,7 @@ public override void OnFrameworkInitializationCompleted()
             if (ApplicationLifetime is IClassicDesktopStyleApplicationLifetime desktop)
             {
                 BindingPlugins.DataValidators.RemoveAt(0);
+                Native.OS.SetupEnternalTools();
 
                 var launcher = new Views.Launcher();
                 _notificationReceiver = launcher;

screenshots/theme_light.png

@@ -12,34 +12,23 @@ namespace SourceGit.Models
 {
     public class ExternalTool
     {
-        public string Name { get; set; } = string.Empty;
-        public string Icon { get; set; } = string.Empty;
-        public string Executable { get; set; } = string.Empty;
-        public string OpenCmdArgs { get; set; } = string.Empty;
+        public string Name { get; private set; } = string.Empty;
+        public string Executable { get; private set; } = string.Empty;
+        public string OpenCmdArgs { get; private set; } = string.Empty;
+        public Bitmap IconImage { get; private set; } = null;
 
-        public Bitmap IconImage
+        public ExternalTool(string name, string icon, string executable, string openCmdArgs)
         {
-            get
-            {
-                if (_isFirstTimeGetIcon)
-                {
-                    _isFirstTimeGetIcon = false;
-
-                    if (!string.IsNullOrWhiteSpace(Icon))
-                    {
-                        try
-                        {
-                            var icon = AssetLoader.Open(new Uri($"avares://SourceGit/Resources/ExternalToolIcons/{Icon}.png", UriKind.RelativeOrAbsolute));
-                            _iconImage = new Bitmap(icon);
-                        }
-                        catch
-                        {
-                        }
-                    }
-                }
+            Name = name;
+            Executable = executable;
+            OpenCmdArgs = openCmdArgs;
 
-                return _iconImage;
+            try
+            {
+                var asset = AssetLoader.Open(new Uri($"avares://SourceGit/Resources/ExternalToolIcons/{icon}.png", UriKind.RelativeOrAbsolute));
+                IconImage = new Bitmap(asset);
             }
+            catch { }
         }
 
         public void Open(string repo)
@@ -52,9 +41,6 @@ public void Open(string repo)
                 UseShellExecute = false,
             });
         }
-
-        private bool _isFirstTimeGetIcon = true;
-        private Bitmap _iconImage = null;
     }
 
     public class JetBrainsState
@@ -107,13 +93,7 @@ public void TryAdd(string name, string icon, string args, string env, Func<strin
                     return;
             }
 
-            Founded.Add(new ExternalTool
-            {
-                Name = name,
-                Icon = icon,
-                OpenCmdArgs = args,
-                Executable = path
-            });
+            Founded.Add(new ExternalTool(name, icon, path, args));
         }
 
         public void VSCode(Func<string> platformFinder)
@@ -154,13 +134,11 @@ public void FindJetBrainsFromToolbox(Func<string> platformFinder)
                     if (exclude.Contains(tool.ToolId.ToLowerInvariant()))
                         continue;
 
-                    Founded.Add(new ExternalTool
-                    {
-                        Name = $"{tool.DisplayName} {tool.DisplayVersion}",
-                        Icon = supported_icons.Contains(tool.ProductCode) ? $"JetBrains/{tool.ProductCode}" : $"JetBrains/JB",
-                        OpenCmdArgs = "\"{0}\"",
-                        Executable = Path.Combine(tool.InstallLocation, tool.LaunchCommand),
-                    });
+                    Founded.Add(new ExternalTool(
+                        $"{tool.DisplayName} {tool.DisplayVersion}",
+                        supported_icons.Contains(tool.ProductCode) ? $"JetBrains/{tool.ProductCode}" : "JetBrains/JB",
+                        Path.Combine(tool.InstallLocation, tool.LaunchCommand),
+                        "\"{0}\""));
                 }
             }
         }

src/App.axaml

@@ -25,20 +25,14 @@ public override int GetHashCode()
 
         public static User FindOrAdd(string data)
         {
-            if (_caches.TryGetValue(data, out var value))
+            return _caches.GetOrAdd(data, key =>
             {
-                return value;
-            }
-            else
-            {
-                var nameEndIdx = data.IndexOf('<', System.StringComparison.Ordinal);
-                var name = nameEndIdx >= 2 ? data.Substring(0, nameEndIdx - 1) : string.Empty;
-                var email = data.Substring(nameEndIdx + 1);
-
-                User user = new User() { Name = name, Email = email };
-                _caches.TryAdd(data, user);
-                return user;
-            }
+                var nameEndIdx = key.IndexOf('<', System.StringComparison.Ordinal);
+                var name = nameEndIdx >= 2 ? key.Substring(0, nameEndIdx - 1) : string.Empty;
+                var email = key.Substring(nameEndIdx + 1);
+
+                return new User() { Name = name, Email = email };
+            });
         }
 
         private static ConcurrentDictionary<string, User> _caches = new ConcurrentDictionary<string, User>();