Skip to content

Commit c633804

Browse files
authored
Merge pull request #486 from sosy-lab/feat/spell-check-and-style
Spell check and style improvements
2 parents 3a62853 + dc99d3d commit c633804

File tree

84 files changed

+149
-206
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

84 files changed

+149
-206
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ The visitation of quantified formulas was improved.
158158
## JavaSMT 3.9.0
159159

160160
This release contains a larger update of Princess and more JUnit tests.
161-
The PrettyPrinter is switched from a boolean parameter to a options enum.
161+
The PrettyPrinter is switched from a boolean parameter to an options enum.
162162
The example projects for Maven are updated with newer solver versions.
163163

164164
### Updated solvers:
@@ -181,7 +181,7 @@ if disk space is a critical point.
181181

182182
### Updated solvers:
183183
- MathSAT5 5.6.5 (inculding binary for Windows)
184-
- Z3 4.8.9 (including binaries for Windows and MacOS)
184+
- Z3 4.8.9 (including binaries for Windows and macOS)
185185

186186
## JavaSMT 3.6.1
187187

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ JavaSMT supports several SMT solvers (see [Getting Started](doc/Getting-started.
7676

7777
We support a reasonable list of operating systems and versions.
7878
- Our main target is Linux (mainly Ubuntu or comparable Linux distributions).
79-
Windows 10/11 and MacOS are supported for several SMT solvers.
79+
Windows 10/11 and macOS are supported for several SMT solvers.
8080
- Our main development architecture is x64 (x86-64).
8181
We also provide some solvers for ARM64 (AArch64 for ARMv8-A), e.g., Java-based SMT solvers, Z3, and MathSAT.
8282
If a specific operating system or architecture is missing and required,
@@ -88,7 +88,7 @@ available with Ubuntu 18.04 or later.
8888

8989
² Solver requires at least `GLIBC_2.29`/`GLIBCXX_3.4.26` or `GLIBC_2.34`/`GLIBCXX_3.4.29`,
9090
available with Ubuntu 22.04 or later.
91-
³ We do not provide a signed solver library for MacOS. The user needs to compile and sign it.
91+
³ We do not provide a signed solver library for macOS. The user needs to compile and sign it.
9292

9393
#### Solver Features
9494

build/build-compile.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ SPDX-License-Identifier: Apache-2.0
7474
<src path="${source.dir}"/>
7575
<classpath refid="classpath"/>
7676
<compilerarg value="-Xlint"/>
77-
<compilerarg value="-Xlint:-fallthrough"/> <!-- checked by error-prone, too, and javac does not recognized $FALL-THROUGH$ -->
77+
<compilerarg value="-Xlint:-fallthrough"/> <!-- checked by error-prone, too, and javac does not recognize $FALL-THROUGH$ -->
7878
<compilerarg value="-Xlint:-processing"/>
7979
<compilerarg value="-Xlint:-options"/> <!-- suppress warning about bootclasspath on newer JDK -->
8080
<compilerarg value="-Xlint:-this-escape" if:set="java21"/> <!-- false alarm for every use of configuration injection -->

build/build-documentation.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ SPDX-License-Identifier: Apache-2.0
3737

3838
<classpath refid="classpath"/>
3939

40-
<!-- "-v" is a optional param for verbose output of OptionCollector -->
40+
<!-- "-v" is an optional param for verbose output of OptionCollector -->
4141
<!-- <arg value="-v"/> -->
4242
</java>
4343
<echo message="Options collected." level="info"/>

build/build-ivy.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ SPDX-License-Identifier: Apache-2.0
4646
</condition>
4747
<property name="ivy.cache.dir" location="${tmp.ivy.cache.dir}" />
4848

49-
<!-- If necessary, download Ivy from web site so that it does not need to be installed. -->
49+
<!-- If necessary, download Ivy from website so that it does not need to be installed. -->
5050
<target name="bootstrap-ivy" unless="ivy.jar.present">
5151
<mkdir dir="${ivy.jar.dir}"/>
5252
<echo message="Downloading ivy..."/>

build/build-maven-publish.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ SPDX-License-Identifier: Apache-2.0
4848
</target>
4949

5050
<!-- macro for pushing a JavaSMT file into a Maven repository
51-
(push into the staging area, from there manual publication is required afterwards) -->
51+
(push into the staging area, from there manual publication is required afterward) -->
5252
<macrodef name="stage-javasmt-file">
5353
<attribute name="filename"/>
5454
<attribute name="fileending"/>
@@ -82,7 +82,7 @@ SPDX-License-Identifier: Apache-2.0
8282
</macrodef>
8383

8484
<!-- macro for pushing solvers into a Maven repository
85-
(push into the staging area, from there manual publication is required afterwards) -->
85+
(push into the staging area, from there manual publication is required afterward) -->
8686
<macrodef name="stage-solver-file">
8787
<!-- 'filename' is only used for reading file from file-system, not used "in" Maven -->
8888
<attribute name="filename"/>

build/build-publish-solvers/solver-bitwuzla.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ SPDX-License-Identifier: Apache-2.0
4444
The script will append the git revision.
4545
</fail>
4646
<fail unless="bitwuzla.rebuildWrapper">
47-
Please specify if the Bitwuzla wrapper should be rebuild with the flag
47+
Please specify if the Bitwuzla wrapper should be rebuilt with the flag
4848
-Dbitwuzla.rebuildWrapper=BOOL. Rebuilding the wrapper is necessary if the Bitwuzla API
4949
has changed since the last release, but requires the SWIG tool to be installed on
5050
this machine.
@@ -376,7 +376,7 @@ SPDX-License-Identifier: Apache-2.0
376376
-->
377377
<echo>
378378
Lets copy the files for architecture x64 into main directory, for backwards compatibility.
379-
Afterwards, please execute the SVN command from above.
379+
Afterward, please execute the SVN command from above.
380380
</echo>
381381
<copy todir="repository/${ivy.organisation}/${ivy.module}/" verbose="true">
382382
<fileset dir="repository/${ivy.organisation}/${ivy.module}/x64/">

build/build-publish-solvers/solver-mathsat.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ SPDX-License-Identifier: Apache-2.0
8787
-->
8888
<echo>
8989
Lets copy the files for architecture x64 into main directory, for backwards compatibility.
90-
Afterwards, please execute the SVN command from above.
90+
Afterward, please execute the SVN command from above.
9191
</echo>
9292
<copy todir="repository/${ivy.organisation}/${ivy.module}/" verbose="true">
9393
<fileset dir="repository/${ivy.organisation}/${ivy.module}/x64/">

build/build-publish-solvers/solver-z3.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ SPDX-License-Identifier: Apache-2.0
2424
INFO
2525
Please specify the path to Z3 sources directory with the flag '-Dz3.path=/path/to/z3/z3-unpacked-sources'.
2626
The path should contain directories like './src/' and './scripts/', and can be relative or absolute.
27-
Please provide all unpacked releases (Linux, MacOS, and Windows for x64 and arm64
27+
Please provide all unpacked releases (Linux, macOS, and Windows for x64 and arm64
2828
architecture) in the same parent directory './../' above the 'z3.path'.
2929
This script does not expect other z3-related files or directories in the parent directory.
3030
For example, the directory structure can look like this:
@@ -39,7 +39,7 @@ SPDX-License-Identifier: Apache-2.0
3939
|-- z3-z3-4.13.2/ // &lt;-- sources directory as 'z3.path'
4040

4141
This can be achieved by:
42-
- download all artifacts (Linux, MacOS, and Windows for x64 and arm64 architecture)
42+
- download all artifacts (Linux, macOS, and Windows for x64 and arm64 architecture)
4343
from the Z3 release webpage (https://github.com/Z3Prover/z3/releases)
4444
- create an empty directory 'z3/' and unpack all artifact into it.
4545
- in the sources directory execute `python scripts/mk_make.py --java` to generate all
@@ -121,7 +121,7 @@ SPDX-License-Identifier: Apache-2.0
121121
-->
122122
<echo>
123123
Lets copy the files for architecture x64 into main directory, for backwards compatibility.
124-
Afterwards, please execute the SVN command from above.
124+
Afterward, please execute the SVN command from above.
125125
</echo>
126126
<copy todir="repository/${ivy.organisation}/${ivy.module}/" verbose="true">
127127
<fileset dir="repository/${ivy.organisation}/${ivy.module}/x64/">
@@ -155,7 +155,7 @@ SPDX-License-Identifier: Apache-2.0
155155
<!-- cleanup -->
156156
<delete dir="${z3.javadoc.dir}" quiet="true"/>
157157
<!-- then write new files.
158-
Lets ignore minor issues, e.g. using html tag <tt> instead of <code> -->
158+
Let's ignore minor issues, e.g. using html tag <tt> instead of <code> -->
159159
<javadoc
160160
destdir="${z3.javadoc.dir}"
161161
classpathref="classpath"

doc/Developers-How-to-Release-into-Ivy.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ z3/ // <-- parent directory
6464
```
6565

6666
You can prepare the Z3 Java sources on an arbitrary system, as we only prepare
67-
Java sources and JavaDoc for the bindings, but do no compile any native library.
67+
Java sources and JavaDoc for the bindings, but do not compile any native library.
6868
This only depends on a Python3 environment and Java 17 or later.
6969
For simple usage, we provide a Docker definition/environment under `/docker`, in which the following command can be run.
7070

@@ -84,14 +84,14 @@ Finally, follow the instructions shown in the message at the end.
8484
#### Optional (from source for Linux target with older GLIBC)
8585
This step is for the following use case:
8686
Newer releases of Z3 depend on newer versions of GLIBC (>=v2.35),
87-
so we want to compile the Linux release on our own and then combine it with the provided libraries for Windows and MacOS.
87+
so we want to compile the Linux release on our own and then combine it with the provided libraries for Windows and macOS.
8888
We follow the steps from above, download and unpack the given zip archives for all platforms, except the Linux release (where the GLIBC is too new).
8989
For simple usage, we provide a Docker definition/environment under `/docker` (based on Ubuntu 18.04 with GLIBC 2.27),
9090
in which the following build command can be run in the unpacked source directory:
9191
```
9292
python3 scripts/mk_make.py --java && cd build && make -j 2
9393
```
94-
Afterwards copy the native libraries for Linux (`libz3.so` and `libz3java.so`) from the directory
94+
Afterward, copy the native libraries for Linux (`libz3.so` and `libz3java.so`) from the directory
9595
`./build` into `./bin` (if needed, adjust the directory to match the x64 or arm64 path for Linux).
9696
Then perform as written above with adding the additional pre-compiled binaries for other operating systems,
9797
and publish the directory `./bin` with an ant command like the one from above:
@@ -349,7 +349,7 @@ Publish the solver binary from within JavaSMT (adjust all paths to your system!)
349349
ant publish-yices2 -Dyices2.path=../solvers/yices2 -Dgmp.path=../solvers/gmp-6.2.0 -Dgperf.path=../solvers/gperf-3.1 -Dyices2.version=2.6.2-89-g0f77dc4b
350350
```
351351

352-
Afterwards you need to update the version number in `solvers_ivy_conf/ivy_javasmt_yices2.xml` and publish new Java components for Yices2.
352+
Afterward, you need to update the version number in `solvers_ivy_conf/ivy_javasmt_yices2.xml` and publish new Java components for Yices2.
353353

354354
#### Publish the Java components for Yices2
355355

0 commit comments

Comments
 (0)