Skip to content

Commit 3a62853

Browse files
author
BaierD
committed
Revert changes supposed to be on a feature branch
1 parent cae3062 commit 3a62853

25 files changed

+62
-289
lines changed

src/org/sosy_lab/java_smt/api/BasicProverEnvironment.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
import java.util.List;
1616
import java.util.Optional;
1717
import org.checkerframework.checker.nullness.qual.Nullable;
18-
import org.sosy_lab.common.ShutdownManager;
19-
import org.sosy_lab.common.ShutdownNotifier;
2018
import org.sosy_lab.java_smt.api.SolverContext.ProverOptions;
2119

2220
/**
@@ -204,18 +202,4 @@ interface AllSatCallback<R> {
204202
default boolean registerUserPropagator(UserPropagator propagator) {
205203
return false;
206204
}
207-
208-
/**
209-
* Returns the {@link ShutdownManager} registered for this {@link ProverEnvironment}. It is
210-
* guaranteed to be a child of the {@link ShutdownNotifier} given to the creating {@link
211-
* SolverContext}, resulting in shutdown when the {@link SolverContext}s notifier is shutting
212-
* down. The notifier returned here can be shut down independently of the creating contexts
213-
* notifier.
214-
*
215-
* @return a {@link ShutdownManager} who is the child of the {@link ShutdownNotifier} used in the
216-
* creating {@link SolverContext}, that can be used to shut down only this {@link
217-
* ProverEnvironment}.
218-
* @throws UnsupportedOperationException if the solver does not support prover specific shutdown.
219-
*/
220-
ShutdownManager getShutdownManagerForProver() throws UnsupportedOperationException;
221205
}

src/org/sosy_lab/java_smt/basicimpl/AbstractProver.java

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
import java.util.List;
2323
import java.util.Set;
2424
import org.checkerframework.checker.nullness.qual.Nullable;
25-
import org.sosy_lab.common.ShutdownManager;
26-
import org.sosy_lab.common.ShutdownNotifier;
2725
import org.sosy_lab.java_smt.api.BasicProverEnvironment;
2826
import org.sosy_lab.java_smt.api.BooleanFormula;
2927
import org.sosy_lab.java_smt.api.Evaluator;
@@ -49,11 +47,7 @@ public abstract class AbstractProver<T> implements BasicProverEnvironment<T> {
4947

5048
private static final String TEMPLATE = "Please set the prover option %s.";
5149

52-
// Do we even need this?
53-
private final ShutdownNotifier contextShutdownNotifier;
54-
protected final ShutdownManager proverShutdownManager;
55-
56-
protected AbstractProver(ShutdownNotifier pShutdownNotifier, Set<ProverOptions> pOptions) {
50+
protected AbstractProver(Set<ProverOptions> pOptions) {
5751
generateModels = pOptions.contains(ProverOptions.GENERATE_MODELS);
5852
generateAllSat = pOptions.contains(ProverOptions.GENERATE_ALL_SAT);
5953
generateUnsatCores = pOptions.contains(ProverOptions.GENERATE_UNSAT_CORE);
@@ -62,9 +56,6 @@ protected AbstractProver(ShutdownNotifier pShutdownNotifier, Set<ProverOptions>
6256
enableSL = pOptions.contains(ProverOptions.ENABLE_SEPARATION_LOGIC);
6357

6458
assertedFormulas.add(LinkedHashMultimap.create());
65-
66-
contextShutdownNotifier = pShutdownNotifier;
67-
proverShutdownManager = ShutdownManager.createWithParent(contextShutdownNotifier);
6859
}
6960

7061
protected final void checkGenerateModels() {
@@ -167,17 +158,4 @@ public void close() {
167158
closeAllEvaluators();
168159
closed = true;
169160
}
170-
171-
@Override
172-
public ShutdownManager getShutdownManagerForProver() throws UnsupportedOperationException {
173-
return getShutdownManagerForProverImpl();
174-
}
175-
176-
protected ShutdownManager getShutdownManagerForProverImpl() throws UnsupportedOperationException {
177-
// Override this with the prover specific ShutdownManagers notifier for supporting solvers.
178-
// The solver should then use the prover specific ShutdownManagers notifier for stopping
179-
// instead of the contexts' notifier!
180-
throw new UnsupportedOperationException(
181-
"The chosen solver does not support isolated prover " + "shutdown");
182-
}
183161
}

src/org/sosy_lab/java_smt/basicimpl/AbstractProverWithAllSat.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,16 @@
2828
*/
2929
public abstract class AbstractProverWithAllSat<T> extends AbstractProver<T> {
3030

31+
protected final ShutdownNotifier shutdownNotifier;
3132
private final BooleanFormulaManager bmgr;
3233

3334
protected AbstractProverWithAllSat(
3435
Set<ProverOptions> pOptions,
3536
BooleanFormulaManager pBmgr,
3637
ShutdownNotifier pShutdownNotifier) {
37-
super(pShutdownNotifier, pOptions);
38+
super(pOptions);
3839
bmgr = pBmgr;
40+
shutdownNotifier = pShutdownNotifier;
3941
}
4042

4143
@Override
@@ -66,7 +68,7 @@ private <R> void iterateOverAllModels(
6668
AllSatCallback<R> callback, List<BooleanFormula> importantPredicates)
6769
throws SolverException, InterruptedException {
6870
while (!isUnsat()) {
69-
proverShutdownManager.getNotifier().shutdownIfNecessary();
71+
shutdownNotifier.shutdownIfNecessary();
7072

7173
ImmutableList.Builder<BooleanFormula> valuesOfModel = ImmutableList.builder();
7274
try (Evaluator evaluator = getEvaluatorWithoutChecks()) {
@@ -86,11 +88,11 @@ private <R> void iterateOverAllModels(
8688

8789
final ImmutableList<BooleanFormula> values = valuesOfModel.build();
8890
callback.apply(values);
89-
proverShutdownManager.getNotifier().shutdownIfNecessary();
91+
shutdownNotifier.shutdownIfNecessary();
9092

9193
BooleanFormula negatedModel = bmgr.not(bmgr.and(values));
9294
addConstraint(negatedModel);
93-
proverShutdownManager.getNotifier().shutdownIfNecessary();
95+
shutdownNotifier.shutdownIfNecessary();
9496
}
9597
}
9698

@@ -111,7 +113,7 @@ private <R> void iterateOverAllPredicateCombinations(
111113
Deque<BooleanFormula> valuesOfModel)
112114
throws SolverException, InterruptedException {
113115

114-
proverShutdownManager.getNotifier().shutdownIfNecessary();
116+
shutdownNotifier.shutdownIfNecessary();
115117

116118
if (isUnsat()) {
117119
return;

src/org/sosy_lab/java_smt/basicimpl/withAssumptionsWrapper/BasicProverWithAssumptionsWrapper.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import java.util.Collection;
1515
import java.util.List;
1616
import java.util.Optional;
17-
import org.sosy_lab.common.ShutdownManager;
1817
import org.sosy_lab.java_smt.api.BasicProverEnvironment;
1918
import org.sosy_lab.java_smt.api.BooleanFormula;
2019
import org.sosy_lab.java_smt.api.Model;
@@ -129,9 +128,4 @@ public <R> R allSat(AllSatCallback<R> pCallback, List<BooleanFormula> pImportant
129128
clearAssumptions();
130129
return delegate.allSat(pCallback, pImportant);
131130
}
132-
133-
@Override
134-
public ShutdownManager getShutdownManagerForProver() throws UnsupportedOperationException {
135-
return delegate.getShutdownManagerForProver();
136-
}
137131
}

src/org/sosy_lab/java_smt/delegate/debugging/DebuggingBasicProverEnvironment.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import java.util.List;
1515
import java.util.Optional;
1616
import org.checkerframework.checker.nullness.qual.Nullable;
17-
import org.sosy_lab.common.ShutdownManager;
1817
import org.sosy_lab.java_smt.api.BasicProverEnvironment;
1918
import org.sosy_lab.java_smt.api.BooleanFormula;
2019
import org.sosy_lab.java_smt.api.Model;
@@ -30,11 +29,6 @@ class DebuggingBasicProverEnvironment<T> implements BasicProverEnvironment<T> {
3029
debugging = pDebugging;
3130
}
3231

33-
@Override
34-
public ShutdownManager getShutdownManagerForProver() throws UnsupportedOperationException {
35-
return delegate.getShutdownManagerForProver();
36-
}
37-
3832
@Override
3933
public void pop() {
4034
debugging.assertThreadLocal();

src/org/sosy_lab/java_smt/delegate/debugging/DebuggingOptimizationProverEnvironment.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
package org.sosy_lab.java_smt.delegate.debugging;
1010

1111
import java.util.Optional;
12-
import org.sosy_lab.common.ShutdownManager;
1312
import org.sosy_lab.common.rationals.Rational;
1413
import org.sosy_lab.java_smt.api.Formula;
1514
import org.sosy_lab.java_smt.api.OptimizationProverEnvironment;
@@ -27,11 +26,6 @@ public DebuggingOptimizationProverEnvironment(
2726
debugging = pDebugging;
2827
}
2928

30-
@Override
31-
public ShutdownManager getShutdownManagerForProver() throws UnsupportedOperationException {
32-
return delegate.getShutdownManagerForProver();
33-
}
34-
3529
@Override
3630
public int maximize(Formula objective) {
3731
debugging.assertThreadLocal();

src/org/sosy_lab/java_smt/delegate/logging/LoggingBasicProverEnvironment.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import java.util.Optional;
1919
import java.util.logging.Level;
2020
import org.checkerframework.checker.nullness.qual.Nullable;
21-
import org.sosy_lab.common.ShutdownManager;
2221
import org.sosy_lab.common.log.LogManager;
2322
import org.sosy_lab.java_smt.api.BasicProverEnvironment;
2423
import org.sosy_lab.java_smt.api.BooleanFormula;
@@ -39,11 +38,6 @@ class LoggingBasicProverEnvironment<T> implements BasicProverEnvironment<T> {
3938
logger = checkNotNull(pLogger);
4039
}
4140

42-
@Override
43-
public ShutdownManager getShutdownManagerForProver() throws UnsupportedOperationException {
44-
return wrapped.getShutdownManagerForProver();
45-
}
46-
4741
@Override
4842
public @Nullable T push(BooleanFormula f) throws InterruptedException {
4943
logger.log(Level.FINE, "up to level " + level++);

src/org/sosy_lab/java_smt/delegate/statistics/StatisticsBasicProverEnvironment.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import java.util.List;
1515
import java.util.Optional;
1616
import org.checkerframework.checker.nullness.qual.Nullable;
17-
import org.sosy_lab.common.ShutdownManager;
1817
import org.sosy_lab.java_smt.api.BasicProverEnvironment;
1918
import org.sosy_lab.java_smt.api.BooleanFormula;
2019
import org.sosy_lab.java_smt.api.Model;
@@ -36,11 +35,6 @@ class StatisticsBasicProverEnvironment<T> implements BasicProverEnvironment<T> {
3635
stats.provers.getAndIncrement();
3736
}
3837

39-
@Override
40-
public ShutdownManager getShutdownManagerForProver() throws UnsupportedOperationException {
41-
return delegate.getShutdownManagerForProver();
42-
}
43-
4438
@Override
4539
public void pop() {
4640
stats.pop.getAndIncrement();

src/org/sosy_lab/java_smt/delegate/synchronize/SynchronizedBasicProverEnvironment.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import java.util.List;
1616
import java.util.Optional;
1717
import org.checkerframework.checker.nullness.qual.Nullable;
18-
import org.sosy_lab.common.ShutdownManager;
1918
import org.sosy_lab.java_smt.api.BasicProverEnvironment;
2019
import org.sosy_lab.java_smt.api.BooleanFormula;
2120
import org.sosy_lab.java_smt.api.Model;
@@ -32,11 +31,6 @@ class SynchronizedBasicProverEnvironment<T> implements BasicProverEnvironment<T>
3231
sync = checkNotNull(pSync);
3332
}
3433

35-
@Override
36-
public ShutdownManager getShutdownManagerForProver() throws UnsupportedOperationException {
37-
return delegate.getShutdownManagerForProver();
38-
}
39-
4034
@Override
4135
public void pop() {
4236
synchronized (sync) {

src/org/sosy_lab/java_smt/delegate/synchronize/SynchronizedBasicProverEnvironmentWithContext.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import java.util.List;
1717
import java.util.Optional;
1818
import org.checkerframework.checker.nullness.qual.Nullable;
19-
import org.sosy_lab.common.ShutdownManager;
2019
import org.sosy_lab.java_smt.api.BasicProverEnvironment;
2120
import org.sosy_lab.java_smt.api.BooleanFormula;
2221
import org.sosy_lab.java_smt.api.FormulaManager;
@@ -145,11 +144,6 @@ public <R> R allSat(AllSatCallback<R> pCallback, List<BooleanFormula> pImportant
145144
}
146145
}
147146

148-
@Override
149-
public ShutdownManager getShutdownManagerForProver() throws UnsupportedOperationException {
150-
return delegate.getShutdownManagerForProver();
151-
}
152-
153147
private class AllSatCallbackWithContext<R> implements AllSatCallback<R> {
154148

155149
private final AllSatCallback<R> delegateCallback;

0 commit comments

Comments
 (0)