From c7342205d678ba95e20fe89e3694d6a35693d2e9 Mon Sep 17 00:00:00 2001
From: p-8-z <35455697+p-8-z@users.noreply.github.com>
Date: Fri, 30 Jun 2023 16:41:34 +0000
Subject: [PATCH] feature(director): s3 update, make it compatible with other
 providers

---
 .../aws-s3-configuration.md                   | 23 ++++++++-----------
 1 file changed, 9 insertions(+), 14 deletions(-)

diff --git a/configuration/director-configuration/aws-s3-configuration.md b/configuration/director-configuration/aws-s3-configuration.md
index 9092355..be4b35d 100644
--- a/configuration/director-configuration/aws-s3-configuration.md
+++ b/configuration/director-configuration/aws-s3-configuration.md
@@ -12,42 +12,37 @@ AWS Access Key
 
 `AWS_SECRET_ACCESS_KEY=null`
 
-AWS Secret\
+AWS Secret
 
 
-`S3_BUCKET="sorry-cypress"`
-
-AWS S3 Bucket name
 
+`S3_URL="https://s3.amazonaws.com/"`
 
+AWS S3 URL
 
-`S3_REGION="us-east-1"`
-
-AWS S3 Region
 
 
+`S3_BUCKET="sorry-cypress"`
 
-`S3_ACL="public-read"`
-
-[AWS S3 ACL](https://docs.aws.amazon.com/AmazonS3/latest/API/API\_PutObjectAcl.html) for `putObject` operation
+AWS S3 Bucket name
 
 
 
-`S3_READ_URL_PREFIX=null`
+`S3_REGION="us-east-1"`
 
-Custom prefix for generating "read" URL for generated artifacts. By default, the read `${S3_BUCKET}.s3.amazonaws.com/${objectKey}`, if `S3_READ_URL_PREFIX`is set, then it becomes `${S3_READ_URL_PREFIX}/${objectKey}`
+AWS S3 Region
 
 
 
 `S3_IMAGE_KEY_PREFIX=null`
 
-Custom prefix for stored images, if set the prefix will be applied e.g.: `${S3_BUCKET}.s3.amazonaws.com/${S3_IMAGE_KEY_PREFIX}${objectKey}`
+Custom prefix for stored images, if set the prefix will be applied e.g.: `${S3_URL}/${S3_BUCKET}/${S3_IMAGE_KEY_PREFIX}${objectKey}`
 
 
 
 `S3_VIDEO_KEY_PREFIX=null`
 
-Custom prefix for stored videos, if set the prefix will be applied e.g.: `${S3_BUCKET}.s3.amazonaws.com/${S3_VIDEO_KEY_PREFIX}${objectKey}`
+Custom prefix for stored videos, if set the prefix will be applied e.g.: `${S3_URL}/${S3_BUCKET}/${S3_VIDEO_KEY_PREFIX}${objectKey}`