ci: test-checks.sh all sbf code & use nightly only (#30602)

Author: ryoqun

ci/test-checks.sh

@@ -51,10 +51,12 @@ echo --- build environment
 export RUST_BACKTRACE=1
 export RUSTFLAGS="-D warnings -A incomplete_features"
 
+# run cargo check for all rust files in this monorepo for faster turnaround in
+# case of any compilation/build error for nightly
+
 # Only force up-to-date lock files on edge
 if [[ $CI_BASE_BRANCH = "$EDGE_CHANNEL" ]]; then
-  # Exclude --benches as it's not available in rust stable yet
-  if _ scripts/cargo-for-all-lock-files.sh check --locked --tests --bins --examples; then
+  if _ scripts/cargo-for-all-lock-files.sh "+${rust_nightly}" check --locked --workspace --all-targets --features dummy-for-ci-check; then
     true
   else
     check_status=$?
@@ -63,9 +65,6 @@ if [[ $CI_BASE_BRANCH = "$EDGE_CHANNEL" ]]; then
     echo "$0:   [tree (for outdated Cargo.lock sync)|check (for compilation error)|update -p foo --precise x.y.z (for your Cargo.toml update)] ..." >&2
     exit "$check_status"
   fi
-
-   # Ensure nightly and --benches
-  _ scripts/cargo-for-all-lock-files.sh "+${rust_nightly}" check --locked --all-targets
 else
   echo "Note: cargo-for-all-lock-files.sh skipped because $CI_BASE_BRANCH != $EDGE_CHANNEL"
 fi
@@ -76,7 +75,7 @@ nightly_clippy_allows=()
 
 # -Z... is needed because of clippy bug: https://github.com/rust-lang/rust-clippy/issues/4612
 # run nightly clippy for `sdk/` as there's a moderate amount of nightly-only code there
- _ scripts/cargo-for-all-lock-files.sh -- "+${rust_nightly}" clippy -Zunstable-options --all-targets -- \
+ _ scripts/cargo-for-all-lock-files.sh -- "+${rust_nightly}" clippy -Zunstable-options --workspace --all-targets --features dummy-for-ci-check -- \
    --deny=warnings \
    --deny=clippy::integer_arithmetic \
    "${nightly_clippy_allows[@]}"

programs/sbf/Cargo.toml

@@ -66,6 +66,10 @@ edition = { workspace = true }
 [features]
 sbf_c = []
 sbf_rust = []
+dummy-for-ci-check = [
+    "sbf_c",
+    "sbf_rust",
+]
 
 [build-dependencies]
 walkdir = "2"

programs/sbf/benches/bpf_loader.rs

@@ -1,5 +1,7 @@
 #![feature(test)]
 #![cfg(feature = "sbf_c")]
+#![allow(clippy::uninlined_format_args)]
+#![allow(clippy::integer_arithmetic)]
 
 use {solana_rbpf::memory_region::MemoryState, std::slice};
 

programs/sbf/build.rs

@@ -37,6 +37,11 @@ fn rerun_if_changed(files: &[&str], directories: &[&str], excludes: &[&str]) {
 }
 
 fn main() {
+    if env::var("CARGO_FEATURE_DUMMY_FOR_CI_CHECK").is_ok() {
+        println!("cargo:warning=(not a warning) Compiling with host toolchain for CI...");
+        return;
+    }
+
     let sbf_c = env::var("CARGO_FEATURE_SBF_C").is_ok();
     if sbf_c {
         let install_dir = "OUT_DIR=../target/".to_string() + &env::var("PROFILE").unwrap() + "/sbf";

programs/sbf/rust/128bit/src/lib.rs

@@ -1,5 +1,7 @@
 //! Example Rust-based SBF program tests loop iteration
 
+#![allow(clippy::integer_arithmetic)]
+
 extern crate solana_program;
 use solana_program::{custom_heap_default, custom_panic_default, entrypoint::SUCCESS};
 

programs/sbf/rust/128bit_dep/src/lib.rs

@@ -1,5 +1,7 @@
 //! Solana Rust-based SBF program utility functions and types
 
+#![allow(clippy::integer_arithmetic)]
+
 extern crate solana_program;
 
 pub fn uadd(x: u128, y: u128) -> u128 {

programs/sbf/rust/alloc/src/lib.rs

@@ -1,5 +1,7 @@
 //! Example Rust-based SBF program that test dynamic memory allocation
 
+#![allow(clippy::integer_arithmetic)]
+
 #[macro_use]
 extern crate alloc;
 use {
@@ -37,7 +39,7 @@ pub extern "C" fn entrypoint(_input: *mut u8) -> u64 {
             *ptr.add(i) = i as u8;
         }
         for i in 0..ITERS {
-            assert_eq!(*ptr.add(i as usize), i as u8);
+            assert_eq!(*ptr.add(i), i as u8);
         }
         sol_log_64(0x3, 0, 0, 0, u64::from(*ptr.add(42)));
         assert_eq!(*ptr.add(42), 42);

programs/sbf/rust/custom_heap/src/lib.rs

@@ -1,5 +1,7 @@
 //! Example Rust-based SBF that tests out using a custom heap
 
+#![allow(clippy::integer_arithmetic)]
+
 use {
     solana_program::{
         account_info::AccountInfo,

programs/sbf/rust/deprecated_loader/src/lib.rs

@@ -1,6 +1,7 @@
 //! Example Rust-based SBF program that supports the deprecated loader
 
 #![allow(unreachable_code)]
+#![allow(clippy::integer_arithmetic)]
 
 extern crate solana_program;
 use solana_program::{
@@ -23,7 +24,7 @@ fn return_sstruct() -> SStruct {
 #[no_mangle]
 fn custom_panic(info: &core::panic::PanicInfo<'_>) {
     // Full panic reporting
-    msg!(&format!("{}", info));
+    msg!(&format!("{info}"));
 }
 
 solana_program::entrypoint_deprecated!(process_instruction);

programs/sbf/rust/dup_accounts/src/lib.rs

@@ -1,5 +1,7 @@
 //! Example Rust-based SBF program that tests duplicate accounts passed via accounts
 
+#![allow(clippy::integer_arithmetic)]
+
 extern crate solana_program;
 use solana_program::{
     account_info::AccountInfo,