Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Commit 5e1bb0c

Browse files
committed
review fixes 3rd part - move token storage to javadsl package
1 parent eb344b4 commit 5e1bb0c

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
package com.softwaremill.session.javadsl
2+
3+
/**
4+
* Can't use the trait com.softwaremill.session.InMemoryRefreshTokenStorage in Java code, hence this wrapper
5+
* http://stackoverflow.com/questions/7637752/using-scala-traits-with-implemented-methods-in-java
6+
*/
7+
abstract class InMemoryRefreshTokenStorage[T]() extends com.softwaremill.session.InMemoryRefreshTokenStorage[T]

core/src/main/scala/com/softwaremill/session/RefreshTokenStorage.scala

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,3 @@ trait InMemoryRefreshTokenStorage[T] extends RefreshTokenStorage[T] {
6767

6868
def log(msg: String): Unit
6969
}
70-
71-
/**
72-
* Can't use the trait above in Java code, hence this wrapper
73-
* http://stackoverflow.com/questions/7637752/using-scala-traits-with-implemented-methods-in-java
74-
*/
75-
abstract class InMemoryRefreshTokenStorageWrapper[T]() extends InMemoryRefreshTokenStorage[T]

core/src/test/java/com/softwaremill/session/javadsl/HttpSessionAwareDirectivesTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import com.softwaremill.session.CheckHeader;
1414
import com.softwaremill.session.CheckHeaderAndForm;
1515
import com.softwaremill.session.CsrfCheckMode;
16-
import com.softwaremill.session.InMemoryRefreshTokenStorageWrapper;
1716
import com.softwaremill.session.OneOff;
1817
import com.softwaremill.session.RefreshTokenStorage;
1918
import com.softwaremill.session.Refreshable;
@@ -54,7 +53,7 @@ public abstract class HttpSessionAwareDirectivesTest extends JUnitRouteTest {
5453
)
5554
);
5655
// in-memory refresh token storage
57-
private static final RefreshTokenStorage<String> REFRESH_TOKEN_STORAGE = new InMemoryRefreshTokenStorageWrapper<String>() {
56+
private static final RefreshTokenStorage<String> REFRESH_TOKEN_STORAGE = new InMemoryRefreshTokenStorage<String>() {
5857
private Logger logger = Logger.getLogger("TokenStorage");
5958

6059
@Override

example/src/main/java/com/softwaremill/example/JavaExample.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import com.softwaremill.session.BasicSessionEncoder;
1818
import com.softwaremill.session.CheckHeader;
1919
import com.softwaremill.session.CookieST$;
20-
import com.softwaremill.session.InMemoryRefreshTokenStorageWrapper;
20+
import com.softwaremill.session.javadsl.InMemoryRefreshTokenStorage;
2121
import com.softwaremill.session.RefreshTokenStorage;
2222
import com.softwaremill.session.Refreshable;
2323
import com.softwaremill.session.SessionConfig;
@@ -38,7 +38,7 @@ public class JavaExample extends HttpSessionAwareDirectives<MySession> {
3838
private static final SessionEncoder<MySession> BASIC_ENCODER = new BasicSessionEncoder<>(MySession.getSerializer());
3939

4040
// in-memory refresh token storage
41-
private static final RefreshTokenStorage<MySession> REFRESH_TOKEN_STORAGE = new InMemoryRefreshTokenStorageWrapper<MySession>() {
41+
private static final RefreshTokenStorage<MySession> REFRESH_TOKEN_STORAGE = new InMemoryRefreshTokenStorage<MySession>() {
4242
@Override
4343
public void log(String msg) {
4444
logger.info(msg);

example/src/main/java/com/softwaremill/example/JavaJwtExample.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import akka.stream.javadsl.Flow;
1717
import com.softwaremill.session.CheckHeader;
1818
import com.softwaremill.session.CookieST$;
19-
import com.softwaremill.session.InMemoryRefreshTokenStorageWrapper;
19+
import com.softwaremill.session.javadsl.InMemoryRefreshTokenStorage;
2020
import com.softwaremill.session.JValueSessionSerializer$;
2121
import com.softwaremill.session.JwtSessionEncoder;
2222
import com.softwaremill.session.RefreshTokenStorage;
@@ -40,7 +40,7 @@ public class JavaJwtExample extends HttpSessionAwareDirectives<String> {
4040
private static final SessionEncoder<String> JWT_ENCODER = new JwtSessionEncoder<>(JValueSessionSerializer$.MODULE$.stringToJValueSessionSerializer(), DefaultFormats$.MODULE$);
4141

4242
// in-memory refresh token storage
43-
private static final RefreshTokenStorage<String> REFRESH_TOKEN_STORAGE = new InMemoryRefreshTokenStorageWrapper<String>() {
43+
private static final RefreshTokenStorage<String> REFRESH_TOKEN_STORAGE = new InMemoryRefreshTokenStorage<String>() {
4444
@Override
4545
public void log(String msg) {
4646
logger.info(msg);

0 commit comments

Comments
 (0)