Skip to content

Commit c8c8af2

Browse files
revert #1167 (#1176)
1 parent bbfc49d commit c8c8af2

File tree

3 files changed

+5
-26
lines changed

3 files changed

+5
-26
lines changed

starknet_py/net/gateway_client.py

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -147,8 +147,7 @@ async def get_state_update(
147147
self,
148148
block_hash: Optional[Union[Hash, Tag]] = None,
149149
block_number: Optional[Union[int, Tag]] = None,
150-
# TODO (#1166): revert to `bool = False`
151-
include_block: Optional[bool] = None,
150+
include_block: bool = False,
152151
) -> Union[BlockStateUpdate, StateUpdateWithBlock]:
153152
"""
154153
Get the information about the result of executing the requested block.
@@ -158,26 +157,13 @@ async def get_state_update(
158157
:param include_block: Flag deciding whether to include the queried block. Defaults to false.
159158
:return: BlockStateUpdate object representing changes in the requested block.
160159
"""
161-
# TODO (#1166): remove that
162-
if include_block is not None and self._net in [
163-
"https://alpha-mainnet.starknet.io",
164-
"mainnet",
165-
]:
166-
raise ValueError(
167-
"Argument 'include_block' does not work on mainnet yet and will be working after v0.12.2 release."
168-
)
169-
170160
block_identifier = get_block_identifier(
171161
block_hash=block_hash, block_number=block_number
172162
)
173-
174163
params = {
175164
**block_identifier,
165+
"includeBlock": str(include_block).lower(),
176166
}
177-
# TODO (#1166): bring back into params
178-
if include_block is not None:
179-
params["includeBlock"] = str(include_block).lower()
180-
181167
res = await self._feeder_gateway_client.call(
182168
method_name="get_state_update", params=params
183169
)

starknet_py/net/schemas/gateway.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -261,8 +261,7 @@ class StarknetBlockSchema(Schema):
261261
parent_block_hash = Felt(data_key="parent_block_hash", required=True)
262262
block_number = fields.Integer(data_key="block_number")
263263
status = BlockStatusField(data_key="status", required=True)
264-
# TODO (#1166): change nonprefixedhex to felt in line below
265-
root = NonPrefixedHex(data_key="state_root")
264+
root = Felt(data_key="state_root")
266265
transactions = fields.List(
267266
fields.Nested(TypesOfTransactionsSchema(unknown=EXCLUDE)),
268267
data_key="transactions",
@@ -424,10 +423,8 @@ def make_dataclass(self, data, **kwargs) -> GatewayStateDiff:
424423

425424
class BlockStateUpdateSchema(Schema):
426425
block_hash = Felt(data_key="block_hash", required=True)
427-
# TODO (#1166): change nonprefixedhex to felt in line below
428-
new_root = NonPrefixedHex(data_key="new_root", required=True)
429-
# TODO (#1166): change nonprefixedhex to felt in line below
430-
old_root = NonPrefixedHex(data_key="old_root", required=True)
426+
new_root = Felt(data_key="new_root", required=True)
427+
old_root = Felt(data_key="old_root", required=True)
431428
state_diff = fields.Nested(StateDiffSchema(), data_key="state_diff", required=True)
432429

433430
@post_load

starknet_py/tests/e2e/integration_tests/client_test.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -469,8 +469,4 @@ async def test_get_state_update_different_starknet_versions():
469469

470470
_ = await mainnet.get_state_update(block_number=100000)
471471

472-
with pytest.raises(ValueError):
473-
_ = await mainnet.get_state_update(block_number=100000, include_block=False)
474-
_ = await mainnet.get_state_update(block_number=100000, include_block=True)
475-
476472
_ = await testnet.get_state_update(block_number=100000, include_block=True)

0 commit comments

Comments
 (0)