Refactor signer tests (#1488)

* Refactor ledger signer tests

* Refactor start curve signer tests

* Update mock calculated hash

* Remove unused compiled contract

Author: franciszekjob

starknet_py/tests/unit/signer/test_ledger_signer.py

@@ -1,23 +1,19 @@
 from sys import platform
+from unittest.mock import MagicMock, Mock
 
 import pytest
 
-from starknet_py.common import create_sierra_compiled_contract
 from starknet_py.constants import EIP_2645_PATH_LENGTH
 from starknet_py.contract import Contract
 from starknet_py.hash.address import compute_address
 from starknet_py.hash.selector import get_selector_from_name
 from starknet_py.net.account.account import Account
 from starknet_py.net.client_models import Call
 from starknet_py.net.full_node_client import FullNodeClient
-from starknet_py.net.models import DeclareV3, DeployAccountV1, InvokeV1, StarknetChainId
+from starknet_py.net.models import DeclareV3, DeployAccountV3, InvokeV3, StarknetChainId
 from starknet_py.net.signer.ledger_signer import LedgerSigner
 from starknet_py.tests.e2e.fixtures.accounts import mint_token_on_devnet
-from starknet_py.tests.e2e.fixtures.constants import (
-    MAX_RESOURCE_BOUNDS,
-    STRK_FEE_CONTRACT_ADDRESS,
-)
-from starknet_py.tests.e2e.fixtures.misc import load_contract
+from starknet_py.tests.e2e.fixtures.constants import STRK_FEE_CONTRACT_ADDRESS
 
 
 # TODO (#1425): Currently Ledger tests are skipped on Windows due to different Speculos setup.
@@ -46,39 +42,12 @@ def test_init_with_invalid_derivation_path():
         )
 
 
-compiled_contract = load_contract("HelloStarknet")["sierra"]
-sierra_contract_class = create_sierra_compiled_contract(compiled_contract)
-
-
 @pytest.mark.parametrize(
     "transaction",
     [
-        InvokeV1(
-            sender_address=0x1,
-            calldata=[1, 2, 3],
-            max_fee=10000,
-            signature=[],
-            nonce=23,
-            version=1,
-        ),
-        DeployAccountV1(
-            class_hash=0x1,
-            contract_address_salt=0x2,
-            constructor_calldata=[1, 2, 3, 4],
-            max_fee=10000,
-            signature=[],
-            nonce=23,
-            version=1,
-        ),
-        DeclareV3(
-            contract_class=sierra_contract_class.convert_to_sierra_contract_class(),
-            compiled_class_hash=0x1,
-            sender_address=0x123,
-            signature=[],
-            nonce=4,
-            version=3,
-            resource_bounds=MAX_RESOURCE_BOUNDS,
-        ),
+        Mock(spec=InvokeV3, calculate_hash=MagicMock(return_value=111)),
+        Mock(spec=DeployAccountV3, calculate_hash=MagicMock(return_value=222)),
+        Mock(spec=DeclareV3, calculate_hash=MagicMock(return_value=333)),
     ],
 )
 # TODO (#1425): Currently Ledger tests are skipped on Windows due to different Speculos setup.

starknet_py/tests/unit/signer/test_stark_curve_signer.py

@@ -1,45 +1,18 @@
+from unittest.mock import MagicMock, Mock
+
 import pytest
 
-from starknet_py.common import create_sierra_compiled_contract
 from starknet_py.net.models import StarknetChainId
-from starknet_py.net.models.transaction import DeclareV3, DeployAccountV1, InvokeV1
+from starknet_py.net.models.transaction import DeclareV3, DeployAccountV3, InvokeV3
 from starknet_py.net.signer.stark_curve_signer import KeyPair, StarkCurveSigner
-from starknet_py.tests.e2e.fixtures.constants import MAX_RESOURCE_BOUNDS
-from starknet_py.tests.e2e.fixtures.misc import load_contract
-
-compiled_contract = load_contract("HelloStarknet")["sierra"]
-sierra_contract_class = create_sierra_compiled_contract(compiled_contract)
 
 
 @pytest.mark.parametrize(
     "transaction",
     [
-        InvokeV1(
-            sender_address=0x1,
-            calldata=[1, 2, 3],
-            max_fee=10000,
-            signature=[],
-            nonce=23,
-            version=1,
-        ),
-        DeployAccountV1(
-            class_hash=0x1,
-            contract_address_salt=0x2,
-            constructor_calldata=[1, 2, 3, 4],
-            max_fee=10000,
-            signature=[],
-            nonce=23,
-            version=1,
-        ),
-        DeclareV3(
-            contract_class=sierra_contract_class.convert_to_sierra_contract_class(),
-            compiled_class_hash=0x1,
-            sender_address=0x123,
-            signature=[],
-            nonce=4,
-            version=3,
-            resource_bounds=MAX_RESOURCE_BOUNDS,
-        ),
+        Mock(spec=InvokeV3, calculate_hash=MagicMock(return_value=111)),
+        Mock(spec=DeployAccountV3, calculate_hash=MagicMock(return_value=222)),
+        Mock(spec=DeclareV3, calculate_hash=MagicMock(return_value=333)),
     ],
 )
 def test_sign_transaction(transaction):