Move test_impersonate_account test to tests_on_networks (#1481)

* Move `client_devnet` to `tests_on_networks`

* Fix module path

* Format; Fix linting

* Format

* Fix fixture name

* Format

* Fix linting

* Install devnet in network tests job

* Revert "Install devnet in network tests job"

This reverts commit 20c7313.

* Move devnet client tests back; Move `account_impersonate_test` to network tests

* Add `--contract_dir=v2` arg to `test_ci_on_networks`

* Fix `test_ci_on_networks` args order

* Fix `test_ci_on_networks` args

* Install devnet in network tests job; Move devnet client tests which don't rely on network

* Update "Setup" section

* Move all devnet client tests to network tests

Author: franciszekjob

.github/workflows/checks.yml

@@ -287,6 +287,11 @@ jobs:
         run: |
           poetry install
 
+      # ====================== SETUP DEVNET ====================== #
+
+      - name: Install devnet
+        run: ./starknet_py/tests/install_devnet.sh
+
       # ====================== RUN TESTS ====================== #
 
       - name: Check circular imports

docs/development.rst

@@ -23,12 +23,9 @@ To install `starknet-devnet-rs <https://github.com/0xSpaceShard/starknet-devnet-
 Environment variables
 ^^^^^^^^^^^^^^^^^^^^^
 
-In order to be able to run devnet client tests (``starknet_py/tests/e2e/client_devnet``) you must set environmental variable:
+In order to be able to run tests on testnet network (``starknet_py/tests/e2e/tests_on_networks/``), you must set some environmental variables:
 
     - ``SEPOLIA_RPC_URL``
-
-To run tests on testnet network (``starknet_py/tests/e2e/tests_on_networks/``) additionally you must set:
-
     - ``SEPOLIA_ACCOUNT_PRIVATE_KEY``
     - ``SEPOLIA_ACCOUNT_ADDRESS``
 

pyproject.toml

@@ -66,7 +66,7 @@ test_ci = ["test_ci_v1", "test_ci_v2"]
 test_ci_v1 = "coverage run -a -m pytest --contract_dir=v1 starknet_py --ignore=starknet_py/tests/e2e/docs --ignore=starknet_py/tests/e2e/tests_on_networks"
 test_ci_v2 = "coverage run -a -m pytest --contract_dir=v2 starknet_py --ignore=starknet_py/tests/e2e/docs --ignore=starknet_py/tests/e2e/tests_on_networks"
 
-test_ci_on_networks = "coverage run -a -m pytest starknet_py/tests/e2e/tests_on_networks"
+test_ci_on_networks = "coverage run -a -m pytest --contract_dir=v2 starknet_py/tests/e2e/tests_on_networks"
 
 test_ci_docs = ["test_ci_docs_v1", "test_ci_docs_v2"]
 test_ci_docs_v1 = "coverage run -a -m pytest --contract_dir=v1 starknet_py/tests/e2e/docs"

starknet_py/conftest.py

@@ -11,7 +11,7 @@
     "starknet_py.tests.e2e.client.fixtures.transactions",
     "starknet_py.tests.e2e.client.fixtures.prepare_network",
     "starknet_py.tests.e2e.tests_on_networks.fixtures",
-    "starknet_py.tests.e2e.client_devnet.fixtures.accounts",
-    "starknet_py.tests.e2e.client_devnet.fixtures.clients",
-    "starknet_py.tests.e2e.client_devnet.fixtures.contracts",
+    "starknet_py.tests.e2e.tests_on_networks.client_devnet.fixtures.accounts",
+    "starknet_py.tests.e2e.tests_on_networks.client_devnet.fixtures.clients",
+    "starknet_py.tests.e2e.tests_on_networks.client_devnet.fixtures.contracts",
 ]