Skip to content

Commit 9934ac3

Browse files
authored
Fix windows tests (#1405)
* Update devnet version * Fix test with regex matching
1 parent f6679ab commit 9934ac3

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.github/workflows/checks.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ jobs:
312312
- name: Install devnet
313313
run: |
314314
$DEVNET_INSTALL_DIR = "$(git rev-parse --show-toplevel)/starknet_py/tests/e2e/devnet"
315-
cargo install starknet-devnet --version ${{ env.DEVNET_VERSION }} --root $DEVNET_INSTALL_DIR
315+
cargo install --git https://github.com/0xSpaceShard/starknet-devnet-rs.git --locked --rev 3ad81456092a2da939be1f590855cea2c18ce40c --root $DEVNET_INSTALL_DIR
316316
317317
# ====================== SETUP PYTHON ====================== #
318318

@@ -466,7 +466,7 @@ jobs:
466466
- name: Install devnet
467467
run: |
468468
$DEVNET_INSTALL_DIR = "$(git rev-parse --show-toplevel)/starknet_py/tests/e2e/devnet"
469-
cargo install starknet-devnet --version ${{ env.DEVNET_VERSION }} --root $DEVNET_INSTALL_DIR
469+
cargo install --git https://github.com/0xSpaceShard/starknet-devnet-rs.git --locked --rev 3ad81456092a2da939be1f590855cea2c18ce40c --root $DEVNET_INSTALL_DIR
470470
471471
# ====================== RUN TESTS ====================== #
472472

starknet_py/tests/e2e/client/full_node_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ async def test_get_events_nonexistent_starting_block(
319319
client,
320320
simple_storage_with_event_contract: Contract,
321321
):
322-
with pytest.raises(ClientError, match="Block not found."):
322+
with pytest.raises(ClientError):
323323
await client.get_events(
324324
from_block_number=10000,
325325
to_block_hash="latest",

starknet_py/tests/install_devnet.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set -e
33

44
DEVNET_INSTALL_DIR="$(git rev-parse --show-toplevel)/starknet_py/tests/e2e/devnet/bin"
55
DEVNET_REPO="https://github.com/0xSpaceShard/starknet-devnet-rs"
6-
DEVNET_VERSION="v0.1.2"
6+
DEVNET_VERSION="v0.1.1"
77

88
require_cmd() {
99
if ! command -v "$1" >/dev/null 2>&1; then

0 commit comments

Comments
 (0)