Remove unknown=EXCLUDE after devnet fix response (#1391)

* unknown=EXCLUDE ramoved

* devnet version bump to 0.1.2 and test fix

* fix tests with pending block

* delete print

* remove exclude from get_block

* remove comments

Author: kkawula

starknet_py/net/full_node_client.py

@@ -1,7 +1,6 @@
 from typing import List, Optional, Tuple, Union, cast
 
 import aiohttp
-from marshmallow import EXCLUDE
 
 from starknet_py.constants import RPC_CONTRACT_ERROR
 from starknet_py.hash.utils import keccak256
@@ -119,11 +118,8 @@ async def get_block(
             params=block_identifier,
         )
         if block_identifier == {"block_id": "pending"}:
-            return cast(
-                PendingStarknetBlock,
-                PendingStarknetBlockSchema().load(res, unknown=EXCLUDE),
-            )
-        return cast(StarknetBlock, StarknetBlockSchema().load(res, unknown=EXCLUDE))
+            return cast(PendingStarknetBlock, PendingStarknetBlockSchema().load(res))
+        return cast(StarknetBlock, StarknetBlockSchema().load(res))
 
     async def get_block_with_txs(
         self,
@@ -132,7 +128,6 @@ async def get_block_with_txs(
     ) -> Union[StarknetBlock, PendingStarknetBlock]:
         return await self.get_block(block_hash=block_hash, block_number=block_number)
 
-    # TODO (#1323): remove unknown=EXCLUDE after devnet response fix
     async def get_block_with_tx_hashes(
         self,
         block_hash: Optional[Union[Hash, Tag]] = None,
@@ -150,7 +145,7 @@ async def get_block_with_tx_hashes(
         if block_identifier == {"block_id": "pending"}:
             return cast(
                 PendingStarknetBlockWithTxHashes,
-                PendingStarknetBlockWithTxHashesSchema().load(res, unknown=EXCLUDE),
+                PendingStarknetBlockWithTxHashesSchema().load(res),
             )
         return cast(
             StarknetBlockWithTxHashes,
@@ -288,7 +283,6 @@ async def _get_events_chunk(
             return res["events"], res["continuation_token"]
         return res["events"], None
 
-    # TODO (#1323): remove unknown=EXCLUDE after devnet fix response
     async def get_state_update(
         self,
         block_hash: Optional[Union[Hash, Tag]] = None,
@@ -306,7 +300,7 @@ async def get_state_update(
         if block_identifier == {"block_id": "pending"}:
             return cast(
                 PendingBlockStateUpdate,
-                PendingBlockStateUpdateSchema().load(res, unknown=EXCLUDE),
+                PendingBlockStateUpdateSchema().load(res),
             )
         return cast(BlockStateUpdate, BlockStateUpdateSchema().load(res))
 

starknet_py/tests/e2e/client/client_test.py

@@ -10,6 +10,7 @@
 from starknet_py.hash.storage import get_storage_var_address
 from starknet_py.net.client_errors import ClientError
 from starknet_py.net.client_models import (
+    BlockStateUpdate,
     Call,
     DeclaredContractHash,
     DeclareTransactionV1,
@@ -21,7 +22,6 @@
     FeePayment,
     InvokeTransactionV1,
     L1HandlerTransaction,
-    PendingBlockStateUpdate,
     PriceUnit,
     ResourceBounds,
     SierraContractClass,
@@ -498,10 +498,10 @@ async def test_state_update_storage_diffs(
     )
     await resp.wait_for_acceptance()
 
-    state_update = await client.get_state_update()
+    state_update = await client.get_state_update(block_number="latest")
 
     assert len(state_update.state_diff.storage_diffs) != 0
-    assert isinstance(state_update, PendingBlockStateUpdate)
+    assert isinstance(state_update, BlockStateUpdate)
 
 
 @pytest.mark.run_on_devnet
@@ -510,7 +510,6 @@ async def test_state_update_deployed_contracts(
     class_hash,
     account,
 ):
-    # setup
     deployer = Deployer()
     contract_deployment = deployer.create_contract_deployment(class_hash=class_hash)
     deploy_invoke_tx = await account.sign_invoke_v1(
@@ -519,11 +518,10 @@ async def test_state_update_deployed_contracts(
     resp = await account.client.send_transaction(deploy_invoke_tx)
     await account.client.wait_for_tx(resp.transaction_hash)
 
-    # test
-    state_update = await account.client.get_state_update()
+    state_update = await account.client.get_state_update(block_number="latest")
 
     assert len(state_update.state_diff.deployed_contracts) != 0
-    assert isinstance(state_update, PendingBlockStateUpdate)
+    assert isinstance(state_update, BlockStateUpdate)
 
 
 @pytest.mark.asyncio

starknet_py/tests/e2e/client/full_node_test.py

@@ -319,7 +319,7 @@ async def test_get_events_nonexistent_starting_block(
     client,
     simple_storage_with_event_contract: Contract,
 ):
-    with pytest.raises(ClientError, match="No block found"):
+    with pytest.raises(ClientError, match="Block not found."):
         await client.get_events(
             from_block_number=10000,
             to_block_hash="latest",

starknet_py/tests/install_devnet.sh

@@ -3,7 +3,7 @@ set -e
 
 DEVNET_INSTALL_DIR="$(git rev-parse --show-toplevel)/starknet_py/tests/e2e/devnet/bin"
 DEVNET_REPO="https://github.com/0xSpaceShard/starknet-devnet-rs"
-DEVNET_VERSION="v0.0.5"
+DEVNET_VERSION="v0.1.2"
 
 require_cmd() {
   if ! command -v "$1" >/dev/null 2>&1; then