From aeba23f047c4145eb9310338c3a63a1cca3c8aaa Mon Sep 17 00:00:00 2001 From: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Date: Tue, 26 Aug 2025 18:58:57 +0200 Subject: [PATCH 01/15] use auto with static_cast MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Mateusz Kopciński --- .../common/rnexecutorch/data_processing/FileUtils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native-executorch/common/rnexecutorch/data_processing/FileUtils.h b/packages/react-native-executorch/common/rnexecutorch/data_processing/FileUtils.h index d97be6e69..ab95c78eb 100644 --- a/packages/react-native-executorch/common/rnexecutorch/data_processing/FileUtils.h +++ b/packages/react-native-executorch/common/rnexecutorch/data_processing/FileUtils.h @@ -20,7 +20,7 @@ inline std::string loadBytesFromFile(const std::string &path) { } std::string data; fs.seekg(0, std::ios::end); - size_t size = static_cast(fs.tellg()); + auto size = static_cast(fs.tellg()); fs.seekg(0, std::ios::beg); data.resize(size); fs.read(data.data(), size); From 71b6c70b7ff81e362419f520a6f3e9129834557c Mon Sep 17 00:00:00 2001 From: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Date: Tue, 26 Aug 2025 19:07:17 +0200 Subject: [PATCH 02/15] Update dsp.cpp MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Mateusz Kopciński --- .../common/rnexecutorch/data_processing/dsp.cpp | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp b/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp index d3761dced..fb02fb7a5 100644 --- a/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp +++ b/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp @@ -1,19 +1,21 @@ #include +#include +#include #include #include -#include +#include #include #include namespace rnexecutorch::dsp { -using namespace rnexecutorch::dsp; +using std::numbers::pi_v; std::vector hannWindow(size_t size) { // https://www.mathworks.com/help/signal/ref/hann.html std::vector window(size); for (size_t i = 0; i < size; i++) { - window[i] = 0.5f * (1 - std::cos(2 * M_PI * i / size)); + window[i] = 0.5f * (1 - std::cos(2 * pi_v * i / size)); } return window; } @@ -26,8 +28,8 @@ std::vector stftFromWaveform(std::span waveform, const auto numFrames = 1 + (waveform.size() - fftWindowSize) / hopSize; const auto numBins = fftWindowSize / 2; const auto hann = hannWindow(fftWindowSize); - auto inBuffer = std::vector(fftWindowSize); - auto outBuffer = std::vector>(fftWindowSize); + std::vector inBuffer(fftWindowSize); + std::vector> outBuffer(fftWindowSize); // Output magnitudes in dB std::vector magnitudes; @@ -54,7 +56,7 @@ std::vector stftFromWaveform(std::span waveform, for (size_t i = 0; i < numBins; i++) { const auto magnitude = std::abs(outBuffer[i]) * magnitudeScale; const auto magnitude_db = - dbConversionFactor * log10f(magnitude + epsilon); + dbConversionFactor * std::log10f(magnitude + epsilon); magnitudes.push_back(magnitude_db); } } From 5c1a0bb2bff075e3fb19364413452f6440ba4a1f Mon Sep 17 00:00:00 2001 From: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Date: Wed, 27 Aug 2025 13:19:26 +0200 Subject: [PATCH 03/15] Update packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Mateusz Kopciński --- .../common/rnexecutorch/data_processing/dsp.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp b/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp index fb02fb7a5..c32c2a7e0 100644 --- a/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp +++ b/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp @@ -15,7 +15,7 @@ std::vector hannWindow(size_t size) { // https://www.mathworks.com/help/signal/ref/hann.html std::vector window(size); for (size_t i = 0; i < size; i++) { - window[i] = 0.5f * (1 - std::cos(2 * pi_v * i / size)); + window[i] = 0.5f * (1.0f - std::cosf(2.0f * pi_v * static_cast(i) / static_cast(size))); } return window; } From 354d2acafcb20b65488ce6f1e8494a835a77a053 Mon Sep 17 00:00:00 2001 From: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Date: Thu, 28 Aug 2025 19:00:05 +0200 Subject: [PATCH 04/15] Remove declaration of hannWindow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Mateusz Kopciński --- .../common/rnexecutorch/data_processing/dsp.h | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.h b/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.h index 7eaa26d83..b1d4dd347 100644 --- a/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.h +++ b/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.h @@ -5,7 +5,6 @@ namespace rnexecutorch::dsp { -std::vector hannWindow(size_t size); std::vector stftFromWaveform(std::span waveform, size_t fftWindowSize, size_t hopSize); From 4c602c1375731cce0787e168df62041dfd12d22d Mon Sep 17 00:00:00 2001 From: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Date: Thu, 28 Aug 2025 19:00:38 +0200 Subject: [PATCH 05/15] Update packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Mateusz Kopciński --- .../common/rnexecutorch/data_processing/dsp.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp b/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp index c32c2a7e0..0aa564d94 100644 --- a/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp +++ b/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp @@ -11,7 +11,7 @@ namespace rnexecutorch::dsp { using std::numbers::pi_v; -std::vector hannWindow(size_t size) { +static std::vector hannWindow(size_t size) { // https://www.mathworks.com/help/signal/ref/hann.html std::vector window(size); for (size_t i = 0; i < size; i++) { From 8ae469d643a2fec01d7c2b01106af2fa99730af6 Mon Sep 17 00:00:00 2001 From: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Date: Wed, 8 Oct 2025 18:51:50 +0200 Subject: [PATCH 06/15] Update dsp.cpp MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Mateusz Kopciński --- .../common/rnexecutorch/data_processing/dsp.cpp | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp b/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp index 0aa564d94..9fec1499d 100644 --- a/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp +++ b/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp @@ -11,14 +11,15 @@ namespace rnexecutorch::dsp { using std::numbers::pi_v; -static std::vector hannWindow(size_t size) { - // https://www.mathworks.com/help/signal/ref/hann.html - std::vector window(size); - for (size_t i = 0; i < size; i++) { - window[i] = 0.5f * (1.0f - std::cosf(2.0f * pi_v * static_cast(i) / static_cast(size))); - } - return window; -} +namespace { +std::vector hannWindow(size_t size) { + std::vector window(size); + for (size_t i = 0; i < size; i++) { + window[i] = 0.5f * (1.0f - std::cosf(2.0f * std::numbers::pi_v * static_cast(i) / static_cast(size))); + } + return window; +} +} // namespace std::vector stftFromWaveform(std::span waveform, size_t fftWindowSize, size_t hopSize) { From 6f145329ac0d95ffbc66bf89fce78a9f8ae6ee3c Mon Sep 17 00:00:00 2001 From: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Date: Wed, 8 Oct 2025 18:53:22 +0200 Subject: [PATCH 07/15] Update packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Mateusz Kopciński --- .../common/rnexecutorch/data_processing/dsp.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp b/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp index 9fec1499d..e06b59e44 100644 --- a/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp +++ b/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp @@ -15,7 +15,7 @@ namespace { std::vector hannWindow(size_t size) { std::vector window(size); for (size_t i = 0; i < size; i++) { - window[i] = 0.5f * (1.0f - std::cosf(2.0f * std::numbers::pi_v * static_cast(i) / static_cast(size))); + window[i] = 0.5f * (1.0f - std::cosf(2.0f * pi_v * static_cast(i) / static_cast(size))); } return window; } From d4e6ff31ad8a6593bbf9ed30e0eaba6ad2503c65 Mon Sep 17 00:00:00 2001 From: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Date: Wed, 8 Oct 2025 18:58:59 +0200 Subject: [PATCH 08/15] Update FileUtils.h MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Mateusz Kopciński --- .../common/rnexecutorch/data_processing/FileUtils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native-executorch/common/rnexecutorch/data_processing/FileUtils.h b/packages/react-native-executorch/common/rnexecutorch/data_processing/FileUtils.h index ab95c78eb..3de942df0 100644 --- a/packages/react-native-executorch/common/rnexecutorch/data_processing/FileUtils.h +++ b/packages/react-native-executorch/common/rnexecutorch/data_processing/FileUtils.h @@ -25,6 +25,6 @@ inline std::string loadBytesFromFile(const std::string &path) { data.resize(size); fs.read(data.data(), size); return data; -}; +} } // namespace rnexecutorch::file_utils From eec1a0baf9d4b68f2d1d416e45967605c2f2d22f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20S=C5=82uszniak?= Date: Wed, 8 Oct 2025 19:15:19 +0200 Subject: [PATCH 09/15] Add test for file utils MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Mateusz Kopciński --- .../common/rnexecutorch/tests/CMakeLists.txt | 6 +++- .../rnexecutorch/tests/FileUtilsTest.cpp | 36 +++++++++++++++++++ 2 files changed, 41 insertions(+), 1 deletion(-) create mode 100644 packages/react-native-executorch/common/rnexecutorch/tests/FileUtilsTest.cpp diff --git a/packages/react-native-executorch/common/rnexecutorch/tests/CMakeLists.txt b/packages/react-native-executorch/common/rnexecutorch/tests/CMakeLists.txt index 66758f6b2..82d41e3a8 100644 --- a/packages/react-native-executorch/common/rnexecutorch/tests/CMakeLists.txt +++ b/packages/react-native-executorch/common/rnexecutorch/tests/CMakeLists.txt @@ -14,17 +14,21 @@ include_directories(${CMAKE_SOURCE_DIR}/../data_processing) include_directories(${CMAKE_SOURCE_DIR}/..) # Source files -set(SOURCE_FILES ${CMAKE_SOURCE_DIR}/../data_processing/Numerical.cpp) +set(SOURCE_FILES ${CMAKE_SOURCE_DIR}/../data_processing/Numerical.cpp + ${CMAKE_SOURCE_DIR}/../data_processing/FileUtils.h) # Executables for the tests add_executable(NumericalTests NumericalTest.cpp ${SOURCE_FILES}) +add_executable(FileUtilsTests FileUtilsTest.cpp ${SOURCE_FILES}) add_executable(LogTests LogTest.cpp) # Libraries linking target_link_libraries(NumericalTests gtest gtest_main) +target_link_libraries(FileUtilsTests gtest gtest_main) target_link_libraries(LogTests gtest gtest_main) # Testing functionalities enable_testing() add_test(NAME NumericalTests COMMAND NumericalTests) +add_test(NAME FileUtilsTests COMMAND FileUtilsTests) add_test(NAME LogTests COMMAND LogTests) diff --git a/packages/react-native-executorch/common/rnexecutorch/tests/FileUtilsTest.cpp b/packages/react-native-executorch/common/rnexecutorch/tests/FileUtilsTest.cpp new file mode 100644 index 000000000..bbd31ff07 --- /dev/null +++ b/packages/react-native-executorch/common/rnexecutorch/tests/FileUtilsTest.cpp @@ -0,0 +1,36 @@ +#include "../data_processing/FileUtils.h" +#include +#include +#include + +namespace rnexecutorch::file_utils { +// Test Fixture +class FileIOTest : public ::testing::Test { +protected: + std::string tempFileName = "temp_test_file.txt"; + + void SetUp() override { + // Create a file with some content + std::ofstream out(tempFileName, std::ios::binary); + out << "Hello, world"; + out.close(); + } + + void TearDown() override { + // Delete the file + std::remove(tempFileName.c_str()); + } +}; + +// Positive Test Case +TEST_F(FileIOTest, LoadBytesFromFileSuccessfully) { + std::string data = loadBytesFromFile(tempFileName); + EXPECT_EQ(data, "Hello, world"); +} + +// Negative Test Case +TEST_F(FileIOTest, LoadBytesFromFileFailOnNonExistentFile) { + EXPECT_THROW( + { loadBytesFromFile("non_existent_file.txt"); }, std::runtime_error); +} +} // namespace rnexecutorch::file_utils \ No newline at end of file From 751788051ed3f4c6b4e2aa9df079bbdd48c0a6cc Mon Sep 17 00:00:00 2001 From: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Date: Wed, 8 Oct 2025 19:15:58 +0200 Subject: [PATCH 10/15] Update packages/react-native-executorch/common/rnexecutorch/tests/FileUtilsTest.cpp MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Mateusz Kopciński --- .../common/rnexecutorch/tests/FileUtilsTest.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native-executorch/common/rnexecutorch/tests/FileUtilsTest.cpp b/packages/react-native-executorch/common/rnexecutorch/tests/FileUtilsTest.cpp index bbd31ff07..578674074 100644 --- a/packages/react-native-executorch/common/rnexecutorch/tests/FileUtilsTest.cpp +++ b/packages/react-native-executorch/common/rnexecutorch/tests/FileUtilsTest.cpp @@ -33,4 +33,4 @@ TEST_F(FileIOTest, LoadBytesFromFileFailOnNonExistentFile) { EXPECT_THROW( { loadBytesFromFile("non_existent_file.txt"); }, std::runtime_error); } -} // namespace rnexecutorch::file_utils \ No newline at end of file +} // namespace rnexecutorch::file_utils From 159101d464b7af06a94be00e95d8f2410f0c3592 Mon Sep 17 00:00:00 2001 From: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Date: Thu, 9 Oct 2025 09:22:35 +0200 Subject: [PATCH 11/15] Update runner.cpp MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Mateusz Kopciński --- packages/react-native-executorch/common/runner/runner.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native-executorch/common/runner/runner.cpp b/packages/react-native-executorch/common/runner/runner.cpp index 830d8509c..9e0cffff0 100644 --- a/packages/react-native-executorch/common/runner/runner.cpp +++ b/packages/react-native-executorch/common/runner/runner.cpp @@ -83,7 +83,7 @@ Error Runner::load() { ET_CHECK_OK_OR_RETURN_ERROR(module_->load_method("forward")); // load tokenizer. - auto blob = loadBytesFromFile(tokenizer_path_); + auto blob = rnexecutorch::file_utils::loadBytesFromFile(tokenizer_path_); tokenizer_ = tokenizers::Tokenizer::FromBlobJSON(blob); ET_LOG(Info, "Reading metadata from model"); From 622b0a1f16a90352fc497020c911f97bf11224c6 Mon Sep 17 00:00:00 2001 From: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Date: Thu, 9 Oct 2025 18:07:36 +0200 Subject: [PATCH 12/15] remove redundant comments from FileUtilsTest.cpp MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Mateusz Kopciński --- .../common/rnexecutorch/tests/FileUtilsTest.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/packages/react-native-executorch/common/rnexecutorch/tests/FileUtilsTest.cpp b/packages/react-native-executorch/common/rnexecutorch/tests/FileUtilsTest.cpp index 578674074..a40c99ebe 100644 --- a/packages/react-native-executorch/common/rnexecutorch/tests/FileUtilsTest.cpp +++ b/packages/react-native-executorch/common/rnexecutorch/tests/FileUtilsTest.cpp @@ -4,31 +4,26 @@ #include namespace rnexecutorch::file_utils { -// Test Fixture class FileIOTest : public ::testing::Test { protected: std::string tempFileName = "temp_test_file.txt"; void SetUp() override { - // Create a file with some content std::ofstream out(tempFileName, std::ios::binary); out << "Hello, world"; out.close(); } void TearDown() override { - // Delete the file std::remove(tempFileName.c_str()); } }; -// Positive Test Case TEST_F(FileIOTest, LoadBytesFromFileSuccessfully) { std::string data = loadBytesFromFile(tempFileName); EXPECT_EQ(data, "Hello, world"); } -// Negative Test Case TEST_F(FileIOTest, LoadBytesFromFileFailOnNonExistentFile) { EXPECT_THROW( { loadBytesFromFile("non_existent_file.txt"); }, std::runtime_error); From 6e6994f52efc95681246ed27ffd86da9206561ce Mon Sep 17 00:00:00 2001 From: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Date: Wed, 8 Oct 2025 18:51:50 +0200 Subject: [PATCH 13/15] Update dsp.cpp MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Mateusz Kopciński --- .../common/rnexecutorch/data_processing/dsp.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp b/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp index e06b59e44..9fec1499d 100644 --- a/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp +++ b/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp @@ -15,7 +15,7 @@ namespace { std::vector hannWindow(size_t size) { std::vector window(size); for (size_t i = 0; i < size; i++) { - window[i] = 0.5f * (1.0f - std::cosf(2.0f * pi_v * static_cast(i) / static_cast(size))); + window[i] = 0.5f * (1.0f - std::cosf(2.0f * std::numbers::pi_v * static_cast(i) / static_cast(size))); } return window; } From 0abb05ad2053640205afa798fe374c1eae4bcbd0 Mon Sep 17 00:00:00 2001 From: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Date: Thu, 23 Oct 2025 14:09:17 +0200 Subject: [PATCH 14/15] Remove loadBytesFromFile function Removed the loadBytesFromFile function that handled file reading. --- .../common/runner/runner.cpp | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/packages/react-native-executorch/common/runner/runner.cpp b/packages/react-native-executorch/common/runner/runner.cpp index 9e0cffff0..e21b60aea 100644 --- a/packages/react-native-executorch/common/runner/runner.cpp +++ b/packages/react-native-executorch/common/runner/runner.cpp @@ -14,6 +14,7 @@ #include #include #include +#include namespace example { @@ -23,20 +24,6 @@ using ::executorch::runtime::Result; namespace llm = ::executorch::extension::llm; -std::string loadBytesFromFile(const std::string &path) { - std::ifstream fs(path, std::ios::in | std::ios::binary); - if (fs.fail()) { - throw std::runtime_error("Failed to open tokenizer file"); - } - std::string data; - fs.seekg(0, std::ios::end); - size_t size = static_cast(fs.tellg()); - fs.seekg(0, std::ios::beg); - data.resize(size); - fs.read(data.data(), size); - return data; -} - namespace { static constexpr auto kEnableDynamicShape = "enable_dynamic_shape"; static constexpr auto kEosIds = "get_eos_ids"; From 5a8255e1f8c2c91d310e2563be7fcf9907860f05 Mon Sep 17 00:00:00 2001 From: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Date: Thu, 23 Oct 2025 14:09:29 +0200 Subject: [PATCH 15/15] Update packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp --- .../common/rnexecutorch/data_processing/dsp.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp b/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp index 9fec1499d..e06b59e44 100644 --- a/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp +++ b/packages/react-native-executorch/common/rnexecutorch/data_processing/dsp.cpp @@ -15,7 +15,7 @@ namespace { std::vector hannWindow(size_t size) { std::vector window(size); for (size_t i = 0; i < size; i++) { - window[i] = 0.5f * (1.0f - std::cosf(2.0f * std::numbers::pi_v * static_cast(i) / static_cast(size))); + window[i] = 0.5f * (1.0f - std::cosf(2.0f * pi_v * static_cast(i) / static_cast(size))); } return window; }