Skip to content

NITs to DSP and FileUtils.h #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

NITs to DSP and FileUtils.h #662

wants to merge 15 commits into from

Conversation

@msluszniak
Copy link
Member

@msluszniak msluszniak commented Oct 23, 2025

Description

Provides small nits to dsp and file utils in c++

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

Run provided unit tests

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

msluszniak and others added 13 commits October 23, 2025 13:37
@msluszniak
use auto with static_cast
aeba23f 
Signed-off-by: Mateusz Kopciński <mateusz.kopcinski@swmansnion.com>
@msluszniak
Update dsp.cpp
71b6c70 
Signed-off-by: Mateusz Kopciński <mateusz.kopcinski@swmansnion.com>
@msluszniak
Update packages/react-native-executorch/common/rnexecutorch/data_proc…
5c1a0bb 
…essing/dsp.cpp

Signed-off-by: Mateusz Kopciński <mateusz.kopcinski@swmansnion.com>
@msluszniak
Remove declaration of hannWindow
354d2ac 
Signed-off-by: Mateusz Kopciński <mateusz.kopcinski@swmansnion.com>
@msluszniak
Update packages/react-native-executorch/common/rnexecutorch/data_proc…
4c602c1 
…essing/dsp.cpp

Signed-off-by: Mateusz Kopciński <mateusz.kopcinski@swmansnion.com>
@msluszniak
Update dsp.cpp
8ae469d 
Signed-off-by: Mateusz Kopciński <mateusz.kopcinski@swmansnion.com>
@msluszniak
Update packages/react-native-executorch/common/rnexecutorch/data_proc…
6f14532 
…essing/dsp.cpp

Signed-off-by: Mateusz Kopciński <mateusz.kopcinski@swmansnion.com>
@msluszniak
Update FileUtils.h
d4e6ff3 
Signed-off-by: Mateusz Kopciński <mateusz.kopcinski@swmansnion.com>
@msluszniak
Add test for file utils
eec1a0b 
Signed-off-by: Mateusz Kopciński <mateusz.kopcinski@swmansnion.com>
@msluszniak
Update packages/react-native-executorch/common/rnexecutorch/tests/Fil…
7517880 
…eUtilsTest.cpp

Signed-off-by: Mateusz Kopciński <mateusz.kopcinski@swmansnion.com>
@msluszniak
Update runner.cpp
159101d 
Signed-off-by: Mateusz Kopciński <mateusz.kopcinski@swmansnion.com>
@msluszniak
remove redundant comments from FileUtilsTest.cpp
622b0a1 
Signed-off-by: Mateusz Kopciński <mateusz.kopcinski@swmansnion.com>
@msluszniak
Update dsp.cpp
6e6994f 
Signed-off-by: Mateusz Kopciński <mateusz.kopcinski@swmansnion.com>
@msluszniak msluszniak self-assigned this Oct 23, 2025
@msluszniak msluszniak added the chore PRs that are chores label Oct 23, 2025
msluszniak
msluszniak commented Oct 23, 2025
View reviewed changes
@msluszniak
Remove loadBytesFromFile function
0abb05a 
Removed the loadBytesFromFile function that handled file reading.
@msluszniak
Update packages/react-native-executorch/common/rnexecutorch/data_proc…
5a8255e 
…essing/dsp.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IgorSwat IgorSwat Awaiting requested review from IgorSwat

@mkopcins mkopcins Awaiting requested review from mkopcins

At least 1 approving review is required to merge this pull request.

Assignees

@msluszniak msluszniak

Labels

chore PRs that are chores

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msluszniak