refactor(sdk): adjust some parameter names

Author: xeruf

sdk/src/server-api/sc/api/plugins/host/GameLoader.java

@@ -1,6 +1,5 @@
 package sc.api.plugins.host;
 
-import com.thoughtworks.xstream.XStream;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import sc.api.plugins.IGameState;
@@ -73,18 +72,18 @@ public void onGameError(String roomId, ProtocolErrorMessage error) {
   }
 
   @Override
-  public void onGameOver(String roomId, GameResult o) {
+  public void onGameOver(String roomId, GameResult result) {
     this.finished = true;
   }
 
   @Override
-  public void onNewState(String roomId, IGameState o) {
+  public void onNewState(String roomId, IGameState state) {
     logger.debug("Received new state");
     if (!this.finished) {
       for (Class<?> clazz : this.clazzes) {
-        if (clazz.isInstance(o)) {
+        if (clazz.isInstance(state)) {
           logger.debug("Received game info of type {}", clazz.getName());
-          this.obj = clazz.cast(o);
+          this.obj = clazz.cast(state);
           this.finished = true;
           this.client.stop();
         }

sdk/src/server-api/sc/framework/HelperMethods.java

@@ -1,7 +1,5 @@
 package sc.framework;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 import sc.shared.SlotDescriptor;
 
 import java.text.DateFormat;
@@ -11,10 +9,8 @@
 
 public class HelperMethods {
 
-  private static final Logger logger = LoggerFactory.getLogger(HelperMethods.class);
-
-  private static final DateFormat dateTimeFormat = new SimpleDateFormat(
-          "yyyy.MM.dd HH_mm_ss");
+  private static final DateFormat dateTimeFormat =
+      new SimpleDateFormat("yyyy.MM.dd HH_mm_ss");
 
   /**
    * Returns the current date and time as string formatted as yyyy.MM.dd
@@ -45,7 +41,6 @@ public static String generateReplayFilename(String pluginUuid, List<SlotDescript
     replayFileName.append("_");
     replayFileName.append(HelperMethods.getCurrentDateTime().replace(' ', '_'));
     replayFileName.append(".xml");
-    logger.debug("Generated file name {}", replayFileName.toString());
     return replayFileName.toString();
   }